From: Vincent Chen <vincent.chen@sifive.com>
To: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@sifive.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Vincent Chen <vincent.chen@sifive.com>
Subject: [PATCH v2 0/2] riscv: Correct the initialized flow of FP and __fstate_clean()
Date: Wed, 14 Aug 2019 16:23:51 +0800 [thread overview]
Message-ID: <1565771033-1831-1-git-send-email-vincent.chen@sifive.com> (raw)
The following two reasons cause FP registers are sometimes not
initialized before starting the user program.
1. Currently, the FP context is initialized in flush_thread() function
and we expect these initial values to be restored to FP register when
doing FP context switch. However, the FP context switch only occurs in
switch_to function. Hence, if this process does not be scheduled out
and scheduled in before entering the user space, the FP registers
have no chance to initialize.
2. In flush_thread(), the state of reg->sstatus.FS inherits from the
parent. Hence, the state of reg->sstatus.FS may be dirty. If this
process is scheduled out during flush_thread() and initializing the
FP register, the fstate_save() in switch_to will corrupt the FP context
which has been initialized until flush_thread().
In addition, the __fstate_clean() function cannot correctly set the state
of sstatus.FS to SR_FS_CLEAN. These problems will be solved in this patch
set.
Changes since v1:
- Remove unneeded braces
- Remove unneeded ifdef condition
- Make the correction for __fstate_clean() be a RC fix
Vincent Chen (2):
riscv: Correct the initialized flow of FP register
riscv: Make __fstate_clean() work correctly.
arch/riscv/include/asm/switch_to.h | 8 +++++++-
arch/riscv/kernel/process.c | 11 +++++++++--
2 files changed, 16 insertions(+), 3 deletions(-)
--
2.7.4
next reply other threads:[~2019-08-14 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 8:23 Vincent Chen [this message]
2019-08-14 8:23 ` [PATCH v2 1/2] riscv: Correct the initialized flow of FP register Vincent Chen
2019-08-14 20:24 ` Paul Walmsley
2019-08-14 8:23 ` [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly Vincent Chen
2019-08-14 20:32 ` Paul Walmsley
2019-08-14 21:29 ` Palmer Dabbelt
2019-08-14 22:17 ` Andreas Schwab
2019-08-15 1:53 ` Palmer Dabbelt
2019-08-15 2:53 ` Vincent Chen
2019-09-11 7:22 ` Geert Uytterhoeven
2019-09-11 7:31 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565771033-1831-1-git-send-email-vincent.chen@sifive.com \
--to=vincent.chen@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).