From: Henry Chen <henryc.chen@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Georgi Djakov <georgi.djakov@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Viresh Kumar <vireshk@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Nicolas Boichat <drinkcat@google.com>,
Fan Chen <fan.chen@mediatek.com>,
James Liao <jamesjj.liao@mediatek.com>,
Weiyi Lu <weiyi.lu@mediatek.com>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC V2 08/11] dt-bindings: interconnect: add MT8183 interconnect dt-bindings
Date: Mon, 19 Aug 2019 09:39:54 +0800 [thread overview]
Message-ID: <1566178794.6371.8.camel@mtksdaap41> (raw)
In-Reply-To: <20190501202753.GA2862@bogus>
Hi Rob,
Sorry for late reply.
On Wed, 2019-05-01 at 15:27 -0500, Rob Herring wrote:
> On Tue, Apr 30, 2019 at 04:51:02PM +0800, Henry Chen wrote:
> > Add interconnect provider dt-bindings for MT8183.
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > .../bindings/interconnect/mtk,mt8183.txt | 24 ++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt
> >
> > diff --git a/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt b/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt
> > new file mode 100644
> > index 0000000..1cf1841
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt
> > @@ -0,0 +1,24 @@
> > +Mediatek MT8183 interconnect binding
>
> This should be part of the dvfsrc binding.
ok, will add these into dvfsrc binding.
>
> > +
> > +MT8183 interconnect providers support dram bandwidth requirements. The provider
> > +is able to communicate with the DVFSRC and send the dram bandwidth to it.
> > +Provider nodes must reside within an DVFSRC device node.
> > +
> > +Required properties :
> > +- compatible : shall contain only one of the following:
> > + "mediatek,mt8183-emi-icc"
> > +- #interconnect-cells : should contain 1
> > +
> > +Examples:
> > +
> > +dvfsrc@10012000 {
> > + compatible = "mediatek,mt8183-dvfsrc";
> > + reg = <0 0x10012000 0 0x1000>;
> > + clocks = <&infracfg CLK_INFRA_DVFSRC>;
> > + clock-names = "dvfsrc";
> > + ddr_emi: interconnect {
> > + compatible = "mediatek,mt8183-emi-icc";
> > + #interconnect-cells = <1>;
>
> No need for a child node here. Just move #interconnect-cells to the
> parent.
Ihave tried and it cannot work if move "#interconnect-cells" to the
parent.
The provider nodes must reside within an DVFSRC device node.
>
> Rob
next prev parent reply other threads:[~2019-08-19 1:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 8:50 [PATCH RFC V2] Add driver for dvfsrc, support for active state of scpsys Henry Chen
2019-04-30 8:50 ` [RFC V2 01/11] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
2019-05-01 20:25 ` Rob Herring
2019-04-30 8:50 ` [RFC V2 02/11] dt-bindings: soc: Add opp table on scpsys bindings Henry Chen
2019-05-01 20:26 ` Rob Herring
2019-04-30 8:50 ` [RFC V2 03/11] soc: mediatek: add support for the performance state Henry Chen
2019-04-30 8:50 ` [RFC V2 04/11] arm64: dts: mt8183: add performance state support of scpsys Henry Chen
2019-04-30 8:50 ` [RFC V2 05/11] soc: mediatek: add header for mediatek SIP interface Henry Chen
2019-04-30 8:51 ` [RFC V2 06/11] soc: mediatek: add MT8183 dvfsrc support Henry Chen
2019-06-10 21:00 ` Ryan Case
2019-08-19 1:35 ` Henry Chen
2019-04-30 8:51 ` [RFC V2 07/11] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2019-04-30 8:51 ` [RFC V2 08/11] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
2019-05-01 20:27 ` Rob Herring
2019-08-19 1:39 ` Henry Chen [this message]
2019-04-30 8:51 ` [RFC V2 09/11] dt-bindings: interconnect: Add header for interconnect node Henry Chen
2019-05-01 20:28 ` Rob Herring
2019-08-19 1:43 ` Henry Chen
2019-04-30 8:51 ` [RFC V2 10/11] interconnect: mediatek: Add mt8183 interconnect provider driver Henry Chen
2019-05-14 6:43 ` Georgi Djakov
2019-08-19 1:53 ` Henry Chen
2019-04-30 8:51 ` [RFC V2 11/11] arm64: dts: mt8183: Add interconnect provider DT nodes Henry Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566178794.6371.8.camel@mtksdaap41 \
--to=henryc.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=fan.chen@mediatek.com \
--cc=georgi.djakov@linaro.org \
--cc=jamesjj.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
--cc=vireshk@kernel.org \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).