linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Rob Herring <robh@kernel.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Paul Burton <paul.burton@mips.com>,
	od@zcrc.me, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: Document JZ47xx VPU auxiliary processor
Date: Wed, 21 Aug 2019 12:47:39 +0200	[thread overview]
Message-ID: <1566384459.1884.0@crapouillou.net> (raw)
In-Reply-To: <20190820205044.GA1223@bogus>

Hi Rob,


Le mar. 20 août 2019 à 22:50, Rob Herring <robh@kernel.org> a écrit :
> On Mon, Jul 29, 2019 at 02:31:07PM -0400, Paul Cercueil wrote:
>>  Inside the Video Processing Unit (VPU) of the recent JZ47xx SoCs 
>> from
>>  Ingenic is a second Xburst MIPS CPU very similar to the main core.
>>  This document describes the devicetree bindings for this auxiliary
>>  processor.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>> 
>>  Notes:
>>      v2: Update TCSM0 address in example
>> 
>>   .../bindings/remoteproc/ingenic,vpu.txt       | 36 
>> +++++++++++++++++++
>>   1 file changed, 36 insertions(+)
>>   create mode 100644 
>> Documentation/devicetree/bindings/remoteproc/ingenic,vpu.txt
>> 
>>  diff --git 
>> a/Documentation/devicetree/bindings/remoteproc/ingenic,vpu.txt 
>> b/Documentation/devicetree/bindings/remoteproc/ingenic,vpu.txt
>>  new file mode 100644
>>  index 000000000000..576f9e582780
>>  --- /dev/null
>>  +++ b/Documentation/devicetree/bindings/remoteproc/ingenic,vpu.txt
>>  @@ -0,0 +1,36 @@
>>  +* Ingenic JZ47xx auxiliary processor
>>  +
>>  +Inside the Video Processing Unit (VPU) of the recent JZ47xx SoCs 
>> from Ingenic
>>  +is a second Xburst MIPS CPU very similar to the main core.
>>  +This document describes the devicetree bindings for this auxiliary 
>> processor.
>>  +
>>  +Required properties:
>>  +- compatible: Should be "ingenic,jz4770-vpu-rproc"
>>  +- reg: Must contain the registers location and length for:
>>  +  * the auxiliary processor,
>>  +  * the Tightly Coupled Shared Memory 0 (TCSM0),
>>  +  * the Tightly Coupled Shared Memory 1 (TCSM1),
>>  +  * the shared SRAM.
>>  +- reg-names: Must contain "aux", "tcsm0", "tcsm1", "sram".
>>  +- clocks: Clock specifier for the AUX and VPU clocks.
>>  +- clock-names: Must contain "aux", "vpu".
>>  +- interrupts: Interrupt specifier for the VPU hardware block.
>>  +
>>  +Example:
>>  +
>>  +vpu: cpu@132a0000 {
> 
> cpu is reserved for CPUs under /cpus/. Use video-codec or 
> video-decoder
> or ?? It's not clear what type of video processing this does.

Hardware decode and encode of mpeg-2 and h264. I guess I'll use 
'video-decoder' then.


> 
>>  +	compatible = "ingenic,jz4770-vpu-rproc";
>>  +
>>  +	reg = <0x132a0000 0x20 /* AUX */
>>  +		   0x132b0000 0x4000 /* TCSM0 */
>>  +		   0x132c0000 0xc000 /* TCSM1 */
>>  +		   0x132f0000 0x7000 /* SRAM */
>>  +	>;
>>  +	reg-names = "aux", "tcsm0", "tcsm1", "sram";
>>  +
>>  +	clocks = <&cgu JZ4770_CLK_AUX>, <&cgu JZ4770_CLK_VPU>;
>>  +	clock-names = "aux", "vpu";
>>  +
>>  +	interrupt-parent = <&cpuintc>;
>>  +	interrupts = <3>;
>>  +};
>>  --
>>  2.21.0.593.g511ec345e18
>> 



      reply	other threads:[~2019-08-21 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 18:31 [PATCH v2 1/3] dt-bindings: Document JZ47xx VPU auxiliary processor Paul Cercueil
2019-07-29 18:31 ` [PATCH v2 2/3] remoteproc: Add prepare/unprepare callbacks Paul Cercueil
2019-07-29 18:31 ` [PATCH v2 3/3] remoteproc: ingenic: Added remoteproc driver Paul Cercueil
2019-08-26 22:25   ` Bjorn Andersson
2019-11-08 18:05     ` Paul Cercueil
2019-08-20 20:50 ` [PATCH v2 1/3] dt-bindings: Document JZ47xx VPU auxiliary processor Rob Herring
2019-08-21 10:47   ` Paul Cercueil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1566384459.1884.0@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=od@zcrc.me \
    --cc=ohad@wizery.com \
    --cc=paul.burton@mips.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).