* [PATCH v2 0/2] Fix GMII2RGMII private field
@ 2019-09-04 14:00 Harini Katakam
2019-09-04 14:00 ` [PATCH v2 1/2] include: mdio: Add driver data helpers Harini Katakam
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Harini Katakam @ 2019-09-04 14:00 UTC (permalink / raw)
To: andrew, f.fainelli, hkallweit1, davem
Cc: michal.simek, netdev, linux-arm-kernel, linux-kernel,
harinikatakamlinux, harini.katakam, radhey.shyam.pandey
Fix the usage of external phy's priv field by gmii2rgmii driver.
Based on net-next.
Harini Katakam (2):
include: mdio: Add driver data helpers
net: phy: gmii2rgmii: Dont use priv field in phy device
drivers/net/phy/xilinx_gmii2rgmii.c | 4 ++--
include/linux/mdio.h | 11 +++++++++++
2 files changed, 13 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] include: mdio: Add driver data helpers
2019-09-04 14:00 [PATCH v2 0/2] Fix GMII2RGMII private field Harini Katakam
@ 2019-09-04 14:00 ` Harini Katakam
2019-09-04 16:46 ` Andrew Lunn
2019-09-04 17:07 ` Florian Fainelli
2019-09-04 14:00 ` [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device Harini Katakam
2019-09-05 10:32 ` [PATCH v2 0/2] Fix GMII2RGMII private field David Miller
2 siblings, 2 replies; 8+ messages in thread
From: Harini Katakam @ 2019-09-04 14:00 UTC (permalink / raw)
To: andrew, f.fainelli, hkallweit1, davem
Cc: michal.simek, netdev, linux-arm-kernel, linux-kernel,
harinikatakamlinux, harini.katakam, radhey.shyam.pandey
Add set/get drv_data helpers for mdio device.
Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
---
v2:
Added this patch driver data helpers in mdio instead of priv field.
include/linux/mdio.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index e8242ad8..a760424 100644
--- a/include/linux/mdio.h
+++ b/include/linux/mdio.h
@@ -68,6 +68,17 @@ struct mdio_driver {
#define to_mdio_driver(d) \
container_of(to_mdio_common_driver(d), struct mdio_driver, mdiodrv)
+/* device driver data */
+static inline void mdiodev_set_drvdata(struct mdio_device *mdio, void *data)
+{
+ dev_set_drvdata(&mdio->dev, data);
+}
+
+static inline void *mdiodev_get_drvdata(struct mdio_device *mdio)
+{
+ return dev_get_drvdata(&mdio->dev);
+}
+
void mdio_device_free(struct mdio_device *mdiodev);
struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr);
int mdio_device_register(struct mdio_device *mdiodev);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device
2019-09-04 14:00 [PATCH v2 0/2] Fix GMII2RGMII private field Harini Katakam
2019-09-04 14:00 ` [PATCH v2 1/2] include: mdio: Add driver data helpers Harini Katakam
@ 2019-09-04 14:00 ` Harini Katakam
2019-09-04 16:47 ` Andrew Lunn
2019-09-04 17:11 ` Florian Fainelli
2019-09-05 10:32 ` [PATCH v2 0/2] Fix GMII2RGMII private field David Miller
2 siblings, 2 replies; 8+ messages in thread
From: Harini Katakam @ 2019-09-04 14:00 UTC (permalink / raw)
To: andrew, f.fainelli, hkallweit1, davem
Cc: michal.simek, netdev, linux-arm-kernel, linux-kernel,
harinikatakamlinux, harini.katakam, radhey.shyam.pandey
Use set/get drv data in phydev's mdio device instead. Phy device priv
field maybe used by the external phy driver and should not be
overwritten.
Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
---
v2:
Use mdio driver data helper.
drivers/net/phy/xilinx_gmii2rgmii.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index 2d14493..151c2a3 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -29,7 +29,7 @@ struct gmii2rgmii {
static int xgmiitorgmii_read_status(struct phy_device *phydev)
{
- struct gmii2rgmii *priv = phydev->priv;
+ struct gmii2rgmii *priv = mdiodev_get_drvdata(&phydev->mdio);
struct mii_bus *bus = priv->mdio->bus;
int addr = priv->mdio->addr;
u16 val = 0;
@@ -90,7 +90,7 @@ static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
memcpy(&priv->conv_phy_drv, priv->phy_dev->drv,
sizeof(struct phy_driver));
priv->conv_phy_drv.read_status = xgmiitorgmii_read_status;
- priv->phy_dev->priv = priv;
+ mdiodev_set_drvdata(&priv->phy_dev->mdio, priv);
priv->phy_dev->drv = &priv->conv_phy_drv;
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] include: mdio: Add driver data helpers
2019-09-04 14:00 ` [PATCH v2 1/2] include: mdio: Add driver data helpers Harini Katakam
@ 2019-09-04 16:46 ` Andrew Lunn
2019-09-04 17:07 ` Florian Fainelli
1 sibling, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2019-09-04 16:46 UTC (permalink / raw)
To: Harini Katakam
Cc: f.fainelli, hkallweit1, davem, michal.simek, netdev,
linux-arm-kernel, linux-kernel, harinikatakamlinux,
radhey.shyam.pandey
On Wed, Sep 04, 2019 at 07:30:20PM +0530, Harini Katakam wrote:
> Add set/get drv_data helpers for mdio device.
>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device
2019-09-04 14:00 ` [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device Harini Katakam
@ 2019-09-04 16:47 ` Andrew Lunn
2019-09-04 17:11 ` Florian Fainelli
1 sibling, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2019-09-04 16:47 UTC (permalink / raw)
To: Harini Katakam
Cc: f.fainelli, hkallweit1, davem, michal.simek, netdev,
linux-arm-kernel, linux-kernel, harinikatakamlinux,
radhey.shyam.pandey
On Wed, Sep 04, 2019 at 07:30:21PM +0530, Harini Katakam wrote:
> Use set/get drv data in phydev's mdio device instead. Phy device priv
> field maybe used by the external phy driver and should not be
> overwritten.
>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] include: mdio: Add driver data helpers
2019-09-04 14:00 ` [PATCH v2 1/2] include: mdio: Add driver data helpers Harini Katakam
2019-09-04 16:46 ` Andrew Lunn
@ 2019-09-04 17:07 ` Florian Fainelli
1 sibling, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2019-09-04 17:07 UTC (permalink / raw)
To: Harini Katakam, andrew, hkallweit1, davem
Cc: michal.simek, netdev, linux-arm-kernel, linux-kernel,
harinikatakamlinux, radhey.shyam.pandey
On 9/4/19 7:00 AM, Harini Katakam wrote:
> Add set/get drv_data helpers for mdio device.
>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device
2019-09-04 14:00 ` [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device Harini Katakam
2019-09-04 16:47 ` Andrew Lunn
@ 2019-09-04 17:11 ` Florian Fainelli
1 sibling, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2019-09-04 17:11 UTC (permalink / raw)
To: Harini Katakam, andrew, hkallweit1, davem
Cc: michal.simek, netdev, linux-arm-kernel, linux-kernel,
harinikatakamlinux, radhey.shyam.pandey
On 9/4/19 7:00 AM, Harini Katakam wrote:
> Use set/get drv data in phydev's mdio device instead. Phy device priv
> field maybe used by the external phy driver and should not be
> overwritten.
>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] Fix GMII2RGMII private field
2019-09-04 14:00 [PATCH v2 0/2] Fix GMII2RGMII private field Harini Katakam
2019-09-04 14:00 ` [PATCH v2 1/2] include: mdio: Add driver data helpers Harini Katakam
2019-09-04 14:00 ` [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device Harini Katakam
@ 2019-09-05 10:32 ` David Miller
2 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2019-09-05 10:32 UTC (permalink / raw)
To: harini.katakam
Cc: andrew, f.fainelli, hkallweit1, michal.simek, netdev,
linux-arm-kernel, linux-kernel, harinikatakamlinux,
radhey.shyam.pandey
From: Harini Katakam <harini.katakam@xilinx.com>
Date: Wed, 4 Sep 2019 19:30:19 +0530
> Fix the usage of external phy's priv field by gmii2rgmii driver.
>
> Based on net-next.
Series applied to net-next.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-09-05 10:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 14:00 [PATCH v2 0/2] Fix GMII2RGMII private field Harini Katakam
2019-09-04 14:00 ` [PATCH v2 1/2] include: mdio: Add driver data helpers Harini Katakam
2019-09-04 16:46 ` Andrew Lunn
2019-09-04 17:07 ` Florian Fainelli
2019-09-04 14:00 ` [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device Harini Katakam
2019-09-04 16:47 ` Andrew Lunn
2019-09-04 17:11 ` Florian Fainelli
2019-09-05 10:32 ` [PATCH v2 0/2] Fix GMII2RGMII private field David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).