From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10FBFC3A5A7 for ; Wed, 4 Sep 2019 15:07:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA10F22CF5 for ; Wed, 4 Sep 2019 15:07:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="jHZXAogL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731325AbfIDPHY (ORCPT ); Wed, 4 Sep 2019 11:07:24 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:36654 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731253AbfIDPHX (ORCPT ); Wed, 4 Sep 2019 11:07:23 -0400 Received: by mail-qt1-f193.google.com with SMTP id o12so13200886qtf.3 for ; Wed, 04 Sep 2019 08:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bjd/DHxyfRBfNYOym7ZeBY5xHPB82GB3Jq5Tu5oVy78=; b=jHZXAogLqBHGjDRqzv2BE9ym48eXzz+4o6+zbnl+BwInpdYGrRMShVv8qzdexPoeb/ vYXQ4ajKw3a/n5aBNC4VhSsCICv9XUxTmuUodSeshCk4Cco25QaHvg6dnhQz8fosfgQW GdcmtgH1mepQHwWgJSzdsueMoCHstNRvLxQsljKBxCFAg5cGuLGIs154VmP0Ux4TBYYy w7zfMEPdPGk3xYXlT/cpYNjKULaAWUvaGi/iHkRX2uHJFAJX5hHbo0tbzy81ZReiW+07 hNNIika7P41kvG85V6UeleEL6El+xVcQL5hTfUbrSzmikyiZQQ2jC3RJ6tCSe3DTHqnZ pQqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bjd/DHxyfRBfNYOym7ZeBY5xHPB82GB3Jq5Tu5oVy78=; b=NP5t96IxdnJrOTyRQxNnl3bVgu5v2nIhaWNUFAiJHOyn/CG8TrpgkFDROv7c0hzrEB 3Q8FQH070HS/REt91Gi0Fe6v8a/La85C05MZYB4XkC1gjvRoqLQEOearo5lsxyzEnydh IieZnQNjIf+1iuIkgyDipNOho0dRCC/fQ8+v8OkbnvA57p0GErtEjvv/oToHvVXIIFJS B+WIo0mx4Tn4xjrkLyHBlK0EPBNDkKLZASwmGkzw5RvcRik+h8ewM683Np+ey8Ik19Er 3cYBK9BMBdVFQfcHM9DY5whRArIAInkrCCdhxsIjJ/ZvW/SLyiNii7sky4SJfxXLtEF8 GfQg== X-Gm-Message-State: APjAAAVxBtjlGfN+YkT24smpxpl8J7cwlJsVwr3j4oqQSe7cLbV67/sK DGwFuK1XoEIQUE4Jp8tGsY6Hmw== X-Google-Smtp-Source: APXvYqyUFuGuP1OqyDPej1C7+ccIcKNGMcWn7j0roB5W+o42SqyZvE7l4bW0iAC0eogfNCEovjMcag== X-Received: by 2002:ac8:295d:: with SMTP id z29mr40394176qtz.168.1567609642691; Wed, 04 Sep 2019 08:07:22 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k54sm1027434qtf.28.2019.09.04.08.07.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Sep 2019 08:07:22 -0700 (PDT) Message-ID: <1567609639.5576.79.camel@lca.pw> Subject: Re: [PATCH] net/skbuff: silence warnings under memory pressure From: Qian Cai To: Sergey Senozhatsky Cc: Sergey Senozhatsky , Michal Hocko , Eric Dumazet , davem@davemloft.net, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Petr Mladek , Steven Rostedt Date: Wed, 04 Sep 2019 11:07:19 -0400 In-Reply-To: <20190904144850.GA8296@tigerII.localdomain> References: <20190903132231.GC18939@dhcp22.suse.cz> <1567525342.5576.60.camel@lca.pw> <20190903185305.GA14028@dhcp22.suse.cz> <1567546948.5576.68.camel@lca.pw> <20190904061501.GB3838@dhcp22.suse.cz> <20190904064144.GA5487@jagdpanzerIV> <20190904065455.GE3838@dhcp22.suse.cz> <20190904071911.GB11968@jagdpanzerIV> <20190904074312.GA25744@jagdpanzerIV> <1567599263.5576.72.camel@lca.pw> <20190904144850.GA8296@tigerII.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-09-04 at 23:48 +0900, Sergey Senozhatsky wrote: > On (09/04/19 08:14), Qian Cai wrote: > > > Plus one more check - waitqueue_active(&log_wait). printk() adds > > > pending irq_work only if there is a user-space process sleeping on > > > log_wait and irq_work is not already scheduled. If the syslog is > > > active or there is noone to wakeup then we don't queue irq_work. > > > > Another possibility for this potential livelock is that those printk() from > > warn_alloc(), dump_stack() and show_mem() increase the time it needs to > > process > > build_skb() allocation failures significantly under memory pressure. As the > > result, ksoftirqd() could be rescheduled during that time via a different > > CPU > > (this is a large x86 NUMA system anyway), > > > > [83605.577256][   C31]  run_ksoftirqd+0x1f/0x40 > > [83605.577256][   C31]  smpboot_thread_fn+0x255/0x440 > > [83605.577256][   C31]  kthread+0x1df/0x200 > > [83605.577256][   C31]  ret_from_fork+0x35/0x40 > > Hum hum hum... > > So I can, _probably_, think of several patches. > > First, move wake_up_klogd() back to console_unlock(). > > Second, move `printk_pending' out of per-CPU region and make it global. > So we will have just one printk irq_work scheduled across all CPUs; > currently we have one irq_work per CPU. I think I sent a patch a long > long time ago, but we never discussed it, as far as I remember. > > > In addition, those printk() will deal with console drivers or even a > > networking > > console, so it is probably not unusual that it could call irq_exit()- > > __do_softirq() at one point and then this livelock. > > Do you use netcon? Because this, theoretically, can open up one more > vector. netcon allocates skbs from ->write() path. We call con drivers' > ->write() from printk_safe context, so should netcon skb allocation > warn we will scedule one more irq_work on that CPU to flush per-CPU > printk_safe buffer. No, I don't use netcon. Just thought to mention it anyway since there could other people use it. > > If this is the case, then we can stop calling console_driver() under > printk_safe. I sent a patch a while ago, but we agreed to keep the > things the way they are, fot the time being. > > Let me think more. > > -ss