From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 701ECC4740C for ; Tue, 10 Sep 2019 01:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CD9D21670 for ; Tue, 10 Sep 2019 01:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391010AbfIJBH7 (ORCPT ); Mon, 9 Sep 2019 21:07:59 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:40958 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727115AbfIJBH7 (ORCPT ); Mon, 9 Sep 2019 21:07:59 -0400 X-UUID: 36793eb043954315b23be36aa610228e-20190910 X-UUID: 36793eb043954315b23be36aa610228e-20190910 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 831663314; Tue, 10 Sep 2019 09:07:51 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Sep 2019 09:07:49 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 09:07:49 +0800 Message-ID: <1568077669.24886.3.camel@mtksdccf07> Subject: Re: [PATCH v2 1/2] mm/page_ext: support to record the last stack of page From: Walter Wu To: David Hildenbrand CC: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Matthias Brugger , Andrew Morton , "Martin Schwidefsky" , Will Deacon , "Andrey Konovalov" , Arnd Bergmann , "Thomas Gleixner" , Michal Hocko , Qian Cai , , , , , , Date: Tue, 10 Sep 2019 09:07:49 +0800 In-Reply-To: <36b5a8e0-2783-4c0e-4fc7-78ea652ba475@redhat.com> References: <20190909085339.25350-1-walter-zh.wu@mediatek.com> <36b5a8e0-2783-4c0e-4fc7-78ea652ba475@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-09-09 at 12:57 +0200, David Hildenbrand wrote: > On 09.09.19 10:53, Walter Wu wrote: > > KASAN will record last stack of page in order to help programmer > > to see memory corruption caused by page. > > > > What is difference between page_owner and our patch? > > page_owner records alloc stack of page, but our patch is to record > > last stack(it may be alloc or free stack of page). > > > > Signed-off-by: Walter Wu > > --- > > mm/page_ext.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/mm/page_ext.c b/mm/page_ext.c > > index 5f5769c7db3b..7ca33dcd9ffa 100644 > > --- a/mm/page_ext.c > > +++ b/mm/page_ext.c > > @@ -65,6 +65,9 @@ static struct page_ext_operations *page_ext_ops[] = { > > #if defined(CONFIG_IDLE_PAGE_TRACKING) && !defined(CONFIG_64BIT) > > &page_idle_ops, > > #endif > > +#ifdef CONFIG_KASAN > > + &page_stack_ops, > > +#endif > > }; > > > > static unsigned long total_usage; > > > > Are you sure this patch compiles? > This is patchsets, it need another patch2. We have verified it by running KASAN UT on Qemu.