From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 3/7] usb: mtu3: support ip-sleep wakeup for MT8183
Date: Mon, 16 Sep 2019 13:45:47 +0800 [thread overview]
Message-ID: <1568612747.7317.72.camel@mhfsdcap03> (raw)
In-Reply-To: <20190911184453.GA2628@roeck-us.net>
On Wed, 2019-09-11 at 11:44 -0700, Guenter Roeck wrote:
> On Fri, Aug 30, 2019 at 03:40:50PM +0800, Chunfeng Yun wrote:
> > Support USB wakeup by ip-sleep mode for MT8183, it's similar to
> > MT8173
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v3: changes micros define
> >
> > v2: no changes
> > ---
> > drivers/usb/mtu3/mtu3_host.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/mtu3/mtu3_host.c b/drivers/usb/mtu3/mtu3_host.c
> > index c871b94f3e6f..4f8208885ebd 100644
> > --- a/drivers/usb/mtu3/mtu3_host.c
> > +++ b/drivers/usb/mtu3/mtu3_host.c
> > @@ -18,6 +18,12 @@
> > #include "mtu3.h"
> > #include "mtu3_dr.h"
> >
> > +/* mt8183 etc */
> > +#define PERI_WK_CTRL0 0x20
> > +#define WC0_IS_C(x) (((x) & 0xf) << 28) /* cycle debounce */
> > +#define WC0_IS_P BIT(12) /* polarity */
> > +#define WC0_IS_EN BIT(6)
> > +
>
> For 64-bit builds, this results in:
>
> drivers/usb/mtu3/mtu3_host.c: In function ‘ssusb_wakeup_ip_sleep_set’:
> ./include/linux/bits.h:6:19: warning:
> conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’}
> changes value from ‘18446744073441120320’ to ‘4026536000’ [-Woverflow]
>
> since WC0_IS_C() is sign extended to 64 bit and then truncated.
Got it, thanks a lot
>
> Observed with gcc 7.4.0 and 8.3.0.
>
> Guenter
>
> > /* mt8173 etc */
> > #define PERI_WK_CTRL1 0x4
> > #define WC1_IS_C(x) (((x) & 0xf) << 26) /* cycle debounce */
> > @@ -30,7 +36,8 @@
> > #define SSC_SPM_INT_EN BIT(1)
> >
> > enum ssusb_uwk_vers {
> > - SSUSB_UWK_V1 = 1,
> > + SSUSB_UWK_V0 = 0,
> > + SSUSB_UWK_V1,
> > SSUSB_UWK_V2,
> > };
> >
> > @@ -43,6 +50,11 @@ static void ssusb_wakeup_ip_sleep_set(struct ssusb_mtk *ssusb, bool enable)
> > u32 reg, msk, val;
> >
> > switch (ssusb->uwk_vers) {
> > + case SSUSB_UWK_V0:
> > + reg = ssusb->uwk_reg_base + PERI_WK_CTRL0;
> > + msk = WC0_IS_EN | WC0_IS_C(0xf) | WC0_IS_P;
> > + val = enable ? (WC0_IS_EN | WC0_IS_C(0x8)) : 0;
> > + break;
> > case SSUSB_UWK_V1:
> > reg = ssusb->uwk_reg_base + PERI_WK_CTRL1;
> > msk = WC1_IS_EN | WC1_IS_C(0xf) | WC1_IS_P;
next prev parent reply other threads:[~2019-09-16 5:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 7:40 [PATCH v3 0/7] add support USB for MT8183 Chunfeng Yun
2019-08-30 7:40 ` [PATCH v3 1/7] dt-bindings: usb: mtu3: support USB wakeup " Chunfeng Yun
2019-09-02 13:39 ` Rob Herring
2019-08-30 7:40 ` [PATCH v3 2/7] dt-bindings: usb: mtk-xhci: " Chunfeng Yun
2019-09-02 13:39 ` Rob Herring
2019-08-30 7:40 ` [PATCH v3 3/7] usb: mtu3: support ip-sleep " Chunfeng Yun
2019-09-02 9:23 ` kbuild test robot
2019-09-11 18:44 ` Guenter Roeck
2019-09-16 5:45 ` Chunfeng Yun [this message]
2019-08-30 7:40 ` [PATCH v3 4/7] usb: mtk-xhci: " Chunfeng Yun
2019-09-02 11:58 ` kbuild test robot
2019-08-30 7:40 ` [PATCH v3 5/7] arm64: dts: mt8183: add usb and phy nodes Chunfeng Yun
2019-09-03 11:25 ` kbuild test robot
2020-05-21 15:06 ` Matthias Brugger
2019-08-30 7:40 ` [PATCH v3 6/7] arm64: dts: mt8183: enable USB remote wakeup Chunfeng Yun
2019-08-30 7:40 ` [PATCH v3 7/7] arm64: dts: mt8183: tune disconnect threshold of u2phy Chunfeng Yun
2019-09-04 1:54 ` [PATCH v3 0/7] add support USB for MT8183 Chunfeng Yun
2019-09-04 7:06 ` Greg Kroah-Hartman
2020-05-21 12:41 ` Matthias Brugger
2020-05-22 1:07 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568612747.7317.72.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).