From: Mark Brown <broonie@kernel.org>
To: YingKun Meng <mengyingkun@loongson.cn>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, loongarch@lists.linux.dev,
loongson-kernel@lists.loongnix.cn
Subject: Re: [ PATCH v2 2/3] ASoC: loongson: Add Loongson ASoC Sound Card Support
Date: Mon, 12 Jun 2023 20:06:19 +0100 [thread overview]
Message-ID: <1568e064-606e-4f56-951f-429a87a3a2d9@sirena.org.uk> (raw)
In-Reply-To: <20230612090046.3039532-1-mengyingkun@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On Mon, Jun 12, 2023 at 05:00:46PM +0800, YingKun Meng wrote:
> + if (ls_card->mclk_fs) {
> + mclk = ls_card->mclk_fs * params_rate(params);
> + ret = snd_soc_dai_set_sysclk(cpu_dai, 0, mclk,
> + SND_SOC_CLOCK_OUT);
> + if (ret < 0) {
> + dev_err(codec_dai->dev, "cpu_dai clock not set\n");
> + return ret;
> + }
Does this need to be in the machine driver - this isn't configuring an
external clock, it's just within the SoC, so presumably the driver for
the SoC DAI can just set itself up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
next prev parent reply other threads:[~2023-06-12 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 9:00 [ PATCH v2 2/3] ASoC: loongson: Add Loongson ASoC Sound Card Support YingKun Meng
2023-06-12 19:06 ` Mark Brown [this message]
2023-06-14 9:14 ` Yingkun Meng
-- strict thread matches above, loose matches on Subject: below --
2023-06-12 8:57 YingKun Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568e064-606e-4f56-951f-429a87a3a2d9@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=mengyingkun@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).