* [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1
@ 2019-10-04 14:55 Alain Volmat
2019-10-07 7:59 ` Pierre Yves MORDRET
0 siblings, 1 reply; 3+ messages in thread
From: Alain Volmat @ 2019-10-04 14:55 UTC (permalink / raw)
To: wsa, pierre-yves.mordret
Cc: alain.volmat, alexandre.torgue, linux-i2c, linux-stm32,
linux-arm-kernel, linux-kernel, fabrice.gasnier
Remove the following warning:
drivers/i2c/busses/i2c-stm32f7.c:315:
warning: cannot understand function prototype:
'struct stm32f7_i2c_spec i2c_specs[] =
Signed-off-by: Alain Volmat <alain.volmat@st.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index d36cf08..7aa4a47 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -305,7 +305,7 @@ struct stm32f7_i2c_dev {
struct regmap *regmap;
};
-/**
+/*
* All these values are coming from I2C Specification, Version 6.0, 4th of
* April 2014.
*
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1
2019-10-04 14:55 [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1 Alain Volmat
@ 2019-10-07 7:59 ` Pierre Yves MORDRET
2019-10-07 12:01 ` Alain Volmat
0 siblings, 1 reply; 3+ messages in thread
From: Pierre Yves MORDRET @ 2019-10-07 7:59 UTC (permalink / raw)
To: Alain Volmat, wsa
Cc: alexandre.torgue, linux-i2c, linux-stm32, linux-arm-kernel,
linux-kernel, fabrice.gasnier
Hi Alain
Fixes tag is missing in your patch.
[ i.e ==> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver") ]
Nonetheless patch only consists in removing a comment character ?
Thanks
On 10/4/19 4:55 PM, Alain Volmat wrote:
> Remove the following warning:
>
> drivers/i2c/busses/i2c-stm32f7.c:315:
> warning: cannot understand function prototype:
> 'struct stm32f7_i2c_spec i2c_specs[] =
>
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index d36cf08..7aa4a47 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -305,7 +305,7 @@ struct stm32f7_i2c_dev {
> struct regmap *regmap;
> };
>
> -/**
> +/*
> * All these values are coming from I2C Specification, Version 6.0, 4th of
> * April 2014.
> *
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1
2019-10-07 7:59 ` Pierre Yves MORDRET
@ 2019-10-07 12:01 ` Alain Volmat
0 siblings, 0 replies; 3+ messages in thread
From: Alain Volmat @ 2019-10-07 12:01 UTC (permalink / raw)
To: Pierre Yves MORDRET
Cc: wsa, alexandre.torgue, linux-i2c, linux-stm32, linux-arm-kernel,
linux-kernel, fabrice.gasnier
Hi Pierre-Yves,
thanks for the comments.
On Mon, Oct 07, 2019 at 09:59:22AM +0200, Pierre Yves MORDRET wrote:
> Hi Alain
>
> Fixes tag is missing in your patch.
> [ i.e ==> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver") ]
Okay, will push a v2 for that.
>
> Nonetheless patch only consists in removing a comment character ?
Yes, the comment currently starts in a way of a kernel-doc description
(https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#function-documentation) leading the compiler to produce the warning since there is no
function prototype after the comment.
Regards,
Alain
>
> Thanks
>
> On 10/4/19 4:55 PM, Alain Volmat wrote:
> > Remove the following warning:
> >
> > drivers/i2c/busses/i2c-stm32f7.c:315:
> > warning: cannot understand function prototype:
> > 'struct stm32f7_i2c_spec i2c_specs[] =
> >
> > Signed-off-by: Alain Volmat <alain.volmat@st.com>
> > ---
> > drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> > index d36cf08..7aa4a47 100644
> > --- a/drivers/i2c/busses/i2c-stm32f7.c
> > +++ b/drivers/i2c/busses/i2c-stm32f7.c
> > @@ -305,7 +305,7 @@ struct stm32f7_i2c_dev {
> > struct regmap *regmap;
> > };
> >
> > -/**
> > +/*
> > * All these values are coming from I2C Specification, Version 6.0, 4th of
> > * April 2014.
> > *
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-07 12:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 14:55 [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1 Alain Volmat
2019-10-07 7:59 ` Pierre Yves MORDRET
2019-10-07 12:01 ` Alain Volmat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).