From: Sumit Garg <sumit.garg@linaro.org>
To: linux-crypto@vger.kernel.org
Cc: dsaxena@plexity.net, herbert@gondor.apana.org.au,
mpm@selenic.com, romain.perier@free-electrons.com, arnd@arndb.de,
gregkh@linuxfoundation.org, daniel.thompson@linaro.org,
ralph.siemsen@linaro.org, milan.stevanovic@se.com,
ryan.harkin@linaro.org, linux-kernel@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>,
stable@vger.kernel.org
Subject: [PATCH] hwrng: omap - Fix RNG wait loop timeout
Date: Mon, 14 Oct 2019 17:32:45 +0530 [thread overview]
Message-ID: <1571054565-6991-1-git-send-email-sumit.garg@linaro.org> (raw)
Existing RNG data read timeout is 200us but it doesn't cover EIP76 RNG
data rate which takes approx. 700us to produce 16 bytes of output data
as per testing results. So configure the timeout as 1000us to also take
account of lack of udelay()'s reliability.
Fixes: 383212425c92 ("hwrng: omap - Add device variant for SafeXcel IP-76 found in Armada 8K")
Cc: <stable@vger.kernel.org>
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
---
drivers/char/hw_random/omap-rng.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index b27f396..e329f82 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -66,6 +66,13 @@
#define OMAP4_RNG_OUTPUT_SIZE 0x8
#define EIP76_RNG_OUTPUT_SIZE 0x10
+/*
+ * EIP76 RNG takes approx. 700us to produce 16 bytes of output data
+ * as per testing results. And to account for the lack of udelay()'s
+ * reliability, we keep the timeout as 1000us.
+ */
+#define RNG_DATA_FILL_TIMEOUT 100
+
enum {
RNG_OUTPUT_0_REG = 0,
RNG_OUTPUT_1_REG,
@@ -176,7 +183,7 @@ static int omap_rng_do_read(struct hwrng *rng, void *data, size_t max,
if (max < priv->pdata->data_size)
return 0;
- for (i = 0; i < 20; i++) {
+ for (i = 0; i < RNG_DATA_FILL_TIMEOUT; i++) {
present = priv->pdata->data_present(priv);
if (present || !wait)
break;
--
2.7.4
next reply other threads:[~2019-10-14 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 12:02 Sumit Garg [this message]
2019-10-14 12:27 ` [PATCH] hwrng: omap - Fix RNG wait loop timeout Daniel Thompson
2019-10-14 13:38 ` Sumit Garg
2019-10-25 15:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571054565-6991-1-git-send-email-sumit.garg@linaro.org \
--to=sumit.garg@linaro.org \
--cc=arnd@arndb.de \
--cc=daniel.thompson@linaro.org \
--cc=dsaxena@plexity.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milan.stevanovic@se.com \
--cc=mpm@selenic.com \
--cc=ralph.siemsen@linaro.org \
--cc=romain.perier@free-electrons.com \
--cc=ryan.harkin@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).