* [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig
@ 2019-10-17 6:28 Ooi, Joyce
2019-10-21 15:56 ` Dinh Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Ooi, Joyce @ 2019-10-17 6:28 UTC (permalink / raw)
To: Vladimir Murzin, Catalin Marinas, Will Deacon, Dinh Nguyen
Cc: Shawn Guo, Olof Johansson, Maxime Ripard, Bjorn Andersson,
Arnd Bergmann, Jagan Teki, Anson Huang, Leonard Crestez,
Marcin Juszkiewicz, linux-arm-kernel, linux-kernel, Joyce Ooi,
Ong Hean Loong, See Chin Liang, Tan Ley Foon
This patch adds JFFS2 FS support and remove QSPI Sector 4K size force in
the default defconfig
Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
---
v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index c9adae4..6080c6e 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y
# CONFIG_DEBUG_PREEMPT is not set
# CONFIG_FTRACE is not set
CONFIG_MEMTEST=y
+CONFIG_JFFS2_FS=y
+# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig
2019-10-17 6:28 [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig Ooi, Joyce
@ 2019-10-21 15:56 ` Dinh Nguyen
2019-10-23 14:17 ` Ooi, Joyce
0 siblings, 1 reply; 3+ messages in thread
From: Dinh Nguyen @ 2019-10-21 15:56 UTC (permalink / raw)
To: Ooi, Joyce, Vladimir Murzin, Catalin Marinas, Will Deacon
Cc: Shawn Guo, Olof Johansson, Maxime Ripard, Bjorn Andersson,
Arnd Bergmann, Jagan Teki, Anson Huang, Leonard Crestez,
Marcin Juszkiewicz, linux-arm-kernel, linux-kernel,
Ong Hean Loong, See Chin Liang, Tan Ley Foon
On 10/17/19 1:28 AM, Ooi, Joyce wrote:
> This patch adds JFFS2 FS support and remove QSPI Sector 4K size force in
> the default defconfig
>
> Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
> ---
> v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax
> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index c9adae4..6080c6e 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y
> # CONFIG_DEBUG_PREEMPT is not set
> # CONFIG_FTRACE is not set
> CONFIG_MEMTEST=y
> +CONFIG_JFFS2_FS=y
> +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
>
Can you explain why you're removing CONFIG_MTD_SPI_NOR_USE_4K_SECTORS?
Dinh
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig
2019-10-21 15:56 ` Dinh Nguyen
@ 2019-10-23 14:17 ` Ooi, Joyce
0 siblings, 0 replies; 3+ messages in thread
From: Ooi, Joyce @ 2019-10-23 14:17 UTC (permalink / raw)
To: Dinh Nguyen, Vladimir Murzin, Catalin Marinas, Will Deacon
Cc: Shawn Guo, Olof Johansson, Maxime Ripard, Bjorn Andersson,
Arnd Bergmann, Jagan Teki, Anson Huang, Leonard Crestez,
Marcin Juszkiewicz, linux-arm-kernel, linux-kernel, Ong,
Hean Loong, See, Chin Liang, Tan, Ley Foon
> -----Original Message-----
> From: Dinh Nguyen <dinguyen@kernel.org>
> Sent: Monday, October 21, 2019 11:57 PM
> To: Ooi, Joyce <joyce.ooi@intel.com>; Vladimir Murzin
> <vladimir.murzin@arm.com>; Catalin Marinas <catalin.marinas@arm.com>; Will
> Deacon <will@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>; Olof Johansson <olof@lixom.net>;
> Maxime Ripard <mripard@kernel.org>; Bjorn Andersson
> <bjorn.andersson@linaro.org>; Arnd Bergmann <arnd@arndb.de>; Jagan Teki
> <jagan@amarulasolutions.com>; Anson Huang <Anson.Huang@nxp.com>;
> Leonard Crestez <leonard.crestez@nxp.com>; Marcin Juszkiewicz
> <marcin.juszkiewicz@linaro.org>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Ong, Hean Loong <hean.loong.ong@intel.com>; See,
> Chin Liang <chin.liang.see@intel.com>; Tan, Ley Foon
> <ley.foon.tan@intel.com>
> Subject: Re: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig
>
>
>
> On 10/17/19 1:28 AM, Ooi, Joyce wrote:
> > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force
> > in the default defconfig
> >
> > Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
> > ---
> > v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax
> > ---
> > arch/arm64/configs/defconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig index c9adae4..6080c6e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y #
> CONFIG_DEBUG_PREEMPT is
> > not set # CONFIG_FTRACE is not set CONFIG_MEMTEST=y
> > +CONFIG_JFFS2_FS=y
> > +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
> >
>
> Can you explain why you're removing
> CONFIG_MTD_SPI_NOR_USE_4K_SECTORS?
Removing CONFIG_MTD_SPI_NOR_USE_4K_SECTORS will fix errors like this:
[ 1.905772] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x00000f90: 0x00bf instead
[ 1.915275] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x00000f94: 0x6abb instead
I'll add this explanation in the commit message.
>
> Dinh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-23 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 6:28 [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig Ooi, Joyce
2019-10-21 15:56 ` Dinh Nguyen
2019-10-23 14:17 ` Ooi, Joyce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).