linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Bin Liu <b-liu@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	od@zcrc.me, Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH v2 1/6] usb: musb: dma: Correct parameter passed to IRQ handler
Date: Wed, 30 Oct 2019 12:23:02 +0100	[thread overview]
Message-ID: <1572434582.3.0@crapouillou.net> (raw)
In-Reply-To: <20191025114710.13222-1-paul@crapouillou.net>

Hi,


Le ven., oct. 25, 2019 at 13:47, Paul Cercueil <paul@crapouillou.net> a 
écrit :
> The IRQ handler was passed a pointer to a struct dma_controller, but 
> the
> argument was then casted to a pointer to a struct musb_dma_controller.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
> ---
> 
> Notes:
>     v2: Rebase on 4.5-rc4

Typo in the changelog of this patch and the following ones: it was 
rebased on 5.4-rc4, obviously.


> 
>  drivers/usb/musb/musbhsdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/musbhsdma.c 
> b/drivers/usb/musb/musbhsdma.c
> index 5fc6825745f2..2d3751d885b4 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -425,7 +425,7 @@ struct dma_controller 
> *musbhs_dma_controller_create(struct musb *musb,
>  	controller->controller.channel_abort = dma_channel_abort;
> 
>  	if (request_irq(irq, dma_controller_irq, 0,
> -			dev_name(musb->controller), &controller->controller)) {
> +			dev_name(musb->controller), controller)) {
>  		dev_err(dev, "request_irq %d failed!\n", irq);
>  		musb_dma_controller_destroy(&controller->controller);
> 
> --
> 2.23.0
> 



      parent reply	other threads:[~2019-10-30 11:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 11:47 [PATCH v2 1/6] usb: musb: dma: Correct parameter passed to IRQ handler Paul Cercueil
2019-10-25 11:47 ` [PATCH v2 2/6] usb: musb: dma: Add support for shared IRQ Paul Cercueil
2019-10-25 11:47 ` [PATCH v2 3/6] usb: musb: jz4740: Add support for DMA Paul Cercueil
2019-10-25 11:47 ` [PATCH v2 4/6] usb: musb: jz4740: Drop dependency on NOP_USB_XCEIV Paul Cercueil
2019-10-25 11:47 ` [PATCH v2 5/6] usb: musb: jz4740: Silence error if code is -EPROBE_DEFER Paul Cercueil
2019-10-25 11:47 ` [PATCH v2 6/6] usb: musb: jz4740: Code cleanup Paul Cercueil
2019-10-30 11:23 ` Paul Cercueil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1572434582.3.0@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=b-liu@ti.com \
    --cc=contact@artur-rojek.eu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=od@zcrc.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).