From: Qian Cai <cai@lca.pw>
To: Jason Gunthorpe <jgg@mellanox.com>,
Ralph Campbell <rcampbell@nvidia.com>
Cc: Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] mm/hmm/test: add self tests for HMM
Date: Wed, 30 Oct 2019 14:34:39 -0400 [thread overview]
Message-ID: <1572460479.5937.102.camel@lca.pw> (raw)
In-Reply-To: <20191029175837.GS22766@mellanox.com>
On Tue, 2019-10-29 at 17:58 +0000, Jason Gunthorpe wrote:
> On Wed, Oct 23, 2019 at 12:55:15PM -0700, Ralph Campbell wrote:
> > Add self tests for HMM.
> >
> > Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> > ---
> > MAINTAINERS | 3 +
> > drivers/char/Kconfig | 11 +
> > drivers/char/Makefile | 1 +
> > drivers/char/hmm_dmirror.c | 1566 ++++++++++++++++++++++++
> > include/Kbuild | 1 +
> > include/uapi/linux/hmm_dmirror.h | 74 ++
> > tools/testing/selftests/vm/.gitignore | 1 +
> > tools/testing/selftests/vm/Makefile | 3 +
> > tools/testing/selftests/vm/config | 3 +
> > tools/testing/selftests/vm/hmm-tests.c | 1311 ++++++++++++++++++++
> > tools/testing/selftests/vm/run_vmtests | 16 +
> > tools/testing/selftests/vm/test_hmm.sh | 97 ++
> > 12 files changed, 3087 insertions(+)
> > create mode 100644 drivers/char/hmm_dmirror.c
> > create mode 100644 include/uapi/linux/hmm_dmirror.h
> > create mode 100644 tools/testing/selftests/vm/hmm-tests.c
> > create mode 100755 tools/testing/selftests/vm/test_hmm.sh
>
> This is really big, it would be nice to get a comment from the various
> kernel testing folks if this approach makes sense with the test
> frameworks. Do we have other drivers that are only intended to be used
> by selftests?
>
> Frankly, I'm not super excited about the idea of a 'test driver', it
> seems more logical for testing to have some way for a test harness to
> call hmm_range_fault() under various conditions and check the results?
Not a big fan of those selftests either. Could it be saner to use the new KUnit
framework for those instead?
prev parent reply other threads:[~2019-10-30 18:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 19:55 [PATCH v3 0/3] HMM tests and minor fixes Ralph Campbell
2019-10-23 19:55 ` [PATCH v3 1/3] mm/hmm: make full use of walk_page_range() Ralph Campbell
2019-10-29 17:40 ` Jason Gunthorpe
2019-10-23 19:55 ` [PATCH v3 2/3] mm/hmm: allow snapshot of the special zero page Ralph Campbell
2019-10-23 20:27 ` Jerome Glisse
2019-10-24 9:27 ` David Hildenbrand
2019-10-29 17:27 ` Jason Gunthorpe
2019-10-23 19:55 ` [PATCH v3 3/3] mm/hmm/test: add self tests for HMM Ralph Campbell
2019-10-23 20:28 ` Jerome Glisse
2019-10-23 21:55 ` Ralph Campbell
2019-10-29 17:58 ` Jason Gunthorpe
2019-10-29 21:16 ` Ralph Campbell
2019-10-29 23:12 ` Jason Gunthorpe
2019-10-31 0:14 ` Ralph Campbell
2019-10-31 12:42 ` Jason Gunthorpe
2019-10-31 17:28 ` Ralph Campbell
2019-10-31 17:34 ` Jason Gunthorpe
2019-10-31 17:48 ` Ralph Campbell
2019-10-30 18:34 ` Qian Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572460479.5937.102.camel@lca.pw \
--to=cai@lca.pw \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).