* [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and phy nodes
@ 2019-11-06 15:52 Ioana Ciornei
2019-11-06 15:52 ` [PATCH 1/2] arm64: dts: lx2160a: add emdio1 node Ioana Ciornei
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ioana Ciornei @ 2019-11-06 15:52 UTC (permalink / raw)
To: shawnguo; +Cc: devicetree, linux-kernel, Ioana Ciornei
This patch set adds the External MDIO1 node and the two
RGMII PHYs connected to it.
Ioana Ciornei (2):
arm64: dts: lx2160a: add emdio1 node
arm64: dts: lx2160a: add RGMII phy nodes
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 27 +++++++++++++++++++++++
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 11 +++++++++
2 files changed, 38 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: dts: lx2160a: add emdio1 node
2019-11-06 15:52 [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and phy nodes Ioana Ciornei
@ 2019-11-06 15:52 ` Ioana Ciornei
2019-12-04 6:58 ` Shawn Guo
2019-11-06 15:52 ` [PATCH 2/2] arm64: dts: lx2160a: add RGMII phy nodes Ioana Ciornei
2019-11-21 12:58 ` [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and " Ioana Ciornei
2 siblings, 1 reply; 6+ messages in thread
From: Ioana Ciornei @ 2019-11-06 15:52 UTC (permalink / raw)
To: shawnguo; +Cc: devicetree, linux-kernel, Ioana Ciornei
Add the External MDIO1 device node found in the WRIOP global memory
region. This is needed for management of external PHYs.
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index 80268c6ed5fb..8b87a0122b54 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -478,6 +478,17 @@
little-endian;
};
+ /* WRIOP0: 0x8b8_0000, E-MDIO1: 0x1_6000 */
+ emdio1: mdio@8b96000 {
+ compatible = "fsl,fman-memac-mdio";
+ reg = <0x0 0x8b96000 0x0 0x1000>;
+ interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ little-endian;
+ status = "disabled";
+ };
+
i2c0: i2c@2000000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: lx2160a: add RGMII phy nodes
2019-11-06 15:52 [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and phy nodes Ioana Ciornei
2019-11-06 15:52 ` [PATCH 1/2] arm64: dts: lx2160a: add emdio1 node Ioana Ciornei
@ 2019-11-06 15:52 ` Ioana Ciornei
2019-12-04 7:01 ` Shawn Guo
2019-11-21 12:58 ` [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and " Ioana Ciornei
2 siblings, 1 reply; 6+ messages in thread
From: Ioana Ciornei @ 2019-11-06 15:52 UTC (permalink / raw)
To: shawnguo; +Cc: devicetree, linux-kernel, Ioana Ciornei
Annotate the EMDIO1 node and describe the 2 AR8035 RGMII PHYs.
Also, add phy-handles for dpmac17 and dpmac18 to its associated PHY.
The MAC is not capable to add the needed RGMII delays, thus the
"rgmii-id" phy-connection-type is used.
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 27 +++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
index c2817b784232..1e2a7c4031fd 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
@@ -35,6 +35,33 @@
status = "okay";
};
+&dpmac17 {
+ phy-handle = <&rgmii_phy1>;
+ phy-connection-type = "rgmii-id";
+};
+
+&dpmac18 {
+ phy-handle = <&rgmii_phy2>;
+ phy-connection-type = "rgmii-id";
+};
+
+&emdio1 {
+ status = "okay";
+
+ rgmii_phy1: ethernet-phy@1 {
+ /* AR8035 PHY */
+ compatible = "ethernet-phy-id004d.d072";
+ reg = <0x1>;
+ eee-broken-1000t;
+ };
+ rgmii_phy2: ethernet-phy@2 {
+ /* AR8035 PHY */
+ compatible = "ethernet-phy-id004d.d072";
+ reg = <0x2>;
+ eee-broken-1000t;
+ };
+};
+
&esdhc0 {
sd-uhs-sdr104;
sd-uhs-sdr50;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and phy nodes
2019-11-06 15:52 [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and phy nodes Ioana Ciornei
2019-11-06 15:52 ` [PATCH 1/2] arm64: dts: lx2160a: add emdio1 node Ioana Ciornei
2019-11-06 15:52 ` [PATCH 2/2] arm64: dts: lx2160a: add RGMII phy nodes Ioana Ciornei
@ 2019-11-21 12:58 ` Ioana Ciornei
2 siblings, 0 replies; 6+ messages in thread
From: Ioana Ciornei @ 2019-11-21 12:58 UTC (permalink / raw)
To: Ioana Ciornei, shawnguo; +Cc: devicetree, linux-kernel
> Subject: [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and phy nodes
>
> This patch set adds the External MDIO1 node and the two RGMII PHYs
> connected to it.
>
> Ioana Ciornei (2):
> arm64: dts: lx2160a: add emdio1 node
> arm64: dts: lx2160a: add RGMII phy nodes
>
> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 27
> +++++++++++++++++++++++
> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 11 +++++++++
> 2 files changed, 38 insertions(+)
>
Hi Shawn,
Could you please take a look at this patch set?
Thanks,
Ioana
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add emdio1 node
2019-11-06 15:52 ` [PATCH 1/2] arm64: dts: lx2160a: add emdio1 node Ioana Ciornei
@ 2019-12-04 6:58 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-12-04 6:58 UTC (permalink / raw)
To: Ioana Ciornei; +Cc: devicetree, linux-kernel
On Wed, Nov 06, 2019 at 05:52:15PM +0200, Ioana Ciornei wrote:
> Add the External MDIO1 device node found in the WRIOP global memory
> region. This is needed for management of external PHYs.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 80268c6ed5fb..8b87a0122b54 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -478,6 +478,17 @@
> little-endian;
> };
>
> + /* WRIOP0: 0x8b8_0000, E-MDIO1: 0x1_6000 */
> + emdio1: mdio@8b96000 {
Please find the place for the node in order of unit-address.
Shawn
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8b96000 0x0 0x1000>;
> + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + little-endian;
> + status = "disabled";
> + };
> +
> i2c0: i2c@2000000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: lx2160a: add RGMII phy nodes
2019-11-06 15:52 ` [PATCH 2/2] arm64: dts: lx2160a: add RGMII phy nodes Ioana Ciornei
@ 2019-12-04 7:01 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-12-04 7:01 UTC (permalink / raw)
To: Ioana Ciornei; +Cc: devicetree, linux-kernel
On Wed, Nov 06, 2019 at 05:52:16PM +0200, Ioana Ciornei wrote:
> Annotate the EMDIO1 node and describe the 2 AR8035 RGMII PHYs.
> Also, add phy-handles for dpmac17 and dpmac18 to its associated PHY.
> The MAC is not capable to add the needed RGMII delays, thus the
> "rgmii-id" phy-connection-type is used.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 27 +++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> index c2817b784232..1e2a7c4031fd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -35,6 +35,33 @@
> status = "okay";
> };
>
> +&dpmac17 {
> + phy-handle = <&rgmii_phy1>;
> + phy-connection-type = "rgmii-id";
> +};
> +
> +&dpmac18 {
> + phy-handle = <&rgmii_phy2>;
> + phy-connection-type = "rgmii-id";
> +};
> +
> +&emdio1 {
> + status = "okay";
> +
> + rgmii_phy1: ethernet-phy@1 {
> + /* AR8035 PHY */
> + compatible = "ethernet-phy-id004d.d072";
> + reg = <0x1>;
> + eee-broken-1000t;
> + };
Please have a newline between nodes.
Shawn
> + rgmii_phy2: ethernet-phy@2 {
> + /* AR8035 PHY */
> + compatible = "ethernet-phy-id004d.d072";
> + reg = <0x2>;
> + eee-broken-1000t;
> + };
> +};
> +
> &esdhc0 {
> sd-uhs-sdr104;
> sd-uhs-sdr50;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-04 7:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 15:52 [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and phy nodes Ioana Ciornei
2019-11-06 15:52 ` [PATCH 1/2] arm64: dts: lx2160a: add emdio1 node Ioana Ciornei
2019-12-04 6:58 ` Shawn Guo
2019-11-06 15:52 ` [PATCH 2/2] arm64: dts: lx2160a: add RGMII phy nodes Ioana Ciornei
2019-12-04 7:01 ` Shawn Guo
2019-11-21 12:58 ` [PATCH 0/2] arm64: dts: lx2160a: add EMDIO1 and " Ioana Ciornei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).