From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13793C5DF60 for ; Thu, 7 Nov 2019 12:19:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1986214D8 for ; Thu, 7 Nov 2019 12:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388569AbfKGMTH (ORCPT ); Thu, 7 Nov 2019 07:19:07 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:5742 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388319AbfKGMTF (ORCPT ); Thu, 7 Nov 2019 07:19:05 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 8DCB73B4000C330688B5; Thu, 7 Nov 2019 20:19:02 +0800 (CST) Received: from localhost.localdomain (10.90.53.225) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Thu, 7 Nov 2019 20:18:55 +0800 From: Chen Wandun To: , , , , , CC: Subject: [PATCH] net: dsa: mv88e6xxx: global2: Fix gcc compile error Date: Thu, 7 Nov 2019 20:26:07 +0800 Message-ID: <1573129568-94008-1-git-send-email-chenwandun@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.90.53.225] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit c5f299d59261 ("net: dsa: mv88e6xxx: global1_atu: Add helper for get next"), it add a parameter in mv88e6xxx_g2_atu_stats_get only when CONFIG_NET_DSA_MV88E6XXX_GLOBAL2 enabled, it also should make the same change when CONFIG_NET_DSA_MV88E6XXX_GLOBAL2 disabled. drivers/net/dsa/mv88e6xxx/chip.c: In function mv88e6xxx_devlink_atu_bin_get: drivers/net/dsa/mv88e6xxx/chip.c:2752:8: error: too many arguments to function mv88e6xxx_g2_atu_stats_get err = mv88e6xxx_g2_atu_stats_get(chip, &occupancy); ^~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/dsa/mv88e6xxx/chip.c:36:0: drivers/net/dsa/mv88e6xxx/global2.h:535:19: note: declared here static inline int mv88e6xxx_g2_atu_stats_get(struct mv88e6xxx_chip *chip) ^~~~~~~~~~~~~~~~~~~~~~~~~~ make[4]: *** [drivers/net/dsa/mv88e6xxx/chip.o] Error 1 Fixes: c5f299d59261 ("net: dsa: mv88e6xxx: global1_atu: Add helper for get next") Reported-by: Hulk Robot Signed-off-by: Chen Wandun --- drivers/net/dsa/mv88e6xxx/global2.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/global2.h b/drivers/net/dsa/mv88e6xxx/global2.h index d80ad20..1f42ee6 100644 --- a/drivers/net/dsa/mv88e6xxx/global2.h +++ b/drivers/net/dsa/mv88e6xxx/global2.h @@ -532,7 +532,8 @@ static inline int mv88e6xxx_g2_atu_stats_set(struct mv88e6xxx_chip *chip, return -EOPNOTSUPP; } -static inline int mv88e6xxx_g2_atu_stats_get(struct mv88e6xxx_chip *chip) +static inline int mv88e6xxx_g2_atu_stats_get(struct mv88e6xxx_chip *chip, + u16 *stats) { return -EOPNOTSUPP; } -- 2.7.4