From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 11/11] arm64: dts: mt2712: use non-empty ranges for usb-phy
Date: Wed, 13 Nov 2019 11:18:22 +0800 [thread overview]
Message-ID: <1573615102.7173.9.camel@mhfsdcap03> (raw)
In-Reply-To: <c23531cd-432d-1857-1e99-48d87956338e@gmail.com>
On Tue, 2019-11-12 at 14:12 +0100, Matthias Brugger wrote:
>
> On 12/11/2019 09:36, Chunfeng Yun wrote:
> > Use non-empty ranges for usb-phy to make the layout of
> > its registers clearer;
> > Replace deprecated compatible by generic
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v3~v4: no changes
> >
> > v2: use generic compatible
> > ---
> > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 42 ++++++++++++-----------
> > 1 file changed, 22 insertions(+), 20 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> > index 43307bad3f0d..e24f2f2f6004 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> > @@ -697,30 +697,31 @@
> > };
> >
> > u3phy0: usb-phy@11290000 {
> > - compatible = "mediatek,mt2712-u3phy";
> > - #address-cells = <2>;
> > - #size-cells = <2>;
> > - ranges;
> > + compatible = "mediatek,mt2712-tphy",
> > + "mediatek,generic-tphy-v2";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
>
> At a first glance I don't understand why you change address and size cells.
> Commit message doesn't explain it and AFAIS it's not part of the binding changes.
When Ryder sent DTS patch for mt7629, Rob suggested to use 1 cell,
non-empty ranges and provide the offset for v2 tphy which hasn't shared
registers between sub-phys, it'll make layout more clear.
See: https://patchwork.kernel.org/patch/10850925/
>
> Can you explain why we need that, and update the commit message accordingly?
Just want to take it as an example when support other platforms.
>
> Regrads,
> Matthias
>
> > + ranges = <0 0 0x11290000 0x9000>;
> > status = "okay";
> >
> > - u2port0: usb-phy@11290000 {
> > - reg = <0 0x11290000 0 0x700>;
> > + u2port0: usb-phy@0 {
> > + reg = <0x0 0x700>;
> > clocks = <&clk26m>;
> > clock-names = "ref";
> > #phy-cells = <1>;
> > status = "okay";
> > };
> >
> > - u2port1: usb-phy@11298000 {
> > - reg = <0 0x11298000 0 0x700>;
> > + u2port1: usb-phy@8000 {
> > + reg = <0x8000 0x700>;
> > clocks = <&clk26m>;
> > clock-names = "ref";
> > #phy-cells = <1>;
> > status = "okay";
> > };
> >
> > - u3port0: usb-phy@11298700 {
> > - reg = <0 0x11298700 0 0x900>;
> > + u3port0: usb-phy@8700 {
> > + reg = <0x8700 0x900>;
> > clocks = <&clk26m>;
> > clock-names = "ref";
> > #phy-cells = <1>;
> > @@ -760,30 +761,31 @@
> > };
> >
> > u3phy1: usb-phy@112e0000 {
> > - compatible = "mediatek,mt2712-u3phy";
> > - #address-cells = <2>;
> > - #size-cells = <2>;
> > - ranges;
> > + compatible = "mediatek,mt2712-tphy",
> > + "mediatek,generic-tphy-v2";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0 0 0x112e0000 0x9000>;
> > status = "okay";
> >
> > - u2port2: usb-phy@112e0000 {
> > - reg = <0 0x112e0000 0 0x700>;
> > + u2port2: usb-phy@0 {
> > + reg = <0x0 0x700>;
> > clocks = <&clk26m>;
> > clock-names = "ref";
> > #phy-cells = <1>;
> > status = "okay";
> > };
> >
> > - u2port3: usb-phy@112e8000 {
> > - reg = <0 0x112e8000 0 0x700>;
> > + u2port3: usb-phy@8000 {
> > + reg = <0x8000 0x700>;
> > clocks = <&clk26m>;
> > clock-names = "ref";
> > #phy-cells = <1>;
> > status = "okay";
> > };
> >
> > - u3port1: usb-phy@112e8700 {
> > - reg = <0 0x112e8700 0 0x900>;
> > + u3port1: usb-phy@8700 {
> > + reg = <0x8700 0x900>;
> > clocks = <&clk26m>;
> > clock-names = "ref";
> > #phy-cells = <1>;
> >
next prev parent reply other threads:[~2019-11-13 3:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 8:36 [PATCH v4 01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 02/11] dt-bindings: phy-mtk-tphy: make the ref clock optional Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 03/11] dt-bindings: phy-mtk-tphy: remove unused u3phya_ref clock Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 04/11] dt-bindings: phy-mtk-tphy: add a new reference clock Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 05/11] dt-bindings: phy-mtk-tphy: add the properties about address mapping Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 06/11] phy: phy-mtk-tphy: add a property for disconnect threshold Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 07/11] phy: phy-mtk-tphy: add a property for internal resistance Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 08/11] phy: phy-mtk-tphy: make the ref clock optional Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 09/11] phy: phy-mtk-tphy: remove unused u3phya_ref clock Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 10/11] phy: phy-mtk-tphy: add a new reference clock Chunfeng Yun
2019-11-12 8:36 ` [PATCH v4 11/11] arm64: dts: mt2712: use non-empty ranges for usb-phy Chunfeng Yun
2019-11-12 13:12 ` Matthias Brugger
2019-11-13 3:18 ` Chunfeng Yun [this message]
2019-11-18 16:50 ` [PATCH v4 01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573615102.7173.9.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).