From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78051C432C3 for ; Fri, 15 Nov 2019 06:10:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EACA2073C for ; Fri, 15 Nov 2019 06:10:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="om5BrhE/"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="FHU8ABF9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727351AbfKOGKP (ORCPT ); Fri, 15 Nov 2019 01:10:15 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:38246 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbfKOGKO (ORCPT ); Fri, 15 Nov 2019 01:10:14 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 30C06611B9; Fri, 15 Nov 2019 06:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573798213; bh=MLgJGcO7+btTvbTNbm66rpBoYADk/G6YV6iUYpQTzBQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=om5BrhE/5Y2j+JDUCxIGUrbTWZGu//zKUhK84hvlhfHrOB9EHsnwvvDAxOSdD7Rkv dQDuzh8vUNte1TecI9jQyatIIsi59SXqBRbmq/3ktBBj44SkRDVxqqBOoZcZJ70WES XbLvNnIxGBt8HSkqD3ypp5sQj99l0KFjwyg6H0QU= Received: from pacamara-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cang@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 91F5F611B4; Fri, 15 Nov 2019 06:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573798205; bh=MLgJGcO7+btTvbTNbm66rpBoYADk/G6YV6iUYpQTzBQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FHU8ABF9fFEzMOUESLw2O2sY6+rgdS528mWFt+PZ5L2QwFaxnKWobLVdg9jG5lh1g jo+poSuE9KX+P9KIBykgSiVdNdnEr0vkZ0W8OfMCtpOGvdhgO5GfJa09PBmaxDR0vr slu0T7qedQIbNvZT06AwC6+9ugZJDrlR/D1tn3bc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 91F5F611B4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cang@codeaurora.org From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Tomas Winkler , Venkat Gopalakrishnan , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 4/7] scsi: ufs: Fix register dump caused sleep in atomic context Date: Thu, 14 Nov 2019 22:09:27 -0800 Message-Id: <1573798172-20534-5-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1573798172-20534-1-git-send-email-cang@codeaurora.org> References: <1573798172-20534-1-git-send-email-cang@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ufshcd_print_host_regs() can be called by interrupt handler, but it may sleep due to ufshcd_dump_regs() allocates the dump buffer memory with flag GFP_KERNEL. Fix it by changing GFP_KERNEL to GFP_ATMOIC. Signed-off-by: Can Guo Reviewed-by: Bean Huo --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 9bc2cad..e70ec47 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -117,7 +117,7 @@ int ufshcd_dump_regs(struct ufs_hba *hba, size_t offset, size_t len, if (offset % 4 != 0 || len % 4 != 0) /* keep readl happy */ return -EINVAL; - regs = kzalloc(len, GFP_KERNEL); + regs = kzalloc(len, GFP_ATOMIC); if (!regs) return -ENOMEM; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project