From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755022Ab2HWGfu (ORCPT ); Thu, 23 Aug 2012 02:35:50 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:14263 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133Ab2HWGfm convert rfc822-to-8bit (ORCPT ); Thu, 23 Aug 2012 02:35:42 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6812"; a="226181637" X-IronPort-AV: E=Sophos;i="4.80,298,1344236400"; d="scan'208";a="374055092" From: "Huang, Xiong" To: David Miller , "Ren, Cloud" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , "Rodriguez, Luis" Subject: RE: [PATCH v2] net: add new QCA alx ethernet driver Thread-Topic: [PATCH v2] net: add new QCA alx ethernet driver Thread-Index: AQHNfq/QcigpFEkeAUuvSgE/Sf2tgZdnYDEA//+NnwA= Date: Thu, 23 Aug 2012 06:35:40 +0000 Message-ID: <157393863283F442885425D2C45428562A4F5169@nasanexd02f.na.qualcomm.com> References: <1345480949-14800-1-git-send-email-cjren@qca.qualcomm.com> <20120822.225700.714020017287504609.davem@davemloft.net> In-Reply-To: <20120822.225700.714020017287504609.davem@davemloft.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.48.1] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This is why we require that portable, sane, interfaces are added to ethtool for > driver diagnostics. That way users can perform a task in the same way > regardless of what hardware and driver are underneath. I quite agree you on using ethtool to implement it. we did consider it. But ethtool has some limitation, for example, the NIC has built-in OTP (TWSI interface) And Flash (External SPI interface), their properties are quite different with EEPROM which Ethtool supports. To support such memory (OTP/Flash), we need additional input parameters. Same situation exists in diagnostic utility. Ethtool only provide two options : offline & online That's too gross to locate which part/module of the chip is malfunction. we also need more options to detect it. that's why we finally selected a custom debugfs interface. Thanks Xiong