From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: kernel-janitors@vger.kernel.org,
Gilles Muller <Gilles.Muller@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4 v2] coccinelle: platform_get_irq: simplify context case
Date: Tue, 19 Nov 2019 22:08:22 +0100 [thread overview]
Message-ID: <1574197705-31132-2-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1574197705-31132-1-git-send-email-Julia.Lawall@lip6.fr>
Simplify to just report on the first dev_err, whereever it occurs.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: no change
scripts/coccinelle/api/platform_get_irq.cocci | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/scripts/coccinelle/api/platform_get_irq.cocci b/scripts/coccinelle/api/platform_get_irq.cocci
index 06b6a95..c6ac755 100644
--- a/scripts/coccinelle/api/platform_get_irq.cocci
+++ b/scripts/coccinelle/api/platform_get_irq.cocci
@@ -23,16 +23,9 @@ platform_get_irq_byname
if ( \( ret < 0 \| ret <= 0 \) )
{
-(
-if (ret != -EPROBE_DEFER)
-{ ...
-*dev_err(...);
-... }
-|
...
*dev_err(...);
-)
-...
+... when any
}
@depends on patch@
next prev parent reply other threads:[~2019-11-19 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 21:08 [PATCH 0/4 v2] improve platform_get_irq.cocci Julia Lawall
2019-11-19 21:08 ` Julia Lawall [this message]
2019-11-20 14:33 ` [PATCH 1/4 v2] coccinelle: platform_get_irq: simplify context case Markus Elfring
2019-11-19 21:08 ` [PATCH 2/4 v2] coccinelle: platform_get_irq: handle 2-statement branches Julia Lawall
2019-11-19 21:08 ` [PATCH 3/4 v2] coccinelle: platform_get_irq: allow multiple dev_errs Julia Lawall
2019-11-19 21:08 ` [PATCH 4/4 v2] coccinelle: platform_get_irq: drop unneeded metavariable Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574197705-31132-2-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).