linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
	Eric Snowberg <eric.snowberg@oracle.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	keyrings@vger.kernel.org
Subject: Re: [PATCH v8 2/5] IMA: Define an IMA hook to measure keys
Date: Wed, 20 Nov 2019 20:22:10 -0500	[thread overview]
Message-ID: <1574299330.4793.158.camel@linux.ibm.com> (raw)
In-Reply-To: <98eeec95-cc19-2900-b96e-eadaac1b4a68@linux.microsoft.com>

On Wed, 2019-11-20 at 15:40 -0800, Lakshmi Ramasubramanian wrote:
> On 11/20/2019 3:28 PM, Eric Snowberg wrote:
> Hi Eric,
> 
> > 
> > I’m interested in using this patch series, however I get the following on every boot:
> 
> > [    1.222749] Call Trace:
> > [    1.223344]  ? crypto_destroy_tfm+0x5f/0xb0
> > [    1.224315]  ima_get_action+0x2c/0x30
> > [    1.225148]  process_buffer_measurement+0x1da/0x230
> > [    1.226306]  ima_post_key_create_or_update+0x3b/0x40
> 
> This is happening because IMA is not yet initialized when the IMA hook 
> is called.
> 
> I had the following check in process_buffer_measurement() as part of my 
> patch, but removed it since it is being upstreamed separately (by Mimi)
> 
>   if (!ima_policy_flag)
>   	return;

Did you post it as a separate patch?  I can't seem to find it.

Mimi

> 
> Until this change is in, please add the above line locally on entry to 
> process_buffer_measurement() to get around the issue.
> 
> thanks,
>   -lakshmi


  reply	other threads:[~2019-11-21  1:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 22:38 [PATCH v8 0/5] KEYS: Measure keys when they are created or updated Lakshmi Ramasubramanian
2019-11-18 22:38 ` [PATCH v8 1/5] IMA: Add KEY_CHECK func to measure keys Lakshmi Ramasubramanian
2019-11-18 22:38 ` [PATCH v8 2/5] IMA: Define an IMA hook " Lakshmi Ramasubramanian
2019-11-20 23:28   ` Eric Snowberg
2019-11-20 23:40     ` Lakshmi Ramasubramanian
2019-11-21  1:22       ` Mimi Zohar [this message]
2019-11-21  1:32         ` Lakshmi Ramasubramanian
2019-11-21 17:16         ` Lakshmi Ramasubramanian
2019-11-18 22:38 ` [PATCH v8 3/5] KEYS: Call the " Lakshmi Ramasubramanian
2019-11-19  1:18   ` Eric Snowberg
2019-11-19  1:58     ` Lakshmi Ramasubramanian
2019-11-18 22:38 ` [PATCH v8 4/5] IMA: Add support to limit measuring keys Lakshmi Ramasubramanian
2019-11-20 23:19   ` Mimi Zohar
2019-11-21  0:03     ` Lakshmi Ramasubramanian
2019-11-21  0:53       ` Mimi Zohar
2019-11-18 22:38 ` [PATCH v8 5/5] IMA: Read keyrings= option from the IMA policy Lakshmi Ramasubramanian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1574299330.4793.158.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=eric.snowberg@oracle.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nramas@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).