From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 481C7C432C0 for ; Fri, 22 Nov 2019 19:17:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20E392071F for ; Fri, 22 Nov 2019 19:17:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727127AbfKVTRW (ORCPT ); Fri, 22 Nov 2019 14:17:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:51734 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726698AbfKVTRV (ORCPT ); Fri, 22 Nov 2019 14:17:21 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AE6AAB275; Fri, 22 Nov 2019 19:17:19 +0000 (UTC) Message-ID: <1574449256.2659.2.camel@suse.com> Subject: Re: KASAN: use-after-free Read in si470x_int_in_callback (2) From: Oliver Neukum To: Alan Stern , syzbot Cc: andreyknvl@google.com, hverkuil@xs4all.nl, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, mchehab@kernel.org, syzkaller-bugs@googlegroups.com Date: Fri, 22 Nov 2019 20:00:56 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 22.11.2019, 10:35 -0500 schrieb Alan Stern: > On Fri, 22 Nov 2019, syzbot wrote: > > > Hello, > > > > syzbot has tested the proposed patch but the reproducer still triggered > > crash: > > INFO: rcu detected stall in dummy_timer > > > > radio-si470x 1-1:0.0: non-zero urb status (-71) > > radio-si470x 4-1:0.0: non-zero urb status (-71) > > radio-si470x 3-1:0.0: non-zero urb status (-71) > > Oliver: > > The reason for this stall is because the driver goes into a tight > resubmit loop when the interrupt URB completes with an unrecognized > error status. Instead, the driver should log an error message and > avoid resubmitting. Error recovery can be done at a higher level. > > In other words, change the > > goto resubmit; /* Maybe we can recover. */ > > line in the completion handler into a return. I thought so, too. That is why I poisoned the URB. Am I dense? Regards Oliver