From: Tom Zanussi <zanussi@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sven Schnelle <svens@stackframe.org>,
linux-trace-devel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: ftrace histogram sorting broken on BE architecures
Date: Wed, 11 Dec 2019 13:26:03 -0600 [thread overview]
Message-ID: <1576092363.2833.20.camel@kernel.org> (raw)
In-Reply-To: <20191211120051.711582ee@gandalf.local.home>
Hi Steve,
On Wed, 2019-12-11 at 12:00 -0500, Steven Rostedt wrote:
> On Wed, 11 Dec 2019 10:37:18 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > > Tom,
> > >
> > > Correct me if I'm wrong, from what I can tell, all sums and keys
> > > are
> > > u64 unless they are a string. Thus, I believe this patch should
> > > not
> > > have any issues.
> >
> > The sums are u64, but the keys may not be. I'll take a look and
> > see,
>
> Are they? I see in create_key_field:
>
> key_size = ALIGN(key_size, sizeof(u64));
>
> Which to me seems that we'll have nothing smaller than sizeof(u64).
>
Yeah, that makes them effectively u64 in this case, so I'd agree.
Tom
next prev parent reply other threads:[~2019-12-11 19:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191211123316.GD12147@stackframe.org>
2019-12-11 15:35 ` ftrace histogram sorting broken on BE architecures Steven Rostedt
2019-12-11 16:09 ` Steven Rostedt
2019-12-11 16:37 ` Tom Zanussi
2019-12-11 17:00 ` Steven Rostedt
2019-12-11 19:26 ` Tom Zanussi [this message]
2019-12-12 18:07 ` Steven Rostedt
2019-12-12 19:15 ` Tom Zanussi
2019-12-11 18:14 ` Sven Schnelle
2019-12-12 19:17 ` Tom Zanussi
2019-12-16 15:47 ` David Laight
2019-12-16 16:05 ` Steven Rostedt
2019-12-16 17:06 ` David Laight
2019-12-16 18:29 ` Steven Rostedt
2019-12-17 10:05 ` David Laight
2019-12-18 15:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576092363.2833.20.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).