From: Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <wsd_upstream@mediatek.com>,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
Houlong Wei <houlong.wei@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 02/14] mailbox: cmdq: variablize address shift in platform
Date: Thu, 12 Dec 2019 09:03:13 +0800 [thread overview]
Message-ID: <1576112593.17653.1.camel@mtkswgap22> (raw)
In-Reply-To: <1575942906.12891.6.camel@mtksdaap41>
Hi CK,
Thanks for your comment.
On Tue, 2019-12-10 at 09:55 +0800, CK Hu wrote:
> Hi, Dennis:
>
> On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote:
> > Some gce hardware shift pc and end address in register to support
> > large dram addressing.
> > Implement gce address shift when write or read pc and end register.
> > And add shift bit in platform definition.
> >
> > Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
> > ---
> > drivers/mailbox/mtk-cmdq-mailbox.c | 57 ++++++++++++++++++------
> > drivers/soc/mediatek/mtk-cmdq-helper.c | 3 +-
> > include/linux/mailbox/mtk-cmdq-mailbox.h | 2 +
> > 3 files changed, 48 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index 9a6ce9f5a7db..d5536563fce1 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -76,8 +76,21 @@ struct cmdq {
> > struct cmdq_thread *thread;
> > struct clk *clock;
> > bool suspended;
> > + u8 shift_pa;
> > };
> >
> > +struct gce_plat {
> > + u32 thread_nr;
> > + u8 shift;
> > +};
> > +
> > +u8 cmdq_mbox_shift(struct mbox_chan *chan)
> > +{
> > + struct cmdq *cmdq = container_of(chan->mbox, struct cmdq, mbox);
> > +
> > + return cmdq->shift_pa;
> > +}
>
> EXPORT_SYMBOL(cmdq_mbox_shift);
>
will do
> > +
> > static int cmdq_thread_suspend(struct cmdq *cmdq, struct cmdq_thread *thread)
> > {
> > u32 status;
> > @@ -176,6 +189,7 @@ static void cmdq_task_remove_wfe(struct cmdq_task *task)
> > {
> > struct device *dev = task->cmdq->mbox.dev;
> > u64 *base = task->pkt->va_base;
> > + struct cmdq *cmdq = task->cmdq;
> > int i;
> >
> > dma_sync_single_for_cpu(dev, task->pa_base, task->pkt->cmd_buf_size,
> > @@ -183,7 +197,7 @@ static void cmdq_task_remove_wfe(struct cmdq_task *task)
> > for (i = 0; i < CMDQ_NUM_CMD(task->pkt); i++)
> > if (cmdq_command_is_wfe(base[i]))
> > base[i] = (u64)CMDQ_JUMP_BY_OFFSET << 32 |
> > - CMDQ_JUMP_PASS;
> > + CMDQ_JUMP_PASS >> cmdq->shift_pa;
>
> cmdq is only used here, so I would like
>
> CMDQ_JUMP_PASS >> task->cmdq->shift_pa;
>
ok, will fix
> > dma_sync_single_for_device(dev, task->pa_base, task->pkt->cmd_buf_size,
> > DMA_TO_DEVICE);
> > }
> > @@ -221,13 +235,15 @@ static void cmdq_task_handle_error(struct cmdq_task *task)
> > {
> > struct cmdq_thread *thread = task->thread;
> > struct cmdq_task *next_task;
> > + struct cmdq *cmdq = task->cmdq;
> >
> > dev_err(task->cmdq->mbox.dev, "task 0x%p error\n", task);
> > WARN_ON(cmdq_thread_suspend(task->cmdq, thread) < 0);
> > next_task = list_first_entry_or_null(&thread->task_busy_list,
> > struct cmdq_task, list_entry);
> > if (next_task)
> > - writel(next_task->pa_base, thread->base + CMDQ_THR_CURR_ADDR);
> > + writel(next_task->pa_base >> cmdq->shift_pa,
> > + thread->base + CMDQ_THR_CURR_ADDR);
> > cmdq_thread_resume(thread);
> > }
> >
> > @@ -257,7 +273,7 @@ static void cmdq_thread_irq_handler(struct cmdq *cmdq,
> > else
> > return;
> >
> > - curr_pa = readl(thread->base + CMDQ_THR_CURR_ADDR);
> > + curr_pa = readl(thread->base + CMDQ_THR_CURR_ADDR) << cmdq->shift_pa;
> >
> > list_for_each_entry_safe(task, tmp, &thread->task_busy_list,
> > list_entry) {
> > @@ -373,16 +389,20 @@ static int cmdq_mbox_send_data(struct mbox_chan *chan, void *data)
> > WARN_ON(clk_enable(cmdq->clock) < 0);
> > WARN_ON(cmdq_thread_reset(cmdq, thread) < 0);
> >
> > - writel(task->pa_base, thread->base + CMDQ_THR_CURR_ADDR);
> > - writel(task->pa_base + pkt->cmd_buf_size,
> > + writel(task->pa_base >> cmdq->shift_pa,
> > + thread->base + CMDQ_THR_CURR_ADDR);
> > + writel((task->pa_base + pkt->cmd_buf_size) >> cmdq->shift_pa,
> > thread->base + CMDQ_THR_END_ADDR);
> > +
> > writel(thread->priority, thread->base + CMDQ_THR_PRIORITY);
> > writel(CMDQ_THR_IRQ_EN, thread->base + CMDQ_THR_IRQ_ENABLE);
> > writel(CMDQ_THR_ENABLED, thread->base + CMDQ_THR_ENABLE_TASK);
> > } else {
> > WARN_ON(cmdq_thread_suspend(cmdq, thread) < 0);
> > - curr_pa = readl(thread->base + CMDQ_THR_CURR_ADDR);
> > - end_pa = readl(thread->base + CMDQ_THR_END_ADDR);
> > + curr_pa = readl(thread->base + CMDQ_THR_CURR_ADDR) <<
> > + cmdq->shift_pa;
> > + end_pa = readl(thread->base + CMDQ_THR_END_ADDR) <<
> > + cmdq->shift_pa;
> >
> > /*
> > * Atomic execution should remove the following wfe, i.e. only
> > @@ -395,7 +415,7 @@ static int cmdq_mbox_send_data(struct mbox_chan *chan, void *data)
> > cmdq_thread_wait_end(thread, end_pa);
> > WARN_ON(cmdq_thread_suspend(cmdq, thread) < 0);
> > /* set to this task directly */
> > - writel(task->pa_base,
> > + writel(task->pa_base >> cmdq->shift_pa,
> > thread->base + CMDQ_THR_CURR_ADDR);
> > } else {
> > cmdq_task_insert_into_thread(task);
> > @@ -407,14 +427,14 @@ static int cmdq_mbox_send_data(struct mbox_chan *chan, void *data)
> > if (curr_pa == end_pa - CMDQ_INST_SIZE ||
> > curr_pa == end_pa) {
> > /* set to this task directly */
> > - writel(task->pa_base,
> > + writel(task->pa_base >> cmdq->shift_pa,
> > thread->base + CMDQ_THR_CURR_ADDR);
> > } else {
> > cmdq_task_insert_into_thread(task);
> > smp_mb(); /* modify jump before enable thread */
> > }
> > }
> > - writel(task->pa_base + pkt->cmd_buf_size,
> > + writel((task->pa_base + pkt->cmd_buf_size) >> cmdq->shift_pa,
> > thread->base + CMDQ_THR_END_ADDR);
> > cmdq_thread_resume(thread);
> > }
> > @@ -461,6 +481,7 @@ static int cmdq_probe(struct platform_device *pdev)
> > struct resource *res;
> > struct cmdq *cmdq;
> > int err, i;
> > + struct gce_plat *plat_data;
> >
> > cmdq = devm_kzalloc(dev, sizeof(*cmdq), GFP_KERNEL);
> > if (!cmdq)
> > @@ -479,7 +500,14 @@ static int cmdq_probe(struct platform_device *pdev)
> > return -EINVAL;
> > }
> >
> > - cmdq->thread_nr = (u32)(unsigned long)of_device_get_match_data(dev);
> > + plat_data = (struct gce_plat *)of_device_get_match_data(dev);
> > + if (!plat_data) {
> > + dev_err(dev, "failed to get match data\n");
> > + return -EINVAL;
> > + }
> > +
> > + cmdq->thread_nr = plat_data->thread_nr;
> > + cmdq->shift_pa = plat_data->shift;
> > cmdq->irq_mask = GENMASK(cmdq->thread_nr - 1, 0);
> > err = devm_request_irq(dev, cmdq->irq, cmdq_irq_handler, IRQF_SHARED,
> > "mtk_cmdq", cmdq);
> > @@ -542,9 +570,12 @@ static const struct dev_pm_ops cmdq_pm_ops = {
> > .resume = cmdq_resume,
> > };
> >
> > +static const struct gce_plat gce_plat_v2 = {.thread_nr = 16, .shift = 0};
> > +static const struct gce_plat gce_plat_v3 = {.thread_nr = 24, .shift = 0};
>
> For global variable, you need not to initialize it to zero.
>
will fix
> > +
> > static const struct of_device_id cmdq_of_ids[] = {
> > - {.compatible = "mediatek,mt8173-gce", .data = (void *)16},
> > - {.compatible = "mediatek,mt8183-gce", .data = (void *)24},
> > + {.compatible = "mediatek,mt8173-gce", .data = (void *)&gce_plat_v2},
> > + {.compatible = "mediatek,mt8183-gce", .data = (void *)&gce_plat_v3},
> > {}
> > };
> >
> > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> > index 9add0fd5fa6c..274f6f311d05 100644
> > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> > @@ -281,6 +281,7 @@ EXPORT_SYMBOL(cmdq_pkt_poll_mask);
> >
> > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
> > {
> > + struct cmdq_client *cl = pkt->cl;
> > struct cmdq_instruction inst = { {0} };
> > int err;
> >
> > @@ -293,7 +294,7 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
> >
> > /* JUMP to end */
> > inst.op = CMDQ_CODE_JUMP;
> > - inst.value = CMDQ_JUMP_PASS;
> > + inst.value = CMDQ_JUMP_PASS >> cmdq_mbox_shift(cl->chan);
>
> cl is used only here, so I would like
>
> cmdq_mbox_shift(pkt->cl->chan);
>
> Regards,
> CK
>
will fix
Regards,
Dennis
> > err = cmdq_pkt_append_command(pkt, inst);
> >
> > return err;
> > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h
> > index a4dc45fbec0a..dfe5b2eb85cc 100644
> > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h
> > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h
> > @@ -88,4 +88,6 @@ struct cmdq_pkt {
> > void *cl;
> > };
> >
> > +u8 cmdq_mbox_shift(struct mbox_chan *chan);
> > +
> > #endif /* __MTK_CMDQ_MAILBOX_H__ */
>
>
next prev parent reply other threads:[~2019-12-12 1:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 1:58 [PATCH v2] support gce on mt6779 platform Dennis YC Hsieh
2019-11-27 1:58 ` [PATCH v2 00/14] " Dennis YC Hsieh
2019-11-27 1:58 ` [PATCH v2 01/14] dt-binding: gce: add gce header file for mt6779 Dennis YC Hsieh
2019-12-05 20:37 ` Rob Herring
2019-11-27 1:58 ` [PATCH v2 02/14] mailbox: cmdq: variablize address shift in platform Dennis YC Hsieh
2019-12-10 1:55 ` CK Hu
2019-12-12 1:03 ` Dennis-YC Hsieh [this message]
2019-11-27 1:58 ` [PATCH v2 03/14] mailbox: cmdq: support mt6779 gce platform definition Dennis YC Hsieh
2019-12-10 2:04 ` CK Hu
2019-11-27 1:58 ` [PATCH v2 04/14] mailbox: mediatek: cmdq: clear task in channel before shutdown Dennis YC Hsieh
2019-12-10 2:49 ` CK Hu
2019-12-12 1:13 ` Dennis-YC Hsieh
2019-12-12 1:31 ` CK Hu
2019-12-12 1:51 ` Dennis-YC Hsieh
2019-12-12 2:03 ` CK Hu
2019-12-12 2:20 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 05/14] arm64: dts: add gce node for mt6779 Dennis YC Hsieh
2019-12-06 4:05 ` Bibby Hsieh
2019-11-27 1:58 ` [PATCH v2 06/14] soc: mediatek: cmdq: return send msg error code Dennis YC Hsieh
2019-12-06 4:02 ` Bibby Hsieh
2019-12-18 8:00 ` Dennis-YC Hsieh
2019-12-18 8:14 ` Bibby Hsieh
2019-11-27 1:58 ` [PATCH v2 07/14] soc: mediatek: cmdq: add assign function Dennis YC Hsieh
2019-12-10 3:24 ` CK Hu
2019-12-12 1:15 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 08/14] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh
2019-12-10 5:18 ` CK Hu
2019-12-12 1:31 ` Dennis-YC Hsieh
2019-12-10 7:35 ` Bibby Hsieh
2019-12-12 1:31 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 09/14] soc: mediatek: cmdq: add read_s function Dennis YC Hsieh
2019-12-10 7:55 ` CK Hu
2019-12-12 1:33 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 10/14] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh
2019-11-27 1:58 ` [PATCH v2 11/14] soc: mediatek: cmdq: export finalize function Dennis YC Hsieh
2019-12-10 7:50 ` CK Hu
2019-11-27 1:58 ` [PATCH v2 12/14] soc: mediatek: cmdq: add loop function Dennis YC Hsieh
2019-12-11 1:48 ` CK Hu
2019-12-12 1:37 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 13/14] soc: mediatek: cmdq: add wait no clear event function Dennis YC Hsieh
2019-12-11 2:04 ` CK Hu
2019-12-12 1:42 ` Dennis-YC Hsieh
2019-11-27 1:58 ` [PATCH v2 14/14] soc: mediatek: cmdq: add set " Dennis YC Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576112593.17653.1.camel@mtkswgap22 \
--to=dennis-yc.hsieh@mediatek.com \
--cc=bibby.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).