* [PATCH] arm64: dts: sc7180: Enable video node
@ 2019-12-17 7:53 Dikshita Agarwal
2019-12-17 18:21 ` Matthias Kaehlcke
2019-12-17 19:28 ` Matthias Kaehlcke
0 siblings, 2 replies; 3+ messages in thread
From: Dikshita Agarwal @ 2019-12-17 7:53 UTC (permalink / raw)
To: andy.gross, david.brown, robh+dt, mark.rutland, devicetree
Cc: linux-kernel, linux-arm-msm, vgarodia, Dikshita Agarwal
This is a preparation gerrit to enable video node for sc7180.
This change depends on patch series Venus new features.
Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 52a5861..ccf9ef5 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1297,6 +1297,34 @@
#freq-domain-cells = <1>;
};
+
+ venus: video-codec@aa00000 {
+ compatible = "qcom,sc7180-venus";
+ reg = <0 0x0aa00000 0 0xff000>;
+ interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&videocc VENUS_GDSC>,
+ <&videocc VCODEC0_GDSC>;
+
+ power-domain-names = "venus", "vcodec0";
+ clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
+ <&videocc VIDEO_CC_VENUS_AHB_CLK>,
+ <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
+ <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
+ <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
+ clock-names = "core", "iface", "bus",
+ "vcodec0_core", "vcodec0_bus";
+ iommus = <&apps_smmu 0x0C00 0x60>;
+ memory-region = <&venus_mem>;
+ video-core0 {
+ compatible = "venus-decoder";
+ };
+ video-core1 {
+ compatible = "venus-encoder";
+ };
+ video-firmware {
+ iommus = <&apps_smmu 0x0C42 0x0>;
+ };
+ };
};
thermal-zones {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: sc7180: Enable video node
2019-12-17 7:53 [PATCH] arm64: dts: sc7180: Enable video node Dikshita Agarwal
@ 2019-12-17 18:21 ` Matthias Kaehlcke
2019-12-17 19:28 ` Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2019-12-17 18:21 UTC (permalink / raw)
To: Dikshita Agarwal
Cc: andy.gross, david.brown, robh+dt, mark.rutland, devicetree,
linux-kernel, linux-arm-msm, vgarodia
Hi
On Tue, Dec 17, 2019 at 01:23:38PM +0530, Dikshita Agarwal wrote:
> This is a preparation gerrit to enable video node for sc7180.
gerrit is a code review tool, please change to something like
"Add venus video codec node for sc7180"
> This change depends on patch series Venus new features.
Notes like this should not be part of the commit message, but put
below '---'. It would also be good to include a link to the series,
I suppose it's
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=213439
> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 52a5861..ccf9ef5 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1297,6 +1297,34 @@
>
> #freq-domain-cells = <1>;
> };
> +
> + venus: video-codec@aa00000 {
> + compatible = "qcom,sc7180-venus";
This compatible string is not listed in the bindings
(Documentation/devicetree/bindings/media/qcom,venus.txt), nor
in the driver.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: sc7180: Enable video node
2019-12-17 7:53 [PATCH] arm64: dts: sc7180: Enable video node Dikshita Agarwal
2019-12-17 18:21 ` Matthias Kaehlcke
@ 2019-12-17 19:28 ` Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2019-12-17 19:28 UTC (permalink / raw)
To: Dikshita Agarwal
Cc: andy.gross, david.brown, robh+dt, mark.rutland, devicetree,
linux-kernel, linux-arm-msm, vgarodia
On Tue, Dec 17, 2019 at 01:23:38PM +0530, Dikshita Agarwal wrote:
> This is a preparation gerrit to enable video node for sc7180.
> This change depends on patch series Venus new features.
>
> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 52a5861..ccf9ef5 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1297,6 +1297,34 @@
>
> #freq-domain-cells = <1>;
> };
> +
> + venus: video-codec@aa00000 {
Per convention nodes should be sorted by address, so this one
should be between system-cache-controller@9200000 and
thermal-sensor@c263000. If new nodes are always added to the
end conflicts are virtually guaranteed, especially in the early
phase of adding support for a SoC.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-17 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 7:53 [PATCH] arm64: dts: sc7180: Enable video node Dikshita Agarwal
2019-12-17 18:21 ` Matthias Kaehlcke
2019-12-17 19:28 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).