From: zhengbin <zhengbin13@huawei.com>
To: <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <zhengbin13@huawei.com>
Subject: [PATCH 4/6] mmc: omap_hsmmc: use true,false for bool variable
Date: Tue, 24 Dec 2019 15:32:13 +0800 [thread overview]
Message-ID: <1577172735-18869-5-git-send-email-zhengbin13@huawei.com> (raw)
In-Reply-To: <1577172735-18869-1-git-send-email-zhengbin13@huawei.com>
Fixes coccicheck warning:
drivers/mmc/host/omap_hsmmc.c:294:3-22: WARNING: Assignment of 0/1 to bool variable
drivers/mmc/host/omap_hsmmc.c:303:3-22: WARNING: Assignment of 0/1 to bool variable
drivers/mmc/host/omap_hsmmc.c:1866:1-20: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/mmc/host/omap_hsmmc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index a379c45..ce2a929 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -291,7 +291,7 @@ static int omap_hsmmc_set_pbias(struct omap_hsmmc_host *host, bool power_on)
dev_err(host->dev, "pbias reg enable fail\n");
return ret;
}
- host->pbias_enabled = 1;
+ host->pbias_enabled = true;
}
} else {
if (host->pbias_enabled == 1) {
@@ -300,7 +300,7 @@ static int omap_hsmmc_set_pbias(struct omap_hsmmc_host *host, bool power_on)
dev_err(host->dev, "pbias reg disable fail\n");
return ret;
}
- host->pbias_enabled = 0;
+ host->pbias_enabled = false;
}
}
@@ -1863,7 +1863,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
host->base = base + pdata->reg_offset;
host->power_mode = MMC_POWER_OFF;
host->next_data.cookie = 1;
- host->pbias_enabled = 0;
+ host->pbias_enabled = false;
host->vqmmc_enabled = 0;
platform_set_drvdata(pdev, host);
--
2.7.4
next prev parent reply other threads:[~2019-12-24 7:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 7:32 [PATCH 0/6] mmc: use true,false for bool variable zhengbin
2019-12-24 7:32 ` [PATCH 1/6] mmc: core: " zhengbin
2019-12-24 7:32 ` [PATCH 2/6] mmc: sdhci-tegra: " zhengbin
2019-12-24 7:32 ` [PATCH 3/6] mmc: sdhci-msm: " zhengbin
2019-12-24 7:32 ` zhengbin [this message]
2019-12-24 7:32 ` [PATCH 5/6] mmc: davinci: " zhengbin
2019-12-24 7:32 ` [PATCH 6/6] mmc: owl: " zhengbin
2020-01-16 14:39 ` [PATCH 0/6] mmc: " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1577172735-18869-5-git-send-email-zhengbin13@huawei.com \
--to=zhengbin13@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).