From: CK Hu <ck.hu@mediatek.com>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: <jassisinghbrar@gmail.com>, <nsaenzjulienne@suse.de>,
<f.fainelli@gmail.com>, <rjui@broadcom.com>,
<sbranden@broadcom.com>, <bcm-kernel-feedback-list@broadcom.com>,
<lftan@altera.com>, <matthias.bgg@gmail.com>, <agross@kernel.org>,
<bjorn.andersson@linaro.org>, <mcoquelin.stm32@gmail.com>,
<alexandre.torgue@st.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <linux-kernel@vger.kernel.org>,
<linux-rpi-kernel@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<nios2-dev@lists.rocketboards.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 04/13] mailbox: mediatek: cmdq: convert to devm_platform_ioremap_resource
Date: Mon, 30 Dec 2019 09:58:20 +0800 [thread overview]
Message-ID: <1577671100.8160.0.camel@mtksdaap41> (raw)
In-Reply-To: <20191228183538.26189-4-tiny.windzz@gmail.com>
Hi, Yangtao:
On Sat, 2019-12-28 at 18:35 +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 9a6ce9f5a7db..7f9e34b021c8 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -458,7 +458,6 @@ static struct mbox_chan *cmdq_xlate(struct mbox_controller *mbox,
> static int cmdq_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *res;
> struct cmdq *cmdq;
> int err, i;
>
> @@ -466,8 +465,7 @@ static int cmdq_probe(struct platform_device *pdev)
> if (!cmdq)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - cmdq->base = devm_ioremap_resource(dev, res);
> + cmdq->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(cmdq->base)) {
> dev_err(dev, "failed to ioremap gce\n");
> return PTR_ERR(cmdq->base);
next prev parent reply other threads:[~2019-12-30 1:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 18:35 [PATCH 01/13] mailbox: altera: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-28 18:35 ` [PATCH 02/13] mailbox: xgene-slimpro: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 03/13] mailbox: qcom-apcs: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-29 1:59 ` Bjorn Andersson
2019-12-28 18:35 ` [PATCH 04/13] mailbox: mediatek: cmdq: " Yangtao Li
2019-12-30 1:58 ` CK Hu [this message]
2019-12-28 18:35 ` [PATCH 05/13] mailbox: bcm2835: " Yangtao Li
2020-01-07 10:57 ` Nicolas Saenz Julienne
2019-12-28 18:35 ` [PATCH 06/13] mailbox: hi3660: " Yangtao Li
2019-12-30 1:04 ` Leo Yan
2019-12-28 18:35 ` [PATCH 07/13] mailbox: platform-mhu: " Yangtao Li
2019-12-28 18:35 ` [PATCH 08/13] mailbox: stm32-ipcc: " Yangtao Li
2019-12-28 18:35 ` [PATCH 09/13] mailbox: sti: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 10/13] mailbox: tegra: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-28 18:35 ` [PATCH 11/13] mailbox: hi6220: " Yangtao Li
2019-12-28 18:35 ` [PATCH 12/13] mailbox: omap: do some cleanup Yangtao Li
2019-12-28 18:35 ` [PATCH 13/13] mailbox: armada-37xx-rwtm: convert to devm_platform_ioremap_resource Yangtao Li
2020-01-08 9:43 ` Gregory CLEMENT
2019-12-30 1:50 ` [PATCH 01/13] mailbox: altera: " Tan, Ley Foon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1577671100.8160.0.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=agross@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=lftan@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nios2-dev@lists.rocketboards.org \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).