From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F8EC00523 for ; Wed, 8 Jan 2020 10:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C030205F4 for ; Wed, 8 Jan 2020 10:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727912AbgAHKpI convert rfc822-to-8bit (ORCPT ); Wed, 8 Jan 2020 05:45:08 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:63048 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726098AbgAHKpI (ORCPT ); Wed, 8 Jan 2020 05:45:08 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19806929-1500050 for multiple; Wed, 08 Jan 2020 10:44:59 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Jani Nikula , Joonas Lahtinen , Wambui Karuga , airlied@linux.ie, daniel@ffwll.ch, rodrigo.vivi@intel.com From: Chris Wilson In-Reply-To: <8736cqs2uf.fsf@intel.com> Cc: intel-gfx@lists.freedesktop.org, seanpaul@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <157847199686.4725.87481257304852182@jlahtine-desk.ger.corp.intel.com> <8736cqs2uf.fsf@intel.com> Message-ID: <157848029770.2273.9590955422248556735@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915: convert to using the drm_dbg_kms() macro. Date: Wed, 08 Jan 2020 10:44:57 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jani Nikula (2020-01-08 09:40:40) > On Wed, 08 Jan 2020, Joonas Lahtinen wrote: > > Quoting Wambui Karuga (2020-01-07 17:13:29) > >> Convert the use of the DRM_DEBUG_KMS() logging macro to the new struct > >> drm_device based drm_dbg_kms() logging macro in i915/intel_pch.c. > >> > >> Signed-off-by: Wambui Karuga > >> --- > >> drivers/gpu/drm/i915/intel_pch.c | 46 +++++++++++++++++--------------- > >> 1 file changed, 24 insertions(+), 22 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c > >> index 43b68b5fc562..4ed60e1f01db 100644 > >> --- a/drivers/gpu/drm/i915/intel_pch.c > >> +++ b/drivers/gpu/drm/i915/intel_pch.c > >> @@ -12,90 +12,91 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id) > >> { > >> switch (id) { > >> case INTEL_PCH_IBX_DEVICE_ID_TYPE: > >> - DRM_DEBUG_KMS("Found Ibex Peak PCH\n"); > >> + drm_dbg_kms(&dev_priv->drm, "Found Ibex Peak PCH\n"); > > > > Did we at some point consider i915_dbg_kms alias? That would just take > > dev_priv (or i915, as it's called in newer code). It would shorten many > > of the statements. > > > > i915_dbg_kms(dev_priv, ...) or i915_dbg_kms(i915, ...) > > I'd rather use the common drm logging macros. I thought about adding > i915 specific ones only if the drm device specific logging macros > weren't going to be merged. Why do they even exist? Why isn't it enough to do #define drm_info(drm, fmt, ...) dev_info(&(drm)->dev, fmt, ##__VA_ARGS) ? #define i915_info(i915, fmt, ...) drm_info(&(i915)->drm, fmt, ##__VA_ARGS) The lea for &i915->drm.dev is the same as the mov, so we shave off an unnecessary wrapper. -Chris