* [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST
@ 2020-01-14 16:09 Alan Maguire
2020-01-14 16:30 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Alan Maguire @ 2020-01-14 16:09 UTC (permalink / raw)
To: brendanhiggins, gregkh, rjw, dmitry.torokhov
Cc: sfr, rdunlap, linux-kernel, linux-next, linux-kselftest, skhan
currently the property entry kunit tests are built if CONFIG_KUNIT=y.
This will cause warnings when merged with the kunit tree that now
supports tristate CONFIG_KUNIT. While the tests appear to compile
as a module, we get a warning about missing module license.
It's better to have a per-test suite CONFIG variable so that
we can do selective building of kunit-based suites, and can
also avoid merge issues like this.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: c032ace71c29 ("software node: add basic tests for property entries")
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
drivers/base/test/Kconfig | 3 +++
drivers/base/test/Makefile | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
index 86e85da..d29ae95 100644
--- a/drivers/base/test/Kconfig
+++ b/drivers/base/test/Kconfig
@@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
The module name will be test_async_driver_probe.ko
If unsure say N.
+config KUNIT_DRIVER_PE_TEST
+ bool "KUnit Tests for property entry API"
+ depends on KUNIT
diff --git a/drivers/base/test/Makefile b/drivers/base/test/Makefile
index 2214310..3ca5636 100644
--- a/drivers/base/test/Makefile
+++ b/drivers/base/test/Makefile
@@ -1,4 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE) += test_async_driver_probe.o
-obj-$(CONFIG_KUNIT) += property-entry-test.o
+obj-$(CONFIG_KUNIT_DRIVER_PE_TEST) += property-entry-test.o
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST
2020-01-14 16:09 [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST Alan Maguire
@ 2020-01-14 16:30 ` Randy Dunlap
2020-01-14 16:42 ` Alan Maguire
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2020-01-14 16:30 UTC (permalink / raw)
To: Alan Maguire, brendanhiggins, gregkh, rjw, dmitry.torokhov
Cc: sfr, linux-kernel, linux-next, linux-kselftest, skhan
Hi Alan,
On 1/14/20 8:09 AM, Alan Maguire wrote:
> currently the property entry kunit tests are built if CONFIG_KUNIT=y.
> This will cause warnings when merged with the kunit tree that now
> supports tristate CONFIG_KUNIT. While the tests appear to compile
> as a module, we get a warning about missing module license.
>
> It's better to have a per-test suite CONFIG variable so that
> we can do selective building of kunit-based suites, and can
> also avoid merge issues like this.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: c032ace71c29 ("software node: add basic tests for property entries")
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> ---
> drivers/base/test/Kconfig | 3 +++
> drivers/base/test/Makefile | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
> index 86e85da..d29ae95 100644
> --- a/drivers/base/test/Kconfig
> +++ b/drivers/base/test/Kconfig
> @@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
> The module name will be test_async_driver_probe.ko
>
> If unsure say N.
> +config KUNIT_DRIVER_PE_TEST
> + bool "KUnit Tests for property entry API"
> + depends on KUNIT
Why is this bool instead of tristate?
> diff --git a/drivers/base/test/Makefile b/drivers/base/test/Makefile
> index 2214310..3ca5636 100644
> --- a/drivers/base/test/Makefile
> +++ b/drivers/base/test/Makefile
> @@ -1,4 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0
> obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE) += test_async_driver_probe.o
>
> -obj-$(CONFIG_KUNIT) += property-entry-test.o
> +obj-$(CONFIG_KUNIT_DRIVER_PE_TEST) += property-entry-test.o
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST
2020-01-14 16:30 ` Randy Dunlap
@ 2020-01-14 16:42 ` Alan Maguire
2020-01-14 16:45 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Alan Maguire @ 2020-01-14 16:42 UTC (permalink / raw)
To: Randy Dunlap
Cc: Alan Maguire, brendanhiggins, gregkh, rjw, dmitry.torokhov, sfr,
linux-kernel, linux-next, linux-kselftest, skhan
On Tue, 14 Jan 2020, Randy Dunlap wrote:
> Hi Alan,
>
> On 1/14/20 8:09 AM, Alan Maguire wrote:
> > currently the property entry kunit tests are built if CONFIG_KUNIT=y.
> > This will cause warnings when merged with the kunit tree that now
> > supports tristate CONFIG_KUNIT. While the tests appear to compile
> > as a module, we get a warning about missing module license.
> >
> > It's better to have a per-test suite CONFIG variable so that
> > we can do selective building of kunit-based suites, and can
> > also avoid merge issues like this.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>
Apologies for missing you out here.
> > Fixes: c032ace71c29 ("software node: add basic tests for property entries")
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > ---
> > drivers/base/test/Kconfig | 3 +++
> > drivers/base/test/Makefile | 2 +-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
> > index 86e85da..d29ae95 100644
> > --- a/drivers/base/test/Kconfig
> > +++ b/drivers/base/test/Kconfig
> > @@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
> > The module name will be test_async_driver_probe.ko
> >
> > If unsure say N.
> > +config KUNIT_DRIVER_PE_TEST
> > + bool "KUnit Tests for property entry API"
> > + depends on KUNIT
>
> Why is this bool instead of tristate?
>
The support for building kunit and kunit tests as modules has not merged
into linux-next yet, so if we set the option to tristate the build would
fail for allmodconfig builds. Once it's merged we can revisit though; I
should have mentioned this, thanks for reminding me!
Alan
> > diff --git a/drivers/base/test/Makefile b/drivers/base/test/Makefile
> > index 2214310..3ca5636 100644
> > --- a/drivers/base/test/Makefile
> > +++ b/drivers/base/test/Makefile
> > @@ -1,4 +1,4 @@
> > # SPDX-License-Identifier: GPL-2.0
> > obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE) += test_async_driver_probe.o
> >
> > -obj-$(CONFIG_KUNIT) += property-entry-test.o
> > +obj-$(CONFIG_KUNIT_DRIVER_PE_TEST) += property-entry-test.o
> >
>
> thanks.
> --
> ~Randy
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST
2020-01-14 16:42 ` Alan Maguire
@ 2020-01-14 16:45 ` Randy Dunlap
2020-01-14 22:43 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2020-01-14 16:45 UTC (permalink / raw)
To: Alan Maguire
Cc: brendanhiggins, gregkh, rjw, dmitry.torokhov, sfr, linux-kernel,
linux-next, linux-kselftest, skhan
On 1/14/20 8:42 AM, Alan Maguire wrote:
> On Tue, 14 Jan 2020, Randy Dunlap wrote:
>
>> Hi Alan,
>>
>> On 1/14/20 8:09 AM, Alan Maguire wrote:
>>> currently the property entry kunit tests are built if CONFIG_KUNIT=y.
>>> This will cause warnings when merged with the kunit tree that now
>>> supports tristate CONFIG_KUNIT. While the tests appear to compile
>>> as a module, we get a warning about missing module license.
>>>
>>> It's better to have a per-test suite CONFIG variable so that
>>> we can do selective building of kunit-based suites, and can
>>> also avoid merge issues like this.
>>>
>>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>>
>
> Apologies for missing you out here.
>
>>> Fixes: c032ace71c29 ("software node: add basic tests for property entries")
>>> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
>>> ---
>>> drivers/base/test/Kconfig | 3 +++
>>> drivers/base/test/Makefile | 2 +-
>>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
>>> index 86e85da..d29ae95 100644
>>> --- a/drivers/base/test/Kconfig
>>> +++ b/drivers/base/test/Kconfig
>>> @@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
>>> The module name will be test_async_driver_probe.ko
>>>
>>> If unsure say N.
>>> +config KUNIT_DRIVER_PE_TEST
>>> + bool "KUnit Tests for property entry API"
>>> + depends on KUNIT
>>
>> Why is this bool instead of tristate?
>>
>
> The support for building kunit and kunit tests as modules has not merged
> into linux-next yet, so if we set the option to tristate the build would
> fail for allmodconfig builds. Once it's merged we can revisit though; I
> should have mentioned this, thanks for reminding me!
Oh. I see. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST
2020-01-14 16:45 ` Randy Dunlap
@ 2020-01-14 22:43 ` Rafael J. Wysocki
2020-01-14 23:52 ` Brendan Higgins
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2020-01-14 22:43 UTC (permalink / raw)
To: Randy Dunlap, Alan Maguire
Cc: brendanhiggins, gregkh, dmitry.torokhov, sfr, linux-kernel,
linux-next, linux-kselftest, skhan
On Tuesday, January 14, 2020 5:45:56 PM CET Randy Dunlap wrote:
> On 1/14/20 8:42 AM, Alan Maguire wrote:
> > On Tue, 14 Jan 2020, Randy Dunlap wrote:
> >
> >> Hi Alan,
> >>
> >> On 1/14/20 8:09 AM, Alan Maguire wrote:
> >>> currently the property entry kunit tests are built if CONFIG_KUNIT=y.
> >>> This will cause warnings when merged with the kunit tree that now
> >>> supports tristate CONFIG_KUNIT. While the tests appear to compile
> >>> as a module, we get a warning about missing module license.
> >>>
> >>> It's better to have a per-test suite CONFIG variable so that
> >>> we can do selective building of kunit-based suites, and can
> >>> also avoid merge issues like this.
> >>>
> >>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >>
> >> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> >>
> >
> > Apologies for missing you out here.
> >
> >>> Fixes: c032ace71c29 ("software node: add basic tests for property entries")
> >>> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> >>> ---
> >>> drivers/base/test/Kconfig | 3 +++
> >>> drivers/base/test/Makefile | 2 +-
> >>> 2 files changed, 4 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
> >>> index 86e85da..d29ae95 100644
> >>> --- a/drivers/base/test/Kconfig
> >>> +++ b/drivers/base/test/Kconfig
> >>> @@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
> >>> The module name will be test_async_driver_probe.ko
> >>>
> >>> If unsure say N.
> >>> +config KUNIT_DRIVER_PE_TEST
> >>> + bool "KUnit Tests for property entry API"
> >>> + depends on KUNIT
> >>
> >> Why is this bool instead of tristate?
> >>
> >
> > The support for building kunit and kunit tests as modules has not merged
> > into linux-next yet, so if we set the option to tristate the build would
> > fail for allmodconfig builds. Once it's merged we can revisit though; I
> > should have mentioned this, thanks for reminding me!
>
> Oh. I see. Thanks.
Patch applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST
2020-01-14 22:43 ` Rafael J. Wysocki
@ 2020-01-14 23:52 ` Brendan Higgins
0 siblings, 0 replies; 6+ messages in thread
From: Brendan Higgins @ 2020-01-14 23:52 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Randy Dunlap, Alan Maguire, Greg KH, Dmitry Torokhov,
Stephen Rothwell, Linux Kernel Mailing List,
Linux Next Mailing List, open list:KERNEL SELFTEST FRAMEWORK,
Shuah Khan
On Tue, Jan 14, 2020 at 2:43 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> On Tuesday, January 14, 2020 5:45:56 PM CET Randy Dunlap wrote:
> > On 1/14/20 8:42 AM, Alan Maguire wrote:
> > > On Tue, 14 Jan 2020, Randy Dunlap wrote:
> > >
> > >> Hi Alan,
> > >>
> > >> On 1/14/20 8:09 AM, Alan Maguire wrote:
> > >>> currently the property entry kunit tests are built if CONFIG_KUNIT=y.
> > >>> This will cause warnings when merged with the kunit tree that now
> > >>> supports tristate CONFIG_KUNIT. While the tests appear to compile
> > >>> as a module, we get a warning about missing module license.
> > >>>
> > >>> It's better to have a per-test suite CONFIG variable so that
> > >>> we can do selective building of kunit-based suites, and can
> > >>> also avoid merge issues like this.
> > >>>
> > >>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > >>
> > >> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > >>
> > >
> > > Apologies for missing you out here.
> > >
> > >>> Fixes: c032ace71c29 ("software node: add basic tests for property entries")
> > >>> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > >>> ---
> > >>> drivers/base/test/Kconfig | 3 +++
> > >>> drivers/base/test/Makefile | 2 +-
> > >>> 2 files changed, 4 insertions(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
> > >>> index 86e85da..d29ae95 100644
> > >>> --- a/drivers/base/test/Kconfig
> > >>> +++ b/drivers/base/test/Kconfig
> > >>> @@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
> > >>> The module name will be test_async_driver_probe.ko
> > >>>
> > >>> If unsure say N.
> > >>> +config KUNIT_DRIVER_PE_TEST
> > >>> + bool "KUnit Tests for property entry API"
> > >>> + depends on KUNIT
> > >>
> > >> Why is this bool instead of tristate?
> > >>
> > >
> > > The support for building kunit and kunit tests as modules has not merged
> > > into linux-next yet, so if we set the option to tristate the build would
> > > fail for allmodconfig builds. Once it's merged we can revisit though; I
> > > should have mentioned this, thanks for reminding me!
> >
> > Oh. I see. Thanks.
>
> Patch applied, thanks!
Cool, looks good. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-14 23:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 16:09 [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST Alan Maguire
2020-01-14 16:30 ` Randy Dunlap
2020-01-14 16:42 ` Alan Maguire
2020-01-14 16:45 ` Randy Dunlap
2020-01-14 22:43 ` Rafael J. Wysocki
2020-01-14 23:52 ` Brendan Higgins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).