From: Alan Maguire <alan.maguire@oracle.com>
To: rjw@rjwysocki.net
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, brendanhiggins@google.com,
linux-next@vger.kernel.org, dmitry.torokhov@gmail.com,
sfr@canb.auug.org.au, rdunlap@infradead.org,
Alan Maguire <alan.maguire@oracle.com>
Subject: [PATCH] software node: property entry kunit tests must depend on KUNIT=y
Date: Thu, 16 Jan 2020 11:17:31 +0000 [thread overview]
Message-ID: <1579173451-2439-1-git-send-email-alan.maguire@oracle.com> (raw)
property entry kunit tests are built if CONFIG_KUNIT_DRIVER_PE_TEST
(a boolean) is 'y'; it in turn depends on CONFIG_KUNIT. However to
ensure clean merge with linux-next, where CONFIG_KUNIT is tristate,
we need to explicitly specify KUNIT=y as a dependency, otherwise
allmodconfig builds will build kunit as a module and fail to build
the property entry tests. Later CONFIG_KUNIT_DRIVER_PE_TEST can
be converted to tristate.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 27f9d7e984d9 ("software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST")
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
drivers/base/test/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
index d29ae95..305c775 100644
--- a/drivers/base/test/Kconfig
+++ b/drivers/base/test/Kconfig
@@ -10,4 +10,4 @@ config TEST_ASYNC_DRIVER_PROBE
If unsure say N.
config KUNIT_DRIVER_PE_TEST
bool "KUnit Tests for property entry API"
- depends on KUNIT
+ depends on KUNIT=y
--
1.8.3.1
next reply other threads:[~2020-01-16 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 11:17 Alan Maguire [this message]
2020-01-16 23:27 ` [PATCH] software node: property entry kunit tests must depend on KUNIT=y Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1579173451-2439-1-git-send-email-alan.maguire@oracle.com \
--to=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sfr@canb.auug.org.au \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).