From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DBF0C433E0 for ; Tue, 9 Mar 2021 11:47:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E044965267 for ; Tue, 9 Mar 2021 11:47:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230299AbhCILqs (ORCPT ); Tue, 9 Mar 2021 06:46:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:31162 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbhCILq3 (ORCPT ); Tue, 9 Mar 2021 06:46:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615290388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HdTaXsQxd+FqPWUSVRaEgIQyzhznpJI3o8r6KsqiM/0=; b=N86xszToYBituoiigdQHGIo2jlUmCHnuI27VAYYFK8rkCJiREiHVxjQJKh5b/53OneUPDh qxxeDrwNljo6pI2a/44kXHSRix3qnQ+Nv6UxMiBWwYWC/lEQ3pXzbg32q6pZBStoztgAFT 2GpI4Nf6Dt7c88PPHvfs2HtqD4cBpLU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-498-vOXecCFHNH2A5oCCpZfuxA-1; Tue, 09 Mar 2021 06:46:24 -0500 X-MC-Unique: vOXecCFHNH2A5oCCpZfuxA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6981319067E1; Tue, 9 Mar 2021 11:46:23 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-152.rdu2.redhat.com [10.10.118.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 17B6A100239A; Tue, 9 Mar 2021 11:46:21 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <77085577-01EB-48F5-868B-E7A1813363A1@oracle.com> References: <77085577-01EB-48F5-868B-E7A1813363A1@oracle.com> <20210304175030.184131-1-eric.snowberg@oracle.com> <147604.1614981032@warthog.procyon.org.uk> To: Eric Snowberg Cc: dhowells@redhat.com, Randy Dunlap , Jarkko Sakkinen , nathan@kernel.org, David Woodhouse , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] certs: Fix wrong kconfig option used for x509_revocation_list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 09 Mar 2021 11:46:21 +0000 Message-ID: <157933.1615290381@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Snowberg wrote: > >> @@ -11,7 +11,7 @@ hostprogs-always-$(CONFIG_ASN1) +=3D asn1_compiler > >> hostprogs-always-$(CONFIG_MODULE_SIG_FORMAT) +=3D sign-file > >> hostprogs-always-$(CONFIG_SYSTEM_TRUSTED_KEYRING) +=3D extract-cert > >> hostprogs-always-$(CONFIG_SYSTEM_EXTRA_CERTIFICATE) +=3D insert-sys-ce= rt > >> - hostprogs-always-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) +=3D extract-cert > >> +hostprogs-always-$(CONFIG_SYSTEM_REVOCATION_LIST) +=3D extract-cert > >=20 > > Hmmm... We have extract-cert listed twice. Does that matter, I wonder? >=20 > Isn=E2=80=99t this necessary, since one could build with either=20 > CONFIG_SYSTEM_REVOCATION_LIST or CONFIG_SYSTEM_TRUSTED_KEYRING, without=20 > the other being defined? Well, it could be handled with its own Kconfig, say CONFIG_BUILD_EXTRACT_CE= RT, but that would seem like overkill. I think make should handle a dependency being listed multiple times for a target, but it might make sense to list t= hem next to each other. David