From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Alan Tull <atull@kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Moritz Fischer <mdf@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-fpga@vger.kernel.org
Subject: Re: [RFC 0/2] of: Add whitelist
Date: Thu, 30 Nov 2017 07:18:09 -0500 [thread overview]
Message-ID: <157eebaf-89a9-a230-e56b-d98a8e1e26bf@gmail.com> (raw)
In-Reply-To: <CAL_JsqL5gYh_++1wDLMYjO7MXKOHpzr315FZ1tuN9o5tOe7TYA@mail.gmail.com>
On 11/29/17 08:31, Rob Herring wrote:
> On Wed, Nov 29, 2017 at 3:20 AM, Frank Rowand <frowand.list@gmail.com> wrote:
>> On 11/27/17 15:58, Alan Tull wrote:
>>> Here's a proposal for a whitelist to lock down the dynamic device tree.
>>>
>>> For an overlay to be accepted, all of its targets are required to be
>>> on a target node whitelist.
>>>
>>> Currently the only way I have to get on the whitelist is calling a
>>> function to add a node. That works for fpga regions, but I think
>>> other uses will need a way of having adding specific nodes from the
>>> base device tree, such as by adding a property like 'allow-overlay;'
>>> or 'allow-overlay = "okay";' If that is acceptable, I could use some
>>> advice on where that particular code should go.
>>>
>>> Alan
>>>
>>> Alan Tull (2):
>>> of: overlay: add whitelist
>>> fpga: of region: add of-fpga-region to whitelist
>>>
>>> drivers/fpga/of-fpga-region.c | 9 ++++++
>>> drivers/of/overlay.c | 73 +++++++++++++++++++++++++++++++++++++++++++
>>> include/linux/of.h | 12 +++++++
>>> 3 files changed, 94 insertions(+)
>>>
>>
>> The plan was to use connectors to restrict where an overlay could be applied.
>> I would prefer not to have multiple methods for accomplishing the same thing
>> unless there is a compelling reason to do so.
>
> Connector nodes need a mechanism to enable themselves, too. I don't
> think connector nodes are going to solve every usecase.
>
> Rob
>
The overlay code related to connectors does not exist yet, so my comment
is going to be theoretical.
I would expect the overlay code to check that the target of the overlay
fragment is a connector node, so there is no need to explicitly "enable"
applying an overlay to a connector node.
-Frank
next prev parent reply other threads:[~2017-11-30 12:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 20:58 [RFC 0/2] of: Add whitelist Alan Tull
2017-11-27 20:58 ` [RFC 1/2] of: overlay: add whitelist Alan Tull
2017-11-28 15:15 ` Rob Herring
2017-11-28 19:26 ` Alan Tull
2017-11-29 9:25 ` Frank Rowand
2017-11-27 20:58 ` [RFC 2/2] fpga: of region: add of-fpga-region to whitelist Alan Tull
2017-11-29 9:20 ` [RFC 0/2] of: Add whitelist Frank Rowand
2017-11-29 13:31 ` Rob Herring
2017-11-29 16:11 ` Alan Tull
2017-11-30 12:46 ` Frank Rowand
2017-12-05 16:33 ` Alan Tull
2017-12-06 11:56 ` Frank Rowand
2017-12-07 19:22 ` Alan Tull
2017-11-30 12:18 ` Frank Rowand [this message]
2017-12-05 16:55 ` Alan Tull
2017-12-06 11:47 ` Frank Rowand
2017-11-29 22:47 ` Frank Rowand
2017-11-30 14:39 ` Rob Herring
2017-12-06 11:44 ` Frank Rowand
2017-11-30 0:58 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157eebaf-89a9-a230-e56b-d98a8e1e26bf@gmail.com \
--to=frowand.list@gmail.com \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).