From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBD4C2D0DB for ; Mon, 27 Jan 2020 11:28:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 762652087F for ; Mon, 27 Jan 2020 11:28:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="ceiYlsjt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729681AbgA0L2p (ORCPT ); Mon, 27 Jan 2020 06:28:45 -0500 Received: from mail-mw2nam10on2059.outbound.protection.outlook.com ([40.107.94.59]:6169 "EHLO NAM10-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726428AbgA0L2p (ORCPT ); Mon, 27 Jan 2020 06:28:45 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WEOephbBXL4NZMXKR6iScpUCvtWX3nJ118GJtkM2WMUXn1qa+k9TkrNcscatYpGIe/V3Ih5rOvMrKojvsAB5Z1SbHGBehH+BF/PEOP4SbkctIZRqj2r9k0ROAf3lNyJwtCTETalUq0yK8sXhjKnCA74s4KfjAjtLcoa9yLrde89Kxe7dlb62Bsz5LiaxG3oz3oOjMjnj6I5lnbu+yOsusPr8yvml4aRfsB6/Hp5ZuASXuxr64VgTK8UibcMw9+rOqJQwHCL/i1wSZ/M78aTSyQWxZUMCt4wBEGB989cLQL2WCBIHpBl4r3RsQd0oQK2FnfhOtsKlxupyIFz3RnTdWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m2x9/N2p+8jF2vK17XXB4h22BcoFcjkEK1yo28zsUbA=; b=BScMs3G8St4ngn8Wb61phbbVe69ZtfThh/mdHacCGC7HaN+2RZECAshkvgEd8qpRvhwh2QesPMphyCi8ODYFvI/GR0hryWiirXhMHeZRbuH4WPsEyKwbX7s5OMDx0VJ39EKHyeCzHKgu3RCpkDQajzM2wq77nX1tf/xN9NFg5RxN6cmBhFOjV1advDMxsUPaZsJf5MMY+0/+ucQS91IGxKO0mPKqrC6256rU4icmdgV/85dsdqMxPm5xaqsyDRmWwSp692zF6EOQ8IWS5/6DgXj0zfSXaWm20VDORxmwbImW7jOscqu90VfIMjEBZaXF8nsKTRfBllFHSM5v32bhHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=permerror action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m2x9/N2p+8jF2vK17XXB4h22BcoFcjkEK1yo28zsUbA=; b=ceiYlsjtBk6MpbGzrN6//cIwfwyyp3UByy1pRp3FWpAULJoIJshdlckVYcd53wnOK1IHMEVhRjhVDzrRmjN4uMR+XHFLjen7Rhs76es8h1FfYA8IFfn0hjLGRpnnq9epgOG/nWl7jACBOjAl9TGHkY4hoPbXS0X+kcYuByiMPvc= Received: from SN1PR12CA0047.namprd12.prod.outlook.com (2603:10b6:802:20::18) by DM5PR12MB1468.namprd12.prod.outlook.com (2603:10b6:4:10::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.24; Mon, 27 Jan 2020 11:28:41 +0000 Received: from CO1NAM11FT057.eop-nam11.prod.protection.outlook.com (2a01:111:f400:7eab::208) by SN1PR12CA0047.outlook.office365.com (2603:10b6:802:20::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.21 via Frontend Transport; Mon, 27 Jan 2020 11:28:40 +0000 Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=permerror action=none header.from=amd.com; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXMB02.amd.com (165.204.84.17) by CO1NAM11FT057.mail.protection.outlook.com (10.13.174.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2665.18 via Frontend Transport; Mon, 27 Jan 2020 11:28:40 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 27 Jan 2020 05:28:39 -0600 Received: from SATLEXMB01.amd.com (10.181.40.142) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 27 Jan 2020 05:28:39 -0600 Received: from vishnu-All-Series.amd.com (10.180.168.240) by SATLEXMB01.amd.com (10.181.40.142) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Mon, 27 Jan 2020 05:28:35 -0600 From: Ravulapati Vishnu vardhan rao CC: , , "Ravulapati Vishnu vardhan rao" , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Vijendar Mukunda , YueHaibing , Kuninori Morimoto , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH] ASoC: amd: Fix for Subsequent Playback issue. Date: Mon, 27 Jan 2020 16:56:03 +0530 Message-ID: <1580124397-19842-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17;IPV:;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(346002)(376002)(396003)(136003)(428003)(189003)(199004)(4326008)(36756003)(26005)(186003)(8936002)(7696005)(8676002)(54906003)(81166006)(81156014)(5660300002)(109986005)(356004)(316002)(6666004)(86362001)(478600001)(70206006)(70586007)(336012)(2906002)(426003)(2616005)(266003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1468;H:SATLEXMB02.amd.com;FPR:;SPF:None;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32bfbfd8-d1d8-4068-da6a-08d7a31c0f3e X-MS-TrafficTypeDiagnostic: DM5PR12MB1468: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2582; X-Forefront-PRVS: 02951C14DC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1o2bHrFbRLrf3gHL/mRLo7O7pY00Y7s4PKS26RXjFjDD/uxa+a6xEcZSxWYWR0ezPtVBtapfJZj4khr9FKMs7n26sfNuAJEH4T/+UnMLam//uUxrKb++06wyy9462VZ6gFH+3yTMparuC7iSReRAMGq0BhbPFYmVJg89+RupmZgZWtg50lUfPvB+8xE92kPpk9qCuOKbBcX9Sks7DKu1nrJvh2R3mVn72HB6pTIUc7mFeVIWi5FwTy75ipskKNkrs2ymqGyTDy+itN+7Drnd6M+VRsS+4O7U7DxYeqbA0s3gDzg2a5D68Kz1jB/klZIhjOXhuYXiHnamh/YIQISR7OTa7AEVKtBm1naMxSINNYC+zyf72VT50b5y2IC/LiSm+RCaFyK4SZIQA3+XGotN7LgMZL5tWTmFPbj8GLm1ppBnrumBFjpBw0snONw1EYoOl0Fo1D6V/g1m6Ued6WqkUC6aGDff8TkGSiWcMIOGbUQ= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2020 11:28:40.4838 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32bfbfd8-d1d8-4068-da6a-08d7a31c0f3e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1468 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If we play audio back to back, which kills one playback and immediately start another, we can hear clicks. This patch fixes the issue. Signed-off-by: Ravulapati Vishnu vardhan rao --- sound/soc/amd/raven/acp3x-pcm-dma.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c index 5c3ec3c..aecc3c0 100644 --- a/sound/soc/amd/raven/acp3x-pcm-dma.c +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c @@ -349,13 +349,6 @@ static int acp3x_dma_close(struct snd_soc_component *component, component = snd_soc_rtdcom_lookup(prtd, DRV_NAME); adata = dev_get_drvdata(component->dev); - if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { - adata->play_stream = NULL; - adata->i2ssp_play_stream = NULL; - } else { - adata->capture_stream = NULL; - adata->i2ssp_capture_stream = NULL; - } /* Disable ACP irq, when the current stream is being closed and * another stream is also not active. @@ -363,6 +356,13 @@ static int acp3x_dma_close(struct snd_soc_component *component, if (!adata->play_stream && !adata->capture_stream && !adata->i2ssp_play_stream && !adata->i2ssp_capture_stream) rv_writel(0, adata->acp3x_base + mmACP_EXTERNAL_INTR_ENB); + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { + adata->play_stream = NULL; + adata->i2ssp_play_stream = NULL; + } else { + adata->capture_stream = NULL; + adata->i2ssp_capture_stream = NULL; + } return 0; } -- 2.7.4