From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36148C3524D for ; Mon, 3 Feb 2020 15:48:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF3AF2082E for ; Mon, 3 Feb 2020 15:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="kUu9P+c9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728196AbgBCPsV (ORCPT ); Mon, 3 Feb 2020 10:48:21 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:45150 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727620AbgBCPsU (ORCPT ); Mon, 3 Feb 2020 10:48:20 -0500 Received: by mail-qt1-f196.google.com with SMTP id d9so11730274qte.12 for ; Mon, 03 Feb 2020 07:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=YNMOJs1FPm/l462+AObUcJBpy8J/6Ie1z+BZTrXlP78=; b=kUu9P+c9Xi/sRwQmUmgRczJtLr5gqK+yFzRIYgulkIKq53mKQTosQf2B1M6rGAi1Vz zf6l65bkbMXSBdMvkcorvRBREKJsVTppzgxLeEe94RRQYYE5rTfTkBy5PLm4V1jr5ZQ2 8/TkMtxS7aFoHnfHuQCreV0p97LuOHmi4sH1PeQhHzRc+prSAziRCba+Efew+79NFeug 7sAupOPSdzNPuzEGx/PoF+bkDk7yc1blkxEFffDT9NhTb2wE5i6A49kcGqskeWYy690O nI+R4iCW7RBwWJK/FMvjoUPLd2pEL4Dy23U+/NizYdlcaK8tA1r3cfCm2lrDynXLFW6Q 69MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=YNMOJs1FPm/l462+AObUcJBpy8J/6Ie1z+BZTrXlP78=; b=ju2MkPx9q0YJAZpopOXfOrSnE2ptFiiNX1tGHkQszpD1jhq5k3+k5qqVVf9oXsomRK XvxF+FT7MrjEt43ZtzV6m8mSlBa6x6WjbS3ub6QIP4oncQkeVweAz+M7y+fMt8avFFC3 TDqR+rsYVf9V6gz30rQtLjBecNyA5J7JUw9uta+1EfjoPFemIlXxFckdDwpBx84IWBni aWpnYLuIzMbpfQSKdeV+5PZqMZ878fRBvt8XutX1z/rrF0RDbLhEgJJNlfafL7Ec+pWC CgaDmM5UYpKgvlpbd2Ylv7BTAvjrZU9FAy4IQvNHh3TUtMon2YCgviuyK/+96BCYzfo8 UtyQ== X-Gm-Message-State: APjAAAXUpkr/tSYCUcZ6y2sLaBWNLmhqZ01GEJOyNv9MhcAWdO1vc3L4 YbuY2dwG1mJw6vi/bS46ZZSChg== X-Google-Smtp-Source: APXvYqzzoz8hW5WNsRr+QGAP5pmz1r20ujicRCSbC4RPyZEQg2Pm/930hS/RB0M0ITiwlO80rrs//A== X-Received: by 2002:ac8:7695:: with SMTP id g21mr22123082qtr.99.1580744899546; Mon, 03 Feb 2020 07:48:19 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id n132sm9814556qke.58.2020.02.03.07.48.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Feb 2020 07:48:18 -0800 (PST) Message-ID: <1580744894.7365.3.camel@lca.pw> Subject: Re: [PATCH V12] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Christophe Leroy Cc: Anshuman Khandual , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, kasan-dev Date: Mon, 03 Feb 2020 10:48:14 -0500 In-Reply-To: <8e94a073-4045-89aa-6a3b-24847ad7c858@c-s.fr> References: <473d8198-3ac4-af3b-e2ec-c0698a3565d3@c-s.fr> <2C4ADFAE-7BB4-42B7-8F54-F036EA7A4316@lca.pw> <8e94a073-4045-89aa-6a3b-24847ad7c858@c-s.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-02-03 at 16:14 +0100, Christophe Leroy wrote: > > Le 02/02/2020 à 12:26, Qian Cai a écrit : > > > > > > > On Jan 30, 2020, at 9:13 AM, Christophe Leroy wrote: > > > > > > config DEBUG_VM_PGTABLE > > > bool "Debug arch page table for semantics compliance" if ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT > > > depends on MMU > > > default 'n' if !ARCH_HAS_DEBUG_VM_PGTABLE > > > default 'y' if DEBUG_VM > > > > Does it really necessary to potentially force all bots to run this? Syzbot, kernel test robot etc? Does it ever pay off for all their machine times there? > > > > Machine time ? > > On a 32 bits powerpc running at 132 MHz, the tests takes less than 10ms. > Is it worth taking the risk of not detecting faults by not selecting it > by default ? The risk is quite low as Catalin mentioned this thing is not to detect regressions but rather for arch/mm maintainers. I do appreciate the efforts to get everyone as possible to run this thing, so it get more notices once it is broken. However, DEBUG_VM seems like such a generic Kconfig those days that have even been enabled by default for Fedora Linux, so I would rather see a more sensitive default been taken even though the test runtime is fairly quickly on a small machine for now. > > [ 5.656916] debug_vm_pgtable: debug_vm_pgtable: Validating > architecture page table helpers > [ 5.665661] debug_vm_pgtable: debug_vm_pgtable: Validated > architecture page table helpers