linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shen Kai <shenkai8@huawei.com>
To: <gregkh@linuxfoundation.org>, <jslaby@suse.com>
Cc: <linux-kernel@vger.kernel.org>, <hushiyuan@huawei.com>,
	<linfeilong@huawei.com>
Subject: [PATCH] add lock proctect to __handle_sysrq in write_sysrq_trigger
Date: Fri, 7 Feb 2020 07:56:06 +0000	[thread overview]
Message-ID: <1581062166-27284-1-git-send-email-shenkai8@huawei.com> (raw)

From: Feilong Lin <linfeilong@huawei.com>

Add lock protect to __handle_sysrq to avoid race condition.
__handle_sysrq will change console_loglevel without lock protect
which can lead to console_loglevel to be set as an unexpected value.

Problem may occur when "echo t > /proc/sysrq-trigger" is called on 
multiple cpus concurrently.

In this case in __handle_sysrq, console_loglevel is set to 7 to print
some head info to the console then restore it. But without lock protect
in parallel execution situation, restoring may go wrong. The new 
loglevel may be taken as the previous loglevel incorrectly.
Console_loglevel can be 7 at last, which causes the terminal to output
info in most log levels.

This bug was found on linux 4.19

Signed-off-by: Feilong Lin <linfeilong@huawei.com>
Reported-by: Kai Shen <shenkai8@huawei.com>
---
 drivers/tty/sysrq.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index f724962..cbb48a9 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -1087,6 +1087,8 @@ EXPORT_SYMBOL(unregister_sysrq_key);
 /*
  * writing 'C' to /proc/sysrq-trigger is like sysrq-C
  */
+static DEFINE_MUTEX(sysrq_mutex);
+
 static ssize_t write_sysrq_trigger(struct file *file, const char __user *buf,
 				   size_t count, loff_t *ppos)
 {
@@ -1095,7 +1097,9 @@ static ssize_t write_sysrq_trigger(struct file *file, const char __user *buf,
 
 		if (get_user(c, buf))
 			return -EFAULT;
+		mutex_lock(&sysrq_mutex);
 		__handle_sysrq(c, false);
+		mutex_unlock(&sysrq_mutex);
 	}
 
 	return count;
-- 
2.6.4.windows.1



             reply	other threads:[~2020-02-07  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  7:56 Shen Kai [this message]
2020-02-07  8:10 ` [PATCH] add lock proctect to __handle_sysrq in write_sysrq_trigger Greg KH
2020-02-07  9:13   ` shenkai
2020-02-07  9:53     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1581062166-27284-1-git-send-email-shenkai8@huawei.com \
    --to=shenkai8@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hushiyuan@huawei.com \
    --cc=jslaby@suse.com \
    --cc=linfeilong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).