archive mirror
 help / color / mirror / Atom feed
From: "tip-bot2 for Kim Phillips" <>
Cc: Babu Moger <>,
	Kim Phillips <>,
	"Peter Zijlstra (Intel)" <>,
	Ingo Molnar <>,, x86 <>,
	LKML <>
Subject: [tip: perf/core] perf/x86/amd: Add missing L2 misses event spec to AMD Family 17h's event map
Date: Tue, 11 Feb 2020 12:47:45 -0000	[thread overview]
Message-ID: <158142526559.411.16112962778577638815.tip-bot2@tip-bot2> (raw)
In-Reply-To: <>

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     25d387287cf0330abf2aad761ce6eee67326a355
Author:        Kim Phillips <>
AuthorDate:    Tue, 21 Jan 2020 11:12:31 -06:00
Committer:     Ingo Molnar <>
CommitterDate: Tue, 11 Feb 2020 13:17:51 +01:00

perf/x86/amd: Add missing L2 misses event spec to AMD Family 17h's event map

Commit 3fe3331bb285 ("perf/x86/amd: Add event map for AMD Family 17h"),
claimed L2 misses were unsupported, due to them not being found in its
referenced documentation, whose link has now moved [1].

That old documentation listed PMCx064 unit mask bit 3 as:

    "LsRdBlkC: LS Read Block C S L X Change to X Miss."

and bit 0 as:

    "IcFillMiss: IC Fill Miss"

We now have new public documentation [2] with improved descriptions, that
clearly indicate what events those unit mask bits represent:

Bit 3 now clearly states:

    "LsRdBlkC: Data Cache Req Miss in L2 (all types)"

and bit 0 is:

    "IcFillMiss: Instruction Cache Req Miss in L2."

So we can now add support for L2 misses in perf's genericised events as
PMCx064 with both the above unit masks.

[1] The commit's original documentation reference, "Processor Programming
    Reference (PPR) for AMD Family 17h Model 01h, Revision B1 Processors",
    originally available here:

    is now available here:

[2] "Processor Programming Reference (PPR) for Family 17h Model 31h,
    Revision B0 Processors", available here:

Fixes: 3fe3331bb285 ("perf/x86/amd: Add event map for AMD Family 17h")
Reported-by: Babu Moger <>
Signed-off-by: Kim Phillips <>
Signed-off-by: Peter Zijlstra (Intel) <>
Signed-off-by: Ingo Molnar <>
Tested-by: Babu Moger <>
 arch/x86/events/amd/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index 1f22b6b..39eb276 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -250,6 +250,7 @@ static const u64 amd_f17h_perfmon_event_map[PERF_COUNT_HW_MAX] =

      parent reply	other threads:[~2020-02-11 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21 17:12 [PATCH 1/2 v2] " Kim Phillips
2020-01-21 17:12 ` [PATCH 2/2 v2] x86/cpu/amd: Enable the fixed intructions retired free counter IRPERF Kim Phillips
2020-02-11 12:47 ` tip-bot2 for Kim Phillips [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158142526559.411.16112962778577638815.tip-bot2@tip-bot2 \ \ \ \ \ \ \ \ \ \
    --subject='Re: [tip: perf/core] perf/x86/amd: Add missing L2 misses event spec to AMD Family 17h'\''s event map' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).