From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21982C35242 for ; Fri, 14 Feb 2020 19:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8A61206D7 for ; Fri, 14 Feb 2020 19:57:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="nFOW8kz4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389034AbgBNT5t (ORCPT ); Fri, 14 Feb 2020 14:57:49 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:46230 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387401AbgBNT5s (ORCPT ); Fri, 14 Feb 2020 14:57:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1581710266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGsEWDNrQKidFJwaa50lpYzjGiChrJWUAw/LIJ3LzK8=; b=nFOW8kz4oWxRZZv89gwXAXgdzdUQ6vuwyAGS8GPcI7QxC31O4Mc7CJofL/sK9U3igkeOqH bOyLTFbz58ThR/fT3aR8Hw7c2+SaujkVyqoQYPz7BINeZjbGvtz++QtR8qYWZYAAEwkLs1 i33TlGkoyDby/PXq0VJFXN9Y5v9751I= Date: Fri, 14 Feb 2020 16:57:30 -0300 From: Paul Cercueil Subject: Re: [Letux-kernel] [PATCH v2] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter To: "H. Nikolaus Schaller" Cc: Discussions about the Letux Kernel , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Richard Fontana , kernel@pyra-handheld.com, Petr =?UTF-8?b?xaB0ZXRpYXI=?= , Thomas Gleixner , Heiner Kallweit Message-Id: <1581710250.3.10@crapouillou.net> In-Reply-To: References: <0d6b4d383bb29ed5d4710e9706e5ad6c7f92d9da.1581696454.git.hns@goldelico.com> <1581706048.3.3@crapouillou.net> <996F2206-B261-46E3-9167-B48BA7D3C9FF@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le ven., f=E9vr. 14, 2020 at 20:38, H. Nikolaus Schaller=20 a =E9crit : >> Am 14.02.2020 um 20:24 schrieb H. Nikolaus Schaller=20 >> : >>=20 >>=20 >>> Am 14.02.2020 um 19:47 schrieb Paul Cercueil=20 >>> : >>>=20 >>> Hi Nikolaus, >>>=20 >>> What I'd suggest is to write a NVMEM driver for the efuse and=20 >>> retrieve the MAC address cleanly with nvmem_get_mac_address(). >>>=20 >>> It shouldn't be hard to do (there's already code for it in the=20 >>> non-upstream 3.18 kernel for the CI20) and you remove the=20 >>> dependency on uboot. >>=20 >> Interesting approach. I have found this: >>=20 >> https://lore.kernel.org/patchwork/patch/868158/ >>=20 >> but it looks as if it was never finished (I could not locate a V3=20 >> or anything mainline?) >> and and it tries to solve other problems as well. >>=20 Yes, I think it's a bit too complex - it's probably fine to just read=20 chunks of 4 bytes. >>=20 >> And it looks to be much more complex than my "solution" to the=20 >> immediate problem. >>=20 Yes, a proper fix usually means more work ;) >>=20 >> I have to study it to know if I can write a nvmem_get_mac_address(). >=20 > Another question is how to link this very jz4780 specific code to the=20 > generic davicom dm9000 driver? > And where should the new code live. In some jz4780 specific file or=20 > elsewhere? In the dm9000's devicetree node you'd have a "mac-address =3D=20 <&mac_addr>;". The "mac-address" is already a standard property, and=20 the davicom driver already supports it. The "mac_addr" should be a pointer to the efuse cell that corresponds=20 to the MAC address. See the examples at the bottom of=20 Documentation/devicetree/bindings/nvmem/nvmem.yaml and=20 Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml. -Paul >=20 >>=20 >> BR, >> Nikolaus >>=20 >>>=20 >>> -Paul >>>=20 >>>=20 >>> Le ven., f=E9vr. 14, 2020 at 17:07, H. Nikolaus Schaller=20 >>> a =E9crit : >>>> The MIPS Ingenic CI20 board is shipped with a quite old u-boot >>>> (ci20-v2013.10 see https://elinux.org/CI20_Dev_Zone). This passes >>>> the MAC address through dm9000.mac_addr=3Dxx:xx:xx:xx:xx:xx >>>> kernel module parameter to give the board a fixed MAC address. >>>> This is not processed by the dm9000 driver which assigns a random >>>> MAC address on each boot, making DHCP assign a new IP address >>>> each time. >>>> So we add a check for the mac_addr module parameter as a last >>>> resort before assigning a random one. This mechanism can also >>>> be used outside of u-boot to provide a value through modprobe >>>> config. >>>> To parse the MAC address in a new function get_mac_addr() we >>>> use an copy adapted from the ksz884x.c driver which provides >>>> the same functionality. >>>> Signed-off-by: H. Nikolaus Schaller >>>> --- >>>> drivers/net/ethernet/davicom/dm9000.c | 42=20 >>>> +++++++++++++++++++++++++++ >>>> 1 file changed, 42 insertions(+) >>>> diff --git a/drivers/net/ethernet/davicom/dm9000.c=20 >>>> b/drivers/net/ethernet/davicom/dm9000.c >>>> index 1ea3372775e6..7402030b0352 100644 >>>> --- a/drivers/net/ethernet/davicom/dm9000.c >>>> +++ b/drivers/net/ethernet/davicom/dm9000.c >>>> @@ -1409,6 +1409,43 @@ static struct dm9000_plat_data=20 >>>> *dm9000_parse_dt(struct device *dev) >>>> return pdata; >>>> } >>>> +static char *mac_addr =3D ":"; >>>> +module_param(mac_addr, charp, 0); >>>> +MODULE_PARM_DESC(mac_addr, "MAC address"); >>>> + >>>> +static void get_mac_addr(struct net_device *ndev, char *macaddr) >>>> +{ >>>> + int i =3D 0; >>>> + int j =3D 0; >>>> + int got_num =3D 0; >>>> + int num =3D 0; >>>> + >>>> + while (j < ETH_ALEN) { >>>> + if (macaddr[i]) { >>>> + int digit; >>>> + >>>> + got_num =3D 1; >>>> + digit =3D hex_to_bin(macaddr[i]); >>>> + if (digit >=3D 0) >>>> + num =3D num * 16 + digit; >>>> + else if (':' =3D=3D macaddr[i]) >>>> + got_num =3D 2; >>>> + else >>>> + break; >>>> + } else if (got_num) { >>>> + got_num =3D 2; >>>> + } else { >>>> + break; >>>> + } >>>> + if (got_num =3D=3D 2) { >>>> + ndev->dev_addr[j++] =3D (u8)num; >>>> + num =3D 0; >>>> + got_num =3D 0; >>>> + } >>>> + i++; >>>> + } >>>> +} >>>> + >>>> /* >>>> * Search DM9000 board, allocate space and register it >>>> */ >>>> @@ -1679,6 +1716,11 @@ dm9000_probe(struct platform_device *pdev) >>>> ndev->dev_addr[i] =3D ior(db, i+DM9000_PAR); >>>> } >>>> + if (!is_valid_ether_addr(ndev->dev_addr)) { >>>> + mac_src =3D "param"; >>>> + get_mac_addr(ndev, mac_addr); >>>> + } >>>> + >>>> if (!is_valid_ether_addr(ndev->dev_addr)) { >>>> inv_mac_addr =3D true; >>>> eth_hw_addr_random(ndev); >>>> -- >>>> 2.23.0 >>>=20 >>>=20 >>=20 >> _______________________________________________ >> http://projects.goldelico.com/p/gta04-kernel/ >> Letux-kernel mailing list >> Letux-kernel@openphoenux.org >> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel =