From: Paul Cercueil <paul@crapouillou.net>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Cc: linux-mips@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, ralf@linux-mips.org, paulburton@kernel.org,
jiaxun.yang@flygoat.com, chenhc@lemote.com, allison@lohutok.net,
tglx@linutronix.de, daniel.lezcano@linaro.org,
geert+renesas@glider.be, krzk@kernel.org, keescook@chromium.org,
ebiederm@xmission.com, miquel.raynal@bootlin.com,
paul@boddie.org.uk, hns@goldelico.com,
mips-creator-ci20-dev@googlegroups.com
Subject: Re: [PATCH v5 1/7] clk: JZ4780: Add function for enable the second core.
Date: Sun, 16 Feb 2020 11:53:16 -0300 [thread overview]
Message-ID: <1581864796.3.2@crapouillou.net> (raw)
In-Reply-To: <1581792932-108032-3-git-send-email-zhouyanjie@wanyeetech.com>
Hi Zhou,
Le dim., févr. 16, 2020 at 02:55, 周琰杰 (Zhou Yanjie)
<zhouyanjie@wanyeetech.com> a écrit :
> Add "jz4780_core1_enable()" for enable the second core of JZ4780,
> prepare for later commits.
>
> Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
> Tested-by: Paul Boddie <paul@boddie.org.uk>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>
> Notes:
> v5:
> New patch, split from [1/6] in v4.
>
> drivers/clk/ingenic/jz4780-cgu.c | 58
> ++++++++++++++++++++++++++++++++++++----
> 1 file changed, 53 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/ingenic/jz4780-cgu.c
> b/drivers/clk/ingenic/jz4780-cgu.c
> index d07fff1..4f81819 100644
> --- a/drivers/clk/ingenic/jz4780-cgu.c
> +++ b/drivers/clk/ingenic/jz4780-cgu.c
> @@ -16,7 +16,7 @@
>
> /* CGU register offsets */
> #define CGU_REG_CLOCKCONTROL 0x00
> -#define CGU_REG_PLLCONTROL 0x0c
> +#define CGU_REG_LCR 0x04
> #define CGU_REG_APLL 0x10
> #define CGU_REG_MPLL 0x14
> #define CGU_REG_EPLL 0x18
> @@ -46,8 +46,8 @@
> #define CGU_REG_CLOCKSTATUS 0xd4
>
> /* bits within the OPCR register */
> -#define OPCR_SPENDN0 (1 << 7)
> -#define OPCR_SPENDN1 (1 << 6)
> +#define OPCR_SPENDN0 BIT(7)
> +#define OPCR_SPENDN1 BIT(6)
>
> /* bits within the USBPCR register */
> #define USBPCR_USB_MODE BIT(31)
> @@ -88,6 +88,13 @@
> #define USBVBFIL_IDDIGFIL_MASK (0xffff << USBVBFIL_IDDIGFIL_SHIFT)
> #define USBVBFIL_USBVBFIL_MASK (0xffff)
>
> +/* bits within the LCR register */
> +#define LCR_PD_SCPU BIT(31)
> +#define LCR_SCPUS BIT(27)
> +
> +/* bits within the CLKGR1 register */
> +#define CLKGR1_CORE1 BIT(15)
> +
> static struct ingenic_cgu *cgu;
>
> static u8 jz4780_otg_phy_get_parent(struct clk_hw *hw)
> @@ -205,6 +212,47 @@ static const struct clk_ops jz4780_otg_phy_ops =
> {
> .set_rate = jz4780_otg_phy_set_rate,
> };
>
> +static int jz4780_core1_enable(struct clk_hw *hw)
> +{
> + struct ingenic_clk *ingenic_clk = to_ingenic_clk(hw);
> + struct ingenic_cgu *cgu = ingenic_clk->cgu;
> + const unsigned int timeout = 100;
> + unsigned long flags;
> + unsigned int i;
> + u32 lcr, clkgr1;
> +
> + spin_lock_irqsave(&cgu->lock, flags);
> +
> + lcr = readl(cgu->base + CGU_REG_LCR);
> + lcr &= ~LCR_PD_SCPU;
> + writel(lcr, cgu->base + CGU_REG_LCR);
> +
> + clkgr1 = readl(cgu->base + CGU_REG_CLKGR1);
> + clkgr1 &= ~CLKGR1_CORE1;
> + writel(clkgr1, cgu->base + CGU_REG_CLKGR1);
> +
> + spin_unlock_irqrestore(&cgu->lock, flags);
> +
> + /* wait for the CPU to be powered up */
> + for (i = 0; i < timeout; i++) {
> + lcr = readl(cgu->base + CGU_REG_LCR);
> + if (!(lcr & LCR_SCPUS))
> + break;
> + mdelay(1);
> + }
You can use readl_poll_timeout() from <linux/iopoll.h>.
> +
> + if (i == timeout) {
> + pr_err("%s: Wait for power up core1 timeout\n", __func__);
> + return -EBUSY;
> + }
> +
> + return 0;
> +}
> +
> +static const struct clk_ops jz4780_core1_ops = {
> + .enable = jz4780_core1_enable,
> +};
> +
> static const s8 pll_od_encoding[16] = {
> 0x0, 0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7,
> 0x8, 0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf,
> @@ -701,9 +749,9 @@ static const struct ingenic_cgu_clk_info
> jz4780_cgu_clocks[] = {
> },
>
> [JZ4780_CLK_CORE1] = {
> - "core1", CGU_CLK_GATE,
> + "core1", CGU_CLK_CUSTOM,
> .parents = { JZ4780_CLK_CPU, -1, -1, -1 },
> - .gate = { CGU_REG_CLKGR1, 15 },
> + .custom = { &jz4780_core1_ops },
> },
>
> };
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-02-16 14:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 18:55 Introduce SMP support for CI20 (based on JZ4780) v5 周琰杰 (Zhou Yanjie)
2020-02-15 18:55 ` [PATCH v5 0/7] Introduce SMP support for JZ4780 周琰杰 (Zhou Yanjie)
2020-02-15 18:55 ` [PATCH v5 1/7] clk: JZ4780: Add function for enable the second core 周琰杰 (Zhou Yanjie)
2020-02-16 14:53 ` Paul Cercueil [this message]
2020-02-19 7:56 ` Zhou Yanjie
2020-02-15 18:55 ` [PATCH v5 2/7] MIPS: JZ4780: Introduce SMP support 周琰杰 (Zhou Yanjie)
2020-02-16 14:59 ` Paul Cercueil
2020-02-19 7:57 ` Zhou Yanjie
2020-02-15 18:55 ` [PATCH v5 3/7] MIPS: CI20: Modify DTS to support high resolution timer for SMP 周琰杰 (Zhou Yanjie)
2020-02-15 18:55 ` [PATCH v5 4/7] clocksource: Ingenic: Add high resolution timer support " 周琰杰 (Zhou Yanjie)
2020-02-15 18:55 ` [PATCH v5 5/7] dt-bindings: MIPS: Document Ingenic SoCs binding 周琰杰 (Zhou Yanjie)
2020-02-18 20:22 ` Rob Herring
2020-02-15 18:55 ` [PATCH v5 6/7] MIPS: Ingenic: Add 'cpus' node for Ingenic SoCs 周琰杰 (Zhou Yanjie)
2020-02-15 18:55 ` [PATCH v5 7/7] MIPS: CI20: Update defconfig to support SMP 周琰杰 (Zhou Yanjie)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581864796.3.2@crapouillou.net \
--to=paul@crapouillou.net \
--cc=allison@lohutok.net \
--cc=chenhc@lemote.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=geert+renesas@glider.be \
--cc=hns@goldelico.com \
--cc=jiaxun.yang@flygoat.com \
--cc=keescook@chromium.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mips-creator-ci20-dev@googlegroups.com \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=paul@boddie.org.uk \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).