From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D63C4332F for ; Thu, 21 Apr 2022 19:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1392049AbiDUTqL (ORCPT ); Thu, 21 Apr 2022 15:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381688AbiDUTqJ (ORCPT ); Thu, 21 Apr 2022 15:46:09 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1265A4CD65 for ; Thu, 21 Apr 2022 12:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650570196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HY/Y/H/17IRgZ8TLehrQxHtPGAMYrsVKwrowN9rRTBY=; b=EG8j3C8vYTi7PWsC9vAlKNvGwTAWTnDMVQxl+tWpUxtKgyjjyn53iiPs71Smh8uK34Uxul wcx1gIsWJW3OKcH2KIG0sDKFNM9N1fp7o3Vviezu2GLqOeB/FnK5yE4xkztATB/ZPTULfi Cpt37jlOTxvP3i5RLfjOZzQ4ceyQDrk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-QKOUykq9OeKAQVp5kgLdMg-1; Thu, 21 Apr 2022 15:43:14 -0400 X-MC-Unique: QKOUykq9OeKAQVp5kgLdMg-1 Received: by mail-wm1-f72.google.com with SMTP id y11-20020a7bc18b000000b0038eac019fc0so2808415wmi.9 for ; Thu, 21 Apr 2022 12:43:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HY/Y/H/17IRgZ8TLehrQxHtPGAMYrsVKwrowN9rRTBY=; b=HQxtcx7twNbVlvlfaTYCJ131gH7MIPknKGyBTljTKgVnN/NGp2i5n095C9Zy43ddtP ei+yicVT7omlA0OMPv6r7hICRr3hxCqXKZALMLK/bm+LEnPoVZf+x7FC03WJAdEy9Po+ oJCgid5m5/HSDNIgiMiO26Nb4gc5/zhc/II3f1YKyViHONmXwXYKDh+mtb88ZS7OcQFh GHa79rcZ1j6v3nneYTyI8UouOguwWgblqHR1nJcmFi7kRgkDg6drwL353PUFd04ImZT9 PgHGexSpYlsMWaf85ZzhV3VL89xAvCqApppfAn1H3XTG9qlnkykuNI4gZlKXV4mPbAo2 /UnQ== X-Gm-Message-State: AOAM53056ahx3DMcSjhw01BMbFNrAhF9+u3L3zVDoX88JvqTIvZsp1Gx huseebcFreI+m+8z59EXDXNSzStutt6sP0zwfxiDyOW67toKTrgmRcMIcvRPn8KDd2J5fG2x2aN 0svmDRxhm/YIgK769aLQcI1OG X-Received: by 2002:a05:600c:500c:b0:392:b12f:40a with SMTP id n12-20020a05600c500c00b00392b12f040amr839643wmr.122.1650570193544; Thu, 21 Apr 2022 12:43:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWKuSC3D47oP0rl1UOs4/4L+Z6e+SmEavaAc79ryCsyW6sduv4quDsOldf6ZZAcgbNeVs8ow== X-Received: by 2002:a05:600c:500c:b0:392:b12f:40a with SMTP id n12-20020a05600c500c00b00392b12f040amr839629wmr.122.1650570193283; Thu, 21 Apr 2022 12:43:13 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id l8-20020a5d5608000000b00207ab405d15sm2860622wrv.42.2022.04.21.12.43.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 12:43:12 -0700 (PDT) Message-ID: <1581f3b5-f965-5289-da15-fc1802cdbf68@redhat.com> Date: Thu, 21 Apr 2022 21:43:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] KVM: Fix build error on s390 due to kvm_flush_shadow_all() being hidden Content-Language: en-US To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang References: <20220421192645.3762857-1-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20220421192645.3762857-1-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/22 21:26, Sean Christopherson wrote: > Hoist kvm_flush_shadow_all() out of the #ifdef block that depends on the > mmu_notifier being enabled and wanted by KVM. KVM s390 doesn't utilize > the mmu_notifier, and so the direct call to kvm_flush_shadow_all() in > vm_destroy() rightly complains. > > virt/kvm/kvm_main.c: In function ‘kvm_destroy_vm’: > virt/kvm/kvm_main.c:1248:9: error: implicit declaration of function ‘kvm_flush_shadow_all’; > did you mean ‘kvm_arch_flush_shadow_all’? [-Werror=implicit-function-declaration] > 1248 | kvm_flush_shadow_all(kvm); > | ^~~~~~~~~~~~~~~~~~~~ > | kvm_arch_flush_shadow_all > > Fixes: b56a4ff6bff3 ("KVM: SEV: add cache flush to solve SEV cache incoherency issues") > Cc: stable@vger.kernel.org > Cc: Mingwei Zhang > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index a719e52f3eb7..f30bb8c16f26 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -361,6 +361,12 @@ void kvm_flush_remote_tlbs(struct kvm *kvm) > EXPORT_SYMBOL_GPL(kvm_flush_remote_tlbs); > #endif > > +static void kvm_flush_shadow_all(struct kvm *kvm) > +{ > + kvm_arch_flush_shadow_all(kvm); > + kvm_arch_guest_memory_reclaimed(kvm); > +} > + > #ifdef KVM_ARCH_NR_OBJS_PER_MEMORY_CACHE > static inline void *mmu_memory_cache_alloc_obj(struct kvm_mmu_memory_cache *mc, > gfp_t gfp_flags) > @@ -820,12 +826,6 @@ static int kvm_mmu_notifier_test_young(struct mmu_notifier *mn, > kvm_test_age_gfn); > } > > -static void kvm_flush_shadow_all(struct kvm *kvm) > -{ > - kvm_arch_flush_shadow_all(kvm); > - kvm_arch_guest_memory_reclaimed(kvm); > -} > - > static void kvm_mmu_notifier_release(struct mmu_notifier *mn, > struct mm_struct *mm) > { > > base-commit: b56a4ff6bff38fc49d8e583a3fbb5e18d1a99963 Thanks, I'll squash this. Paolo