* [PATCH] drm/mediatek: component type MTK_DISP_OVL_2L is not correctly handled
@ 2020-02-19 14:13 Phong LE
2020-02-20 1:36 ` CK Hu
0 siblings, 1 reply; 3+ messages in thread
From: Phong LE @ 2020-02-19 14:13 UTC (permalink / raw)
To: CK Hu, Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger
Cc: dri-devel, linux-arm-kernel, linux-mediatek, linux-kernel, Phong LE
The larb device remains NULL if the type is MTK_DISP_OVL_2L.
A kernel panic is raised when a crtc uses mtk_smi_larb_get or
mtk_smi_larb_put.
Signed-off-by: Phong LE <ple@baylibre.com>
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
index 1f5a112bb034..57c88de9a329 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
@@ -471,6 +471,7 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node,
/* Only DMA capable components need the LARB property */
comp->larb_dev = NULL;
if (type != MTK_DISP_OVL &&
+ type != MTK_DISP_OVL_2L &&
type != MTK_DISP_RDMA &&
type != MTK_DISP_WDMA)
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/mediatek: component type MTK_DISP_OVL_2L is not correctly handled
2020-02-19 14:13 [PATCH] drm/mediatek: component type MTK_DISP_OVL_2L is not correctly handled Phong LE
@ 2020-02-20 1:36 ` CK Hu
2020-02-25 5:07 ` CK Hu
0 siblings, 1 reply; 3+ messages in thread
From: CK Hu @ 2020-02-20 1:36 UTC (permalink / raw)
To: Phong LE
Cc: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
dri-devel, linux-arm-kernel, linux-mediatek, linux-kernel
Hi, Phong:
On Wed, 2020-02-19 at 15:13 +0100, Phong LE wrote:
> The larb device remains NULL if the type is MTK_DISP_OVL_2L.
> A kernel panic is raised when a crtc uses mtk_smi_larb_get or
> mtk_smi_larb_put.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Phong LE <ple@baylibre.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> index 1f5a112bb034..57c88de9a329 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> @@ -471,6 +471,7 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node,
> /* Only DMA capable components need the LARB property */
> comp->larb_dev = NULL;
> if (type != MTK_DISP_OVL &&
> + type != MTK_DISP_OVL_2L &&
> type != MTK_DISP_RDMA &&
> type != MTK_DISP_WDMA)
> return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/mediatek: component type MTK_DISP_OVL_2L is not correctly handled
2020-02-20 1:36 ` CK Hu
@ 2020-02-25 5:07 ` CK Hu
0 siblings, 0 replies; 3+ messages in thread
From: CK Hu @ 2020-02-25 5:07 UTC (permalink / raw)
To: Phong LE
Cc: Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
dri-devel, linux-arm-kernel, linux-mediatek, linux-kernel
Hi, Phong:
On Thu, 2020-02-20 at 09:36 +0800, CK Hu wrote:
> Hi, Phong:
>
> On Wed, 2020-02-19 at 15:13 +0100, Phong LE wrote:
> > The larb device remains NULL if the type is MTK_DISP_OVL_2L.
> > A kernel panic is raised when a crtc uses mtk_smi_larb_get or
> > mtk_smi_larb_put.
> >
>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
Applied to mediatek-drm-fixes-5.6 [1], thanks.
[1]
https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.6
Regards,
CK
> > Signed-off-by: Phong LE <ple@baylibre.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > index 1f5a112bb034..57c88de9a329 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > @@ -471,6 +471,7 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node,
> > /* Only DMA capable components need the LARB property */
> > comp->larb_dev = NULL;
> > if (type != MTK_DISP_OVL &&
> > + type != MTK_DISP_OVL_2L &&
> > type != MTK_DISP_RDMA &&
> > type != MTK_DISP_WDMA)
> > return 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-25 5:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 14:13 [PATCH] drm/mediatek: component type MTK_DISP_OVL_2L is not correctly handled Phong LE
2020-02-20 1:36 ` CK Hu
2020-02-25 5:07 ` CK Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).