linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding
@ 2020-02-22  0:08 Anson Huang
  2020-02-22  0:08 ` [PATCH V16 2/5] thermal: of-thermal: add API for getting sensor ID from DT Anson Huang
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Anson Huang @ 2020-02-22  0:08 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, rui.zhang, daniel.lezcano, amit.kucheria,
	aisheng.dong, linux, srinivas.kandagatla, krzk, fugang.duan,
	peng.fan, daniel.baluta, bjorn.andersson, olof, dinguyen,
	leonard.crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm
  Cc: Linux-imx

NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as
system controller, the system controller is in charge of system
power, clock and thermal sensors etc. management, Linux kernel
has to communicate with system controller via MU (message unit)
IPC to get temperature from thermal sensors, this patch adds
binding doc for i.MX system controller thermal driver.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
No change.
---
 .../devicetree/bindings/arm/freescale/fsl,scu.txt        | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index e07735a8..7f42cc3 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -166,6 +166,17 @@ Required properties:
               followed by "fsl,imx-sc-key";
 - linux,keycodes: See Documentation/devicetree/bindings/input/keys.txt
 
+Thermal bindings based on SCU Message Protocol
+------------------------------------------------------------
+
+Required properties:
+- compatible:			Should be :
+				  "fsl,imx8qxp-sc-thermal"
+				followed by "fsl,imx-sc-thermal";
+
+- #thermal-sensor-cells:	See Documentation/devicetree/bindings/thermal/thermal.txt
+				for a description.
+
 Example (imx8qxp):
 -------------
 aliases {
@@ -238,6 +249,11 @@ firmware {
 			compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
 			timeout-sec = <60>;
 		};
+
+		tsens: thermal-sensor {
+			compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal";
+			#thermal-sensor-cells = <1>;
+		};
 	};
 };
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V16 2/5] thermal: of-thermal: add API for getting sensor ID from DT
  2020-02-22  0:08 [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Anson Huang
@ 2020-02-22  0:08 ` Anson Huang
  2020-02-22  0:08 ` [PATCH V16 3/5] thermal: imx_sc: add i.MX system controller thermal support Anson Huang
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Anson Huang @ 2020-02-22  0:08 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, rui.zhang, daniel.lezcano, amit.kucheria,
	aisheng.dong, linux, srinivas.kandagatla, krzk, fugang.duan,
	peng.fan, daniel.baluta, bjorn.andersson, olof, dinguyen,
	leonard.crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm
  Cc: Linux-imx

This patch adds new API thermal_zone_of_get_sensor_id() to
provide the feature of getting sensor ID from DT thermal
zone's node. It's useful for thermal driver to register the
specific thermal zone devices from DT in a common way.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
Changes since V15:
	- Improve the logic of *id initializtion from sensor_specs.args_count.
---
 drivers/thermal/of-thermal.c | 62 ++++++++++++++++++++++++++++++++------------
 include/linux/thermal.h      | 10 +++++++
 2 files changed, 56 insertions(+), 16 deletions(-)

diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index ef0baa9..874a47d 100644
--- a/drivers/thermal/of-thermal.c
+++ b/drivers/thermal/of-thermal.c
@@ -449,6 +449,50 @@ thermal_zone_of_add_sensor(struct device_node *zone,
 }
 
 /**
+ * thermal_zone_of_get_sensor_id - get sensor ID from a DT thermal zone
+ * @tz_np: a valid thermal zone device node.
+ * @sensor_np: a sensor node of a valid sensor device.
+ * @id: the sensor ID returned if success.
+ *
+ * This function will get sensor ID from a given thermal zone node and
+ * the sensor node must match the temperature provider @sensor_np.
+ *
+ * Return: 0 on success, proper error code otherwise.
+ */
+
+int thermal_zone_of_get_sensor_id(struct device_node *tz_np,
+				  struct device_node *sensor_np,
+				  u32 *id)
+{
+	struct of_phandle_args sensor_specs;
+	int ret;
+
+	ret = of_parse_phandle_with_args(tz_np,
+					 "thermal-sensors",
+					 "#thermal-sensor-cells",
+					 0,
+					 &sensor_specs);
+	if (ret)
+		return ret;
+
+	if (sensor_specs.np != sensor_np) {
+		of_node_put(sensor_specs.np);
+		return -ENODEV;
+	}
+
+	if (sensor_specs.args_count > 1)
+		pr_warn("%pOFn: too many cells in sensor specifier %d\n",
+		     sensor_specs.np, sensor_specs.args_count);
+
+	*id = sensor_specs.args_count ? sensor_specs.args[0] : 0;
+
+	of_node_put(sensor_specs.np);
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(thermal_zone_of_get_sensor_id);
+
+/**
  * thermal_zone_of_sensor_register - registers a sensor to a DT thermal zone
  * @dev: a valid struct device pointer of a sensor device. Must contain
  *       a valid .of_node, for the sensor node.
@@ -499,36 +543,22 @@ thermal_zone_of_sensor_register(struct device *dev, int sensor_id, void *data,
 	sensor_np = of_node_get(dev->of_node);
 
 	for_each_available_child_of_node(np, child) {
-		struct of_phandle_args sensor_specs;
 		int ret, id;
 
 		/* For now, thermal framework supports only 1 sensor per zone */
-		ret = of_parse_phandle_with_args(child, "thermal-sensors",
-						 "#thermal-sensor-cells",
-						 0, &sensor_specs);
+		ret = thermal_zone_of_get_sensor_id(child, sensor_np, &id);
 		if (ret)
 			continue;
 
-		if (sensor_specs.args_count >= 1) {
-			id = sensor_specs.args[0];
-			WARN(sensor_specs.args_count > 1,
-			     "%pOFn: too many cells in sensor specifier %d\n",
-			     sensor_specs.np, sensor_specs.args_count);
-		} else {
-			id = 0;
-		}
-
-		if (sensor_specs.np == sensor_np && id == sensor_id) {
+		if (id == sensor_id) {
 			tzd = thermal_zone_of_add_sensor(child, sensor_np,
 							 data, ops);
 			if (!IS_ERR(tzd))
 				tzd->ops->set_mode(tzd, THERMAL_DEVICE_ENABLED);
 
-			of_node_put(sensor_specs.np);
 			of_node_put(child);
 			goto exit;
 		}
-		of_node_put(sensor_specs.np);
 	}
 exit:
 	of_node_put(sensor_np);
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 126913c6..53e6f67 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -364,6 +364,9 @@ struct thermal_trip {
 
 /* Function declarations */
 #ifdef CONFIG_THERMAL_OF
+int thermal_zone_of_get_sensor_id(struct device_node *tz_np,
+				  struct device_node *sensor_np,
+				  u32 *id);
 struct thermal_zone_device *
 thermal_zone_of_sensor_register(struct device *dev, int id, void *data,
 				const struct thermal_zone_of_device_ops *ops);
@@ -375,6 +378,13 @@ struct thermal_zone_device *devm_thermal_zone_of_sensor_register(
 void devm_thermal_zone_of_sensor_unregister(struct device *dev,
 					    struct thermal_zone_device *tz);
 #else
+
+static int thermal_zone_of_get_sensor_id(struct device_node *tz_np,
+					 struct device_node *sensor_np,
+					 u32 *id)
+{
+	return -ENOENT;
+}
 static inline struct thermal_zone_device *
 thermal_zone_of_sensor_register(struct device *dev, int id, void *data,
 				const struct thermal_zone_of_device_ops *ops)
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V16 3/5] thermal: imx_sc: add i.MX system controller thermal support
  2020-02-22  0:08 [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Anson Huang
  2020-02-22  0:08 ` [PATCH V16 2/5] thermal: of-thermal: add API for getting sensor ID from DT Anson Huang
@ 2020-02-22  0:08 ` Anson Huang
  2020-02-22  0:08 ` [PATCH V16 4/5] defconfig: arm64: " Anson Huang
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Anson Huang @ 2020-02-22  0:08 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, rui.zhang, daniel.lezcano, amit.kucheria,
	aisheng.dong, linux, srinivas.kandagatla, krzk, fugang.duan,
	peng.fan, daniel.baluta, bjorn.andersson, olof, dinguyen,
	leonard.crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm
  Cc: Linux-imx

i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
inside, the system controller is in charge of controlling power,
clock and thermal sensors etc..

This patch adds i.MX system controller thermal driver support,
Linux kernel has to communicate with system controller via MU
(message unit) IPC to get each thermal sensor's temperature,
it supports multiple sensors which are passed from device tree,
please see the binding doc for details.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
Changes since V15:
	- Improve the compile dependency;
	- Fix the copyright year;
	- Add .remove callback.
---
 drivers/thermal/Kconfig          |  11 +++
 drivers/thermal/Makefile         |   1 +
 drivers/thermal/imx_sc_thermal.c | 148 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 160 insertions(+)
 create mode 100644 drivers/thermal/imx_sc_thermal.c

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 5a05db5..3502ee8 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -251,6 +251,17 @@ config IMX_THERMAL
 	  cpufreq is used as the cooling device to throttle CPUs when the
 	  passive trip is crossed.
 
+config IMX_SC_THERMAL
+	tristate "Temperature sensor driver for NXP i.MX SoCs with System Controller"
+	depends on IMX_SCU || COMPILE_TEST
+	depends on OF
+	help
+	  Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with
+	  system controller inside, Linux kernel has to communicate with system
+	  controller via MU (message unit) IPC to get temperature from thermal
+	  sensor. It supports one critical trip point and one
+	  passive trip point for each thermal sensor.
+
 config MAX77620_THERMAL
 	tristate "Temperature sensor driver for Maxim MAX77620 PMIC"
 	depends on MFD_MAX77620
diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
index 9fb88e2..a11a6d8 100644
--- a/drivers/thermal/Makefile
+++ b/drivers/thermal/Makefile
@@ -43,6 +43,7 @@ obj-$(CONFIG_DB8500_THERMAL)	+= db8500_thermal.o
 obj-$(CONFIG_ARMADA_THERMAL)	+= armada_thermal.o
 obj-$(CONFIG_TANGO_THERMAL)	+= tango_thermal.o
 obj-$(CONFIG_IMX_THERMAL)	+= imx_thermal.o
+obj-$(CONFIG_IMX_SC_THERMAL)	+= imx_sc_thermal.o
 obj-$(CONFIG_MAX77620_THERMAL)	+= max77620_thermal.o
 obj-$(CONFIG_QORIQ_THERMAL)	+= qoriq_thermal.o
 obj-$(CONFIG_DA9062_THERMAL)	+= da9062-thermal.o
diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
new file mode 100644
index 0000000..4955dfd
--- /dev/null
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -0,0 +1,148 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2018-2020 NXP.
+ */
+
+#include <linux/err.h>
+#include <linux/firmware/imx/sci.h>
+#include <linux/firmware/imx/types.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+#include <linux/thermal.h>
+
+#include "thermal_core.h"
+
+#define IMX_SC_MISC_FUNC_GET_TEMP	13
+
+static struct imx_sc_ipc *thermal_ipc_handle;
+
+struct imx_sc_sensor {
+	struct thermal_zone_device *tzd;
+	u32 resource_id;
+};
+
+struct req_get_temp {
+	u16 resource_id;
+	u8 type;
+} __packed;
+
+struct resp_get_temp {
+	u16 celsius;
+	u8 tenths;
+} __packed;
+
+struct imx_sc_msg_misc_get_temp {
+	struct imx_sc_rpc_msg hdr;
+	union {
+		struct req_get_temp req;
+		struct resp_get_temp resp;
+	} data;
+};
+
+static int imx_sc_thermal_get_temp(void *data, int *temp)
+{
+	struct imx_sc_msg_misc_get_temp msg;
+	struct imx_sc_rpc_msg *hdr = &msg.hdr;
+	struct imx_sc_sensor *sensor = data;
+	int ret;
+
+	msg.data.req.resource_id = sensor->resource_id;
+	msg.data.req.type = IMX_SC_C_TEMP;
+
+	hdr->ver = IMX_SC_RPC_VERSION;
+	hdr->svc = IMX_SC_RPC_SVC_MISC;
+	hdr->func = IMX_SC_MISC_FUNC_GET_TEMP;
+	hdr->size = 2;
+
+	ret = imx_scu_call_rpc(thermal_ipc_handle, &msg, true);
+	if (ret) {
+		dev_err(&sensor->tzd->device, "read temp sensor %d failed, ret %d\n",
+			sensor->resource_id, ret);
+		return ret;
+	}
+
+	*temp = msg.data.resp.celsius * 1000 + msg.data.resp.tenths * 100;
+
+	return 0;
+}
+
+static const struct thermal_zone_of_device_ops imx_sc_thermal_ops = {
+	.get_temp = imx_sc_thermal_get_temp,
+};
+
+static int imx_sc_thermal_probe(struct platform_device *pdev)
+{
+	struct device_node *np, *child, *sensor_np;
+	struct imx_sc_sensor *sensor;
+	int ret;
+
+	ret = imx_scu_get_handle(&thermal_ipc_handle);
+	if (ret)
+		return ret;
+
+	np = of_find_node_by_name(NULL, "thermal-zones");
+	if (!np)
+		return -ENODEV;
+
+	sensor_np = of_node_get(pdev->dev.of_node);
+
+	for_each_available_child_of_node(np, child) {
+		sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
+		if (!sensor) {
+			of_node_put(sensor_np);
+			return -ENOMEM;
+		}
+
+		ret = thermal_zone_of_get_sensor_id(child,
+						    sensor_np,
+						    &sensor->resource_id);
+		if (ret < 0) {
+			dev_err(&pdev->dev,
+				"failed to get valid sensor resource id: %d\n",
+				ret);
+			break;
+		}
+
+		sensor->tzd = devm_thermal_zone_of_sensor_register(&pdev->dev,
+								   sensor->resource_id,
+								   sensor,
+								   &imx_sc_thermal_ops);
+		if (IS_ERR(sensor->tzd)) {
+			dev_err(&pdev->dev, "failed to register thermal zone\n");
+			ret = PTR_ERR(sensor->tzd);
+			break;
+		}
+	}
+
+	of_node_put(sensor_np);
+
+	return ret;
+}
+
+static int imx_sc_thermal_remove(struct platform_device *pdev)
+{
+	return 0;
+}
+
+static const struct of_device_id imx_sc_thermal_table[] = {
+	{ .compatible = "fsl,imx-sc-thermal", },
+	{}
+};
+MODULE_DEVICE_TABLE(of, imx_sc_thermal_table);
+
+static struct platform_driver imx_sc_thermal_driver = {
+		.probe = imx_sc_thermal_probe,
+		.remove	= imx_sc_thermal_remove,
+		.driver = {
+			.name = "imx-sc-thermal",
+			.of_match_table = imx_sc_thermal_table,
+		},
+};
+module_platform_driver(imx_sc_thermal_driver);
+
+MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>");
+MODULE_DESCRIPTION("Thermal driver for NXP i.MX SoCs with system controller");
+MODULE_LICENSE("GPL v2");
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V16 4/5] defconfig: arm64: add i.MX system controller thermal support
  2020-02-22  0:08 [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Anson Huang
  2020-02-22  0:08 ` [PATCH V16 2/5] thermal: of-thermal: add API for getting sensor ID from DT Anson Huang
  2020-02-22  0:08 ` [PATCH V16 3/5] thermal: imx_sc: add i.MX system controller thermal support Anson Huang
@ 2020-02-22  0:08 ` Anson Huang
  2020-03-10  7:01   ` Shawn Guo
  2020-02-22  0:08 ` [PATCH V16 5/5] arm64: dts: imx: add i.MX8QXP " Anson Huang
  2020-02-27  9:09 ` [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Daniel Lezcano
  4 siblings, 1 reply; 9+ messages in thread
From: Anson Huang @ 2020-02-22  0:08 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, rui.zhang, daniel.lezcano, amit.kucheria,
	aisheng.dong, linux, srinivas.kandagatla, krzk, fugang.duan,
	peng.fan, daniel.baluta, bjorn.andersson, olof, dinguyen,
	leonard.crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm
  Cc: Linux-imx

This patch enables CONFIG_IMX_SC_THERMAL as module.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
No change.
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1c74437..1ff479c 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -453,6 +453,7 @@ CONFIG_THERMAL_GOV_POWER_ALLOCATOR=y
 CONFIG_CPU_THERMAL=y
 CONFIG_THERMAL_EMULATION=y
 CONFIG_QORIQ_THERMAL=m
+CONFIG_IMX_SC_THERMAL=m
 CONFIG_ROCKCHIP_THERMAL=m
 CONFIG_RCAR_THERMAL=y
 CONFIG_RCAR_GEN3_THERMAL=y
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V16 5/5] arm64: dts: imx: add i.MX8QXP thermal support
  2020-02-22  0:08 [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Anson Huang
                   ` (2 preceding siblings ...)
  2020-02-22  0:08 ` [PATCH V16 4/5] defconfig: arm64: " Anson Huang
@ 2020-02-22  0:08 ` Anson Huang
  2020-03-10  7:04   ` Shawn Guo
  2020-02-27  9:09 ` [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Daniel Lezcano
  4 siblings, 1 reply; 9+ messages in thread
From: Anson Huang @ 2020-02-22  0:08 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, rui.zhang, daniel.lezcano, amit.kucheria,
	aisheng.dong, linux, srinivas.kandagatla, krzk, fugang.duan,
	peng.fan, daniel.baluta, bjorn.andersson, olof, dinguyen,
	leonard.crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm
  Cc: Linux-imx

Add i.MX8QXP CPU thermal zone support.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
No change.
---
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 36 ++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index fb5f752..0a14fe4 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -11,6 +11,7 @@
 #include <dt-bindings/input/input.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/pinctrl/pads-imx8qxp.h>
+#include <dt-bindings/thermal/thermal.h>
 
 / {
 	interrupt-parent = <&gic>;
@@ -189,6 +190,11 @@
 			compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
 			timeout-sec = <60>;
 		};
+
+		tsens: thermal-sensor {
+			compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal";
+			#thermal-sensor-cells = <1>;
+		};
 	};
 
 	timer {
@@ -586,4 +592,34 @@
 			#clock-cells = <1>;
 		};
 	};
+
+	thermal_zones: thermal-zones {
+		cpu-thermal0 {
+			polling-delay-passive = <250>;
+			polling-delay = <2000>;
+			thermal-sensors = <&tsens IMX_SC_R_SYSTEM>;
+			trips {
+				cpu_alert0: trip0 {
+					temperature = <107000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit0: trip1 {
+					temperature = <127000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+			cooling-maps {
+				map0 {
+					trip = <&cpu_alert0>;
+					cooling-device =
+						<&A35_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						<&A35_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						<&A35_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						<&A35_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+	};
 };
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding
  2020-02-22  0:08 [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Anson Huang
                   ` (3 preceding siblings ...)
  2020-02-22  0:08 ` [PATCH V16 5/5] arm64: dts: imx: add i.MX8QXP " Anson Huang
@ 2020-02-27  9:09 ` Daniel Lezcano
  2020-02-28  0:45   ` Anson Huang
  4 siblings, 1 reply; 9+ messages in thread
From: Daniel Lezcano @ 2020-02-27  9:09 UTC (permalink / raw)
  To: Anson Huang, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, catalin.marinas, will, rui.zhang, amit.kucheria,
	aisheng.dong, linux, srinivas.kandagatla, krzk, fugang.duan,
	peng.fan, daniel.baluta, bjorn.andersson, olof, dinguyen,
	leonard.crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm
  Cc: Linux-imx

On 22/02/2020 01:08, Anson Huang wrote:
> NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as
> system controller, the system controller is in charge of system
> power, clock and thermal sensors etc. management, Linux kernel
> has to communicate with system controller via MU (message unit)
> IPC to get temperature from thermal sensors, this patch adds
> binding doc for i.MX system controller thermal driver.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

I'll will take patches 1, 2 and 3

Thanks!

  -- Daniel

> ---
> No change.
> ---
>  .../devicetree/bindings/arm/freescale/fsl,scu.txt        | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index e07735a8..7f42cc3 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -166,6 +166,17 @@ Required properties:
>                followed by "fsl,imx-sc-key";
>  - linux,keycodes: See Documentation/devicetree/bindings/input/keys.txt
>  
> +Thermal bindings based on SCU Message Protocol
> +------------------------------------------------------------
> +
> +Required properties:
> +- compatible:			Should be :
> +				  "fsl,imx8qxp-sc-thermal"
> +				followed by "fsl,imx-sc-thermal";
> +
> +- #thermal-sensor-cells:	See Documentation/devicetree/bindings/thermal/thermal.txt
> +				for a description.
> +
>  Example (imx8qxp):
>  -------------
>  aliases {
> @@ -238,6 +249,11 @@ firmware {
>  			compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
>  			timeout-sec = <60>;
>  		};
> +
> +		tsens: thermal-sensor {
> +			compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal";
> +			#thermal-sensor-cells = <1>;
> +		};
>  	};
>  };
>  
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding
  2020-02-27  9:09 ` [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Daniel Lezcano
@ 2020-02-28  0:45   ` Anson Huang
  0 siblings, 0 replies; 9+ messages in thread
From: Anson Huang @ 2020-02-28  0:45 UTC (permalink / raw)
  To: Daniel Lezcano, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, catalin.marinas, will, rui.zhang, amit.kucheria,
	Aisheng Dong, linux, srinivas.kandagatla, krzk, Andy Duan,
	Peng Fan, Daniel Baluta, bjorn.andersson, olof, dinguyen,
	Leonard Crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm
  Cc: dl-linux-imx

Hi, Shawn
	Will you take patch #4 and #5? Thanks.

Anson

> Subject: Re: [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding
> 
> On 22/02/2020 01:08, Anson Huang wrote:
> > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system
> > controller, the system controller is in charge of system power, clock
> > and thermal sensors etc. management, Linux kernel has to communicate
> > with system controller via MU (message unit) IPC to get temperature
> > from thermal sensors, this patch adds binding doc for i.MX system
> > controller thermal driver.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
> 
> I'll will take patches 1, 2 and 3
> 
> Thanks!
> 
>   -- Daniel
> 
> > ---
> > No change.
> > ---
> >  .../devicetree/bindings/arm/freescale/fsl,scu.txt        | 16
> ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > index e07735a8..7f42cc3 100644
> > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > @@ -166,6 +166,17 @@ Required properties:
> >                followed by "fsl,imx-sc-key";
> >  - linux,keycodes: See
> > Documentation/devicetree/bindings/input/keys.txt
> >
> > +Thermal bindings based on SCU Message Protocol
> > +------------------------------------------------------------
> > +
> > +Required properties:
> > +- compatible:			Should be :
> > +				  "fsl,imx8qxp-sc-thermal"
> > +				followed by "fsl,imx-sc-thermal";
> > +
> > +- #thermal-sensor-cells:	See
> Documentation/devicetree/bindings/thermal/thermal.txt
> > +				for a description.
> > +
> >  Example (imx8qxp):
> >  -------------
> >  aliases {
> > @@ -238,6 +249,11 @@ firmware {
> >  			compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
> >  			timeout-sec = <60>;
> >  		};
> > +
> > +		tsens: thermal-sensor {
> > +			compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-
> thermal";
> > +			#thermal-sensor-cells = <1>;
> > +		};
> >  	};
> >  };
> >
> >
> 
> 
> --
> 
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> linaro.org%2F&amp;data=02%7C01%7CAnson.Huang%40nxp.com%7Ca5fb78
> c828bd40f20c6a08d7bb64c1f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C637183913730069723&amp;sdata=qKt%2BmT7yTwAmtzUkaujB%2
> BuQX0qSzaj32r3cwL0coPAw%3D&amp;reserved=0> Linaro.org │ Open
> source software for ARM SoCs
> 
> Follow Linaro:
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> facebook.com%2Fpages%2FLinaro&amp;data=02%7C01%7CAnson.Huang%4
> 0nxp.com%7Ca5fb78c828bd40f20c6a08d7bb64c1f3%7C686ea1d3bc2b4c6fa9
> 2cd99c5c301635%7C0%7C0%7C637183913730069723&amp;sdata=S1QNjqHq
> X1njW436D5jcnZKSmdm%2BZty5sMCO03CvNts%3D&amp;reserved=0>
> Facebook |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitte
> r.com%2F%23!%2Flinaroorg&amp;data=02%7C01%7CAnson.Huang%40nxp.c
> om%7Ca5fb78c828bd40f20c6a08d7bb64c1f3%7C686ea1d3bc2b4c6fa92cd99c
> 5c301635%7C0%7C0%7C637183913730069723&amp;sdata=4j%2FDXNQieTgs
> XhvWWYNSTgnpbj8U0b8SKd62XeBxz8Y%3D&amp;reserved=0> Twitter |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> linaro.org%2Flinaro-
> blog%2F&amp;data=02%7C01%7CAnson.Huang%40nxp.com%7Ca5fb78c828
> bd40f20c6a08d7bb64c1f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C637183913730069723&amp;sdata=onbNbXAbnxwYwUTMpG5jGtsfmN%
> 2BMJF8JVZV2YS0bbJw%3D&amp;reserved=0> Blog


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH V16 4/5] defconfig: arm64: add i.MX system controller thermal support
  2020-02-22  0:08 ` [PATCH V16 4/5] defconfig: arm64: " Anson Huang
@ 2020-03-10  7:01   ` Shawn Guo
  0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2020-03-10  7:01 UTC (permalink / raw)
  To: Anson Huang
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam,
	catalin.marinas, will, rui.zhang, daniel.lezcano, amit.kucheria,
	aisheng.dong, linux, srinivas.kandagatla, krzk, fugang.duan,
	peng.fan, daniel.baluta, bjorn.andersson, olof, dinguyen,
	leonard.crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm, Linux-imx

On Sat, Feb 22, 2020 at 08:08:51AM +0800, Anson Huang wrote:
> This patch enables CONFIG_IMX_SC_THERMAL as module.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Prefix should be 'arm64: defconfig: ...'

Fixed it up and applied patch.

Shawn

> ---
> No change.
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 1c74437..1ff479c 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -453,6 +453,7 @@ CONFIG_THERMAL_GOV_POWER_ALLOCATOR=y
>  CONFIG_CPU_THERMAL=y
>  CONFIG_THERMAL_EMULATION=y
>  CONFIG_QORIQ_THERMAL=m
> +CONFIG_IMX_SC_THERMAL=m
>  CONFIG_ROCKCHIP_THERMAL=m
>  CONFIG_RCAR_THERMAL=y
>  CONFIG_RCAR_GEN3_THERMAL=y
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH V16 5/5] arm64: dts: imx: add i.MX8QXP thermal support
  2020-02-22  0:08 ` [PATCH V16 5/5] arm64: dts: imx: add i.MX8QXP " Anson Huang
@ 2020-03-10  7:04   ` Shawn Guo
  0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2020-03-10  7:04 UTC (permalink / raw)
  To: Anson Huang
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam,
	catalin.marinas, will, rui.zhang, daniel.lezcano, amit.kucheria,
	aisheng.dong, linux, srinivas.kandagatla, krzk, fugang.duan,
	peng.fan, daniel.baluta, bjorn.andersson, olof, dinguyen,
	leonard.crestez, marcin.juszkiewicz, devicetree, linux-kernel,
	linux-arm-kernel, linux-pm, Linux-imx

On Sat, Feb 22, 2020 at 08:08:52AM +0800, Anson Huang wrote:
> Add i.MX8QXP CPU thermal zone support.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> No change.
> ---
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 36 ++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index fb5f752..0a14fe4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -11,6 +11,7 @@
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/pinctrl/pads-imx8qxp.h>
> +#include <dt-bindings/thermal/thermal.h>
>  
>  / {
>  	interrupt-parent = <&gic>;
> @@ -189,6 +190,11 @@
>  			compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
>  			timeout-sec = <60>;
>  		};
> +
> +		tsens: thermal-sensor {
> +			compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal";
> +			#thermal-sensor-cells = <1>;
> +		};
>  	};
>  
>  	timer {
> @@ -586,4 +592,34 @@
>  			#clock-cells = <1>;
>  		};
>  	};
> +
> +	thermal_zones: thermal-zones {
> +		cpu-thermal0 {
> +			polling-delay-passive = <250>;
> +			polling-delay = <2000>;
> +			thermal-sensors = <&tsens IMX_SC_R_SYSTEM>;

newline

> +			trips {
> +				cpu_alert0: trip0 {
> +					temperature = <107000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};

newline

> +				cpu_crit0: trip1 {
> +					temperature = <127000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};
> +			};

newline

I fixed them up and applied the patch.

Shawn

> +			cooling-maps {
> +				map0 {
> +					trip = <&cpu_alert0>;
> +					cooling-device =
> +						<&A35_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +						<&A35_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +						<&A35_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +						<&A35_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +			};
> +		};
> +	};
>  };
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-03-10  7:04 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-22  0:08 [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Anson Huang
2020-02-22  0:08 ` [PATCH V16 2/5] thermal: of-thermal: add API for getting sensor ID from DT Anson Huang
2020-02-22  0:08 ` [PATCH V16 3/5] thermal: imx_sc: add i.MX system controller thermal support Anson Huang
2020-02-22  0:08 ` [PATCH V16 4/5] defconfig: arm64: " Anson Huang
2020-03-10  7:01   ` Shawn Guo
2020-02-22  0:08 ` [PATCH V16 5/5] arm64: dts: imx: add i.MX8QXP " Anson Huang
2020-03-10  7:04   ` Shawn Guo
2020-02-27  9:09 ` [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding Daniel Lezcano
2020-02-28  0:45   ` Anson Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).