From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
Andreas Kemnade <andreas@kemnade.info>,
Mathieu Malaterre <malat@debian.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andi Kleen <ak@linux.intel.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com
Subject: Re: [PATCH v6 2/6] Bindings: nvmem: add bindings for JZ4780 efuse
Date: Thu, 27 Feb 2020 11:49:17 -0300 [thread overview]
Message-ID: <1582814957.3.3@crapouillou.net> (raw)
In-Reply-To: <4b243cc120ca6f9a23e217d070e7f6a42f11f8b4.1582715761.git.hns@goldelico.com>
Hi Nikolaus,
Le mer., févr. 26, 2020 at 12:15, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>
> This patch brings support for the JZ4780 efuse. Currently it only
> exposes
> a read only access to the entire 8K bits efuse memory.
>
> Tested-by: Mathieu Malaterre <malat@debian.org>
> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> [converted to yaml]
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 50
> +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
> b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
> new file mode 100644
> index 000000000000..b9c0ea09b335
> --- /dev/null
> +++
> b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ingenic JZ EFUSE driver bindings
> +
> +maintainers:
> + - PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
> +
> +allOf:
> + - $ref: "nvmem.yaml#"
> +
> +properties:
> + compatible:
> + enum:
> + - ingenic,jz4780-efuse
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + # Handle for the ahb for the efuse.
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: ahb2
Your driver does not actually require the clock to be 'ahb2', it will
take the first clock independently of its name. So 'clock-names' can be
dropped.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/jz4780-cgu.h>
> +
> + efuse@134100d0 {
> + compatible = "ingenic,jz4780-efuse";
> + reg = <0x134100d0 0x2c>;
> +
> + clocks = <&cgu JZ4780_CLK_AHB2>;
> + clock-names = "ahb2";
Same here.
Cheers,
-Paul
> + };
> +
> +...
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-02-27 14:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 11:15 [PATCH v6 0/6] MIPS: CI20: Add efuse driver for Ingenic JZ4780 and attach to DM9000 for stable MAC addresses H. Nikolaus Schaller
2020-02-26 11:15 ` [PATCH v6 1/6] nvmem: add driver for JZ4780 efuse H. Nikolaus Schaller
2020-02-27 14:47 ` Paul Cercueil
2020-02-27 15:26 ` H. Nikolaus Schaller
2020-02-28 12:16 ` H. Nikolaus Schaller
2020-02-26 11:15 ` [PATCH v6 2/6] Bindings: nvmem: add bindings " H. Nikolaus Schaller
2020-02-27 14:49 ` Paul Cercueil [this message]
2020-02-27 14:55 ` H. Nikolaus Schaller
2020-02-26 11:15 ` [PATCH v6 3/6] Documentation: ABI: nvmem: add documentation for JZ4780 efuse ABI H. Nikolaus Schaller
2020-02-26 11:15 ` [PATCH v6 4/6] nvmem: MAINTAINERS: add maintainer for JZ4780 efuse driver H. Nikolaus Schaller
2020-02-26 11:16 ` [PATCH v6 5/6] MIPS: DTS: JZ4780: define node for JZ4780 efuse H. Nikolaus Schaller
2020-02-27 14:57 ` Paul Cercueil
2020-02-27 15:26 ` H. Nikolaus Schaller
2020-02-27 15:39 ` Paul Cercueil
2020-02-26 11:16 ` [PATCH v6 6/6] MIPS: DTS: CI20: make DM9000 Ethernet controller use NVMEM to find the default MAC address H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582814957.3.3@crapouillou.net \
--to=paul@crapouillou.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=ak@linux.intel.com \
--cc=andreas@kemnade.info \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=keescook@chromium.org \
--cc=kernel@pyra-handheld.com \
--cc=krzk@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=paulburton@kernel.org \
--cc=prasannatsmkumar@gmail.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).