From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9132C3F2D2 for ; Fri, 28 Feb 2020 14:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97663246A0 for ; Fri, 28 Feb 2020 14:52:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="WfJ+Pvpx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727218AbgB1Ow3 (ORCPT ); Fri, 28 Feb 2020 09:52:29 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:55076 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726788AbgB1Ow2 (ORCPT ); Fri, 28 Feb 2020 09:52:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1582901546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4Hpe5bJONH/FNTVGB+t29zh0HkFZmJeasNEqS8Vfj8=; b=WfJ+Pvpx2y2KhO9bZiFPgod3uTc1OKPAVLSOxLatyiysiWhlrezwc7/XRj5Q/vD1YQxeiW IB3syypfuEwpPisEVQOfZvz+jK1l5QVBZQxKwvLDB3t8RA9uR4b0IUWKI0YCfjYXSe4mgT xHRbv52PO/NQLEFhhkPRtwP3GD9Kygw= Date: Fri, 28 Feb 2020 11:52:03 -0300 From: Paul Cercueil Subject: Re: [PATCH v7 3/7] Bindings: nvmem: add bindings for JZ4780 efuse To: "H. Nikolaus Schaller" Cc: PrasannaKumar Muralidharan , Andreas Kemnade , Mathieu Malaterre , Srinivas Kandagatla , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , Krzysztof Kozlowski , Kees Cook , Andi Kleen , Geert Uytterhoeven , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Message-Id: <1582901523.3.6@crapouillou.net> In-Reply-To: <9B96463B-CEDE-46EF-87C4-395EB919C78F@goldelico.com> References: <1582900837.3.3@crapouillou.net> <9B96463B-CEDE-46EF-87C4-395EB919C78F@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le ven., f=E9vr. 28, 2020 at 15:47, H. Nikolaus Schaller=20 a =E9crit : >=20 >> Am 28.02.2020 um 15:40 schrieb Paul Cercueil : >>=20 >> Hi Nikolaus, >>=20 >>=20 >> Le ven., f=E9vr. 28, 2020 at 14:58, H. Nikolaus Schaller=20 >> a =E9crit : >>> From: PrasannaKumar Muralidharan >>> This patch brings support for the JZ4780 efuse. Currently it only=20 >>> exposes >>> a read only access to the entire 8K bits efuse memory. >>> Tested-by: Mathieu Malaterre >>> Signed-off-by: PrasannaKumar Muralidharan=20 >>> >>> Signed-off-by: Mathieu Malaterre >>> Signed-off-by: H. Nikolaus Schaller >>> [converted to yaml] >>> Signed-off-by: Andreas Kemnade >>> --- >>> .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 49=20 >>> +++++++++++++++++++ >>> 1 file changed, 49 insertions(+) >>> create mode 100644=20 >>> Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml >>> diff --git=20 >>> a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml=20 >>> b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml >>> new file mode 100644 >>> index 000000000000..ce6690c50a34 >>> --- /dev/null >>> +++=20 >>> b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml >>> @@ -0,0 +1,49 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id:=20 >>> http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Ingenic JZ EFUSE driver bindings >>> + >>> +maintainers: >>> + - PrasannaKumar Muralidharan >>> + >>> +allOf: >>> + - $ref: "nvmem.yaml#" >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - ingenic,jz4780-efuse >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + # Handle for the ahb for the efuse. >>> + maxItems: 1 >>> + >>> + clock-names: >>> + items: >>> + - const: ahb2 >>=20 >> You still have clock-names here. You can remove it completely. >=20 > I have just removed them from required: and the examples: because > I think they are optional. Or are they forbidden? The driver does not get its clock by name, it just takes the first one.=20 So having 'clock-names' in the binding is just not needed. -Paul >>=20 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - clocks >>> + >>> +unevaluatedProperties: false >>> + >>> +examples: >>> + - | >>> + #include >>> + >>> + efuse@134100d0 { >>> + compatible =3D "ingenic,jz4780-efuse"; >>> + reg =3D <0x134100d0 0x2c>; >>> + >>> + clocks =3D <&cgu JZ4780_CLK_AHB2>; >>> + }; >>> + >>> +... >>> -- >>> 2.23.0 >=20 > BR, > Nikolaus >=20 =