From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Paul Boddie <paul@boddie.org.uk>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andi Kleen <ak@linux.intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-gpio@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com
Subject: Re: [RFC v2 3/8] drm: ingenic-drm: add MODULE_DEVICE_TABLE
Date: Mon, 02 Mar 2020 16:21:37 -0300 [thread overview]
Message-ID: <1583176897.3.4@crapouillou.net> (raw)
In-Reply-To: <c1b214f88840309c0d05162d59f666c0f7375b95.1582913973.git.hns@goldelico.com>
Hi Nikolaus,
Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> so that the driver can load by matching the device tree
> if compiled as module.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index 6d47ef7b148c..d8617096dd8e 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -844,6 +844,8 @@ static const struct of_device_id
> ingenic_drm_of_match[] = {
> { /* sentinel */ },
> };
>
> +MODULE_DEVICE_TABLE(of, ingenic_drm_of_match);
Please remove the blank line above the MODULE_DEVICE_TABLE() macro.
-Paul
> +
> static struct platform_driver ingenic_drm_driver = {
> .driver = {
> .name = "ingenic-drm",
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-03-02 19:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 18:19 [RFC v2 0/8] MIPS: CI20: add HDMI out support H. Nikolaus Schaller
2020-02-28 18:19 ` [RFC v2 1/8] dt-bindings: display: add ingenic-jz4780-lcd DT Schema H. Nikolaus Schaller
2020-02-28 18:42 ` Sam Ravnborg
2020-03-02 18:55 ` Rob Herring
2020-03-02 19:10 ` Paul Cercueil
2020-03-03 7:21 ` H. Nikolaus Schaller
2020-02-28 18:19 ` [RFC v2 2/8] dt-bindings: display: add ingenic-jz4780-hdmi " H. Nikolaus Schaller
2020-03-02 19:19 ` Paul Cercueil
2020-02-28 18:19 ` [RFC v2 3/8] drm: ingenic-drm: add MODULE_DEVICE_TABLE H. Nikolaus Schaller
2020-03-02 19:21 ` Paul Cercueil [this message]
2020-02-28 18:19 ` [RFC v2 4/8] drm: ingenic: add jz4780 Synopsys HDMI driver H. Nikolaus Schaller
2020-02-28 18:19 ` [RFC v2 5/8] pinctrl: ingenic: add hdmi-ddc pin control group H. Nikolaus Schaller
2020-02-28 22:05 ` Linus Walleij
2020-02-29 6:41 ` H. Nikolaus Schaller
2020-03-02 8:42 ` Linus Walleij
2020-02-28 18:19 ` [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller H. Nikolaus Schaller
2020-03-02 19:27 ` Paul Cercueil
2020-03-11 12:43 ` H. Nikolaus Schaller
2020-03-11 12:43 ` H. Nikolaus Schaller
2020-03-11 13:20 ` Paul Cercueil
2020-03-11 13:20 ` Paul Cercueil
2020-03-11 13:30 ` H. Nikolaus Schaller
2020-03-11 13:30 ` H. Nikolaus Schaller
2020-02-28 18:19 ` [RFC v2 7/8] MIPS: DTS: CI20: add HDMI setup H. Nikolaus Schaller
2020-02-28 18:19 ` [RFC v2 8/8] MIPS: CI20: defconfig: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583176897.3.4@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@linux.ie \
--cc=ak@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=geert+renesas@glider.be \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=krzk@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul@boddie.org.uk \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).