From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6E4C3F2D7 for ; Tue, 3 Mar 2020 04:30:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6413E20716 for ; Tue, 3 Mar 2020 04:30:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbgCCEan (ORCPT ); Mon, 2 Mar 2020 23:30:43 -0500 Received: from foss.arm.com ([217.140.110.172]:42200 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbgCCEan (ORCPT ); Mon, 2 Mar 2020 23:30:43 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 545F52F; Mon, 2 Mar 2020 20:30:42 -0800 (PST) Received: from p8cg001049571a15.blr.arm.com (p8cg001049571a15.blr.arm.com [10.162.16.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 08C093F6CF; Mon, 2 Mar 2020 20:30:38 -0800 (PST) From: Anshuman Khandual To: linux-kernel@vger.kernel.org Cc: Anshuman Khandual , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , sfr@canb.auug.org.au, linux-next@vger.kernel.org Subject: [PATCH] sched/fair: Conditionally enable test_idle_cores() forward declaration Date: Tue, 3 Mar 2020 10:00:26 +0530 Message-Id: <1583209826-28853-1-git-send-email-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org test_idle_cores()'s definition and all it's call sites are enclosed within CONFIG_SCHED_SMT. Hence the forward declaration needs to be conditionally enabled in order to prevent build warnings like the following. kernel/sched/fair.c:1524:20: warning: ‘test_idle_cores’ declared ‘static’ but never defined [-Wunused-function] static inline bool test_idle_cores(int cpu, bool def); ^~~~~~~~~~~~~~~ Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Steven Rostedt Cc: Ben Segall Cc: Mel Gorman Cc: sfr@canb.auug.org.au Cc: linux-next@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual --- This patch solves a build problem that exists on next-20200302. kernel/sched/fair.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 84594f8..827087f 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1521,7 +1521,9 @@ static inline bool is_core_idle(int cpu) } /* Forward declarations of select_idle_sibling helpers */ +#ifdef CONFIG_SCHED_SMT static inline bool test_idle_cores(int cpu, bool def); +#endif struct task_numa_env { struct task_struct *p; -- 2.7.4