From: Nick Fan <nick.fan@mediatek.com>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Rob Herring <robh@kernel.org>, Sj Huang <sj.huang@mediatek.com>,
"David Airlie" <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
Steven Price <steven.price@arm.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Devicetree List <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183
Date: Fri, 6 Mar 2020 10:34:15 +0800 [thread overview]
Message-ID: <1583462055.4947.6.camel@mtksdaap41> (raw)
In-Reply-To: <CANMq1KAVX4o5yC7c_88Wq_O=F+MaSN_V4uNcs1nzS3wBS6A5AA@mail.gmail.com>
Sorry for my late reply.
I have checked internally.
The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D
domain.
If the naming too confusing, we can change this name to
MT8183_POWER_DOMAIN_MFG_CORE2 for consistency.
Thanks
Nick Fan
On Wed, 2020-02-26 at 08:55 +0800, Nicolas Boichat wrote:
> +Nick Fan +Sj Huang @ MTK
>
> On Wed, Feb 26, 2020 at 1:16 AM Rob Herring <robh@kernel.org> wrote:
> >
> > On Fri, Feb 07, 2020 at 01:26:21PM +0800, Nicolas Boichat wrote:
> > > Define a compatible string for the Mali Bifrost GPU found in
> > > Mediatek's MT8183 SoCs.
> > >
> > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> > > Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
> > > ---
> > >
> > > v4:
> > > - Add power-domain-names description
> > > (kept Alyssa's reviewed-by as the change is minor)
> > > v3:
> > > - No change
> > >
> > > .../bindings/gpu/arm,mali-bifrost.yaml | 25 +++++++++++++++++++
> > > 1 file changed, 25 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > > index 4ea6a8789699709..0d93b3981445977 100644
> > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > > @@ -17,6 +17,7 @@ properties:
> > > items:
> > > - enum:
> > > - amlogic,meson-g12a-mali
> > > + - mediatek,mt8183-mali
> > > - realtek,rtd1619-mali
> > > - rockchip,px30-mali
> > > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable
> > > @@ -62,6 +63,30 @@ allOf:
> > > minItems: 2
> > > required:
> > > - resets
> > > + - if:
> > > + properties:
> > > + compatible:
> > > + contains:
> > > + const: mediatek,mt8183-mali
> > > + then:
> > > + properties:
> > > + sram-supply: true
> > > + power-domains:
> > > + description:
> > > + List of phandle and PM domain specifier as documented in
> > > + Documentation/devicetree/bindings/power/power_domain.txt
> > > + minItems: 3
> > > + maxItems: 3
> > > + power-domain-names:
> > > + items:
> > > + - const: core0
> > > + - const: core1
> > > + - const: 2d
> >
> > AFAIK, there's no '2d' block in bifrost GPUs. A power domain for each
> > core group is correct though.
>
> Good question... Hopefully Nick/SJ@MTK can comment, the non-upstream DTS has:
> gpu: mali@13040000 {
> compatible = "mediatek,mt8183-mali", "arm,mali-bifrost";
> power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_CORE0>;
> ...
> }
>
> gpu_core1: mali_gpu_core1 {
> compatible = "mediatek,gpu_core1";
> power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_CORE1>;
> };
>
> gpu_core2: mali_gpu_core2 {
> compatible = "mediatek,gpu_core2";
> power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_2D>;
> };
>
> So I picked core0/core1/2d as names, but looking at this, it's likely
> core2 is more appropriate (and MT8183_POWER_DOMAIN_MFG_2D might just
> be a internal/legacy name, if there is no real 2d domain).
>
> Thanks.
>
> > Rob
next prev parent reply other threads:[~2020-03-06 2:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 5:26 [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Nicolas Boichat
2020-02-25 17:16 ` Rob Herring
2020-02-26 0:55 ` Nicolas Boichat
2020-03-06 2:34 ` Nick Fan [this message]
2020-03-06 2:43 ` Nicolas Boichat
2020-03-06 14:13 ` Rob Herring
2020-03-06 14:43 ` Steven Price
2020-03-09 7:55 ` Nick Fan
2020-02-07 5:26 ` [PATCH v4 2/7] arm64: dts: mt8183: Add node for the Mali GPU Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 3/7] drm/panfrost: Improve error reporting in panfrost_gpu_power_on Nicolas Boichat
2020-02-12 10:38 ` Matthias Brugger
2020-02-07 5:26 ` [PATCH v4 4/7] drm/panfrost: Add support for multiple regulators Nicolas Boichat
2020-02-10 11:31 ` Steven Price
2020-02-10 14:00 ` Mark Brown
2020-02-07 5:26 ` [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains Nicolas Boichat
2020-02-07 13:52 ` Alyssa Rosenzweig
2020-02-09 12:43 ` Nicolas Boichat
2020-02-07 14:25 ` Ulf Hansson
2020-02-09 12:50 ` Nicolas Boichat
2020-02-10 7:50 ` Ulf Hansson
2020-02-10 11:39 ` Steven Price
2020-02-11 19:43 ` Rob Herring
2020-02-11 20:08 ` Saravana Kannan
2020-02-12 1:58 ` Rob Herring
2020-02-12 2:10 ` Saravana Kannan
2020-02-12 2:08 ` Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 6/7] RFC: drm/panfrost: Add mt8183-mali compatible string Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators Nicolas Boichat
2020-02-12 8:49 ` Nicolas Boichat
2020-02-12 9:06 ` Viresh Kumar
2020-02-12 18:14 ` Rob Herring
2020-02-13 7:57 ` Nicolas Boichat
2020-02-13 8:24 ` Nicolas Boichat
2020-02-14 1:37 ` Nick Fan (范哲維)
2020-03-09 1:53 ` Nicolas Boichat
2020-02-07 6:17 ` [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) Tomeu Vizoso
2020-02-07 7:42 ` Nicolas Boichat
2020-02-07 8:13 ` Tomeu Vizoso
2020-02-10 3:39 ` Nicolas Boichat
2020-02-10 8:17 ` Tomeu Vizoso
2020-02-25 20:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583462055.4947.6.camel@mtksdaap41 \
--to=nick.fan@mediatek.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=hsinyi@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sj.huang@mediatek.com \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).