From: Sam Shih <sam.shih@mediatek.com>
To: "Matthias Brugger" <matthias.bgg@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: <linux-pwm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
<linux-mediatek@lists.infradead.org>,
"John Crispin" <john@phrozen.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/1] pwm: mediatek: add longer period support
Date: Mon, 9 Mar 2020 11:35:41 +0800 [thread overview]
Message-ID: <1583724941.15393.8.camel@mtksdccf07> (raw)
In-Reply-To: <20200308201811.hlac57s3h4p4cgev@pengutronix.de>
Hello,
On Sun, 2020-03-08 at 21:18 +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Sat, Mar 07, 2020 at 10:28:36PM +0100, Matthias Brugger wrote:
> > On 03/03/2020 11:19, Sam Shih wrote:
> > > The pwm clock source could be divided by 1625 with PWM_CON
> > > BIT(3) setting in mediatek hardware.
> > >
> > > This patch add support for longer pwm period configuration,
> > > which allowing blinking LEDs via pwm interface.
> >
> > Is this a fix? In this case please provide a Fixes tag with the commit ID which
> > introduced the bug.
>
> I'd say it qualifies as a fix if without it a request with a long period
> returns success but isn't properly implemented. Otherwise it's only a
> new feature.
>
It's only a new feature.
Without this patch, pwm_mediatek_config return -EINVAL when receive a
long period request.
I will send v3 to reply Uwe's comment.
Best Regards,
Sam Shih
prev parent reply other threads:[~2020-03-09 3:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 10:19 [PATCH v2 0/1] pwm: mediatek: add longer period support Sam Shih
2020-03-03 10:19 ` [PATCH v2 1/1] " Sam Shih
2020-03-06 7:41 ` Uwe Kleine-König
2020-03-07 21:28 ` Matthias Brugger
2020-03-08 20:18 ` Uwe Kleine-König
2020-03-09 3:35 ` Sam Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583724941.15393.8.camel@mtksdccf07 \
--to=sam.shih@mediatek.com \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).