* [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG
@ 2020-03-13 18:54 Ansuel Smith
2020-03-13 20:30 ` Stephen Boyd
0 siblings, 1 reply; 6+ messages in thread
From: Ansuel Smith @ 2020-03-13 18:54 UTC (permalink / raw)
To: agross
Cc: Ansuel Smith, Abhishek Sahu, Bjorn Andersson, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk, linux-kernel
kernel got hanged while reading from /dev/hwrng at the
time of PRNG clock enable
Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
drivers/clk/qcom/gcc-ipq806x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
index b0eee0903807..a8456e09c44d 100644
--- a/drivers/clk/qcom/gcc-ipq806x.c
+++ b/drivers/clk/qcom/gcc-ipq806x.c
@@ -1224,6 +1224,8 @@ static struct clk_rcg prng_src = {
.parent_map = gcc_pxo_pll8_map,
},
.clkr = {
+ .enable_reg = 0x2e80,
+ .enable_mask = BIT(11),
.hw.init = &(struct clk_init_data){
.name = "prng_src",
.parent_names = gcc_pxo_pll8,
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG
2020-03-13 18:54 [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG Ansuel Smith
@ 2020-03-13 20:30 ` Stephen Boyd
2020-03-13 21:20 ` R: " ansuelsmth
2020-03-14 13:36 ` [RESEND PATCH] " Ansuel Smith
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Boyd @ 2020-03-13 20:30 UTC (permalink / raw)
To: Ansuel Smith, agross
Cc: Ansuel Smith, Abhishek Sahu, Bjorn Andersson, Michael Turquette,
linux-arm-msm, linux-clk, linux-kernel
Quoting Ansuel Smith (2020-03-13 11:54:06)
> kernel got hanged while reading from /dev/hwrng at the
> time of PRNG clock enable
>
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Is Abhishek the author? Otherwise the tag chain here looks wrong.
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Is there some Fixes: tag we can get here too?
> ---
> drivers/clk/qcom/gcc-ipq806x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* R: [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG
2020-03-13 20:30 ` Stephen Boyd
@ 2020-03-13 21:20 ` ansuelsmth
2020-03-14 1:15 ` Stephen Boyd
2020-03-14 13:36 ` [RESEND PATCH] " Ansuel Smith
1 sibling, 1 reply; 6+ messages in thread
From: ansuelsmth @ 2020-03-13 21:20 UTC (permalink / raw)
To: 'Stephen Boyd', agross
Cc: 'Abhishek Sahu', 'Bjorn Andersson',
'Michael Turquette',
linux-arm-msm, linux-clk, linux-kernel
> -----Messaggio originale-----
> Da: Stephen Boyd <sboyd@kernel.org>
> Inviato: venerdì 13 marzo 2020 21:30
> A: Ansuel Smith <ansuelsmth@gmail.com>; agross@kernel.org
> Cc: Ansuel Smith <ansuelsmth@gmail.com>; Abhishek Sahu
> <absahu@codeaurora.org>; Bjorn Andersson
> <bjorn.andersson@linaro.org>; Michael Turquette
> <mturquette@baylibre.com>; linux-arm-msm@vger.kernel.org; linux-
> clk@vger.kernel.org; linux-kernel@vger.kernel.org
> Oggetto: Re: [PATCH] ipq806x: gcc: Added the enable regs and mask for
> PRNG
>
> Quoting Ansuel Smith (2020-03-13 11:54:06)
> > kernel got hanged while reading from /dev/hwrng at the
> > time of PRNG clock enable
> >
> > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
>
> Is Abhishek the author? Otherwise the tag chain here looks wrong.
>
Yes Abhishek is the author.
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
>
> Is there some Fixes: tag we can get here too?
>
Think I should put the commit that added the gcc. Right?
> > ---
> > drivers/clk/qcom/gcc-ipq806x.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: R: [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG
2020-03-13 21:20 ` R: " ansuelsmth
@ 2020-03-14 1:15 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2020-03-14 1:15 UTC (permalink / raw)
To: agross, ansuelsmth
Cc: 'Abhishek Sahu', 'Bjorn Andersson',
'Michael Turquette',
linux-arm-msm, linux-clk, linux-kernel
Quoting ansuelsmth@gmail.com (2020-03-13 14:20:36)
>
>
> > -----Messaggio originale-----
> > Da: Stephen Boyd <sboyd@kernel.org>
> > Inviato: venerdì 13 marzo 2020 21:30
> > A: Ansuel Smith <ansuelsmth@gmail.com>; agross@kernel.org
> > Cc: Ansuel Smith <ansuelsmth@gmail.com>; Abhishek Sahu
> > <absahu@codeaurora.org>; Bjorn Andersson
> > <bjorn.andersson@linaro.org>; Michael Turquette
> > <mturquette@baylibre.com>; linux-arm-msm@vger.kernel.org; linux-
> > clk@vger.kernel.org; linux-kernel@vger.kernel.org
> > Oggetto: Re: [PATCH] ipq806x: gcc: Added the enable regs and mask for
> > PRNG
> >
> > Quoting Ansuel Smith (2020-03-13 11:54:06)
> > > kernel got hanged while reading from /dev/hwrng at the
> > > time of PRNG clock enable
> > >
> > > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> >
> > Is Abhishek the author? Otherwise the tag chain here looks wrong.
> >
>
> Yes Abhishek is the author.
>
> > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> >
> > Is there some Fixes: tag we can get here too?
> >
>
> Think I should put the commit that added the gcc. Right?
>
Yes.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG
2020-03-13 20:30 ` Stephen Boyd
2020-03-13 21:20 ` R: " ansuelsmth
@ 2020-03-14 13:36 ` Ansuel Smith
2020-03-16 18:31 ` Stephen Boyd
1 sibling, 1 reply; 6+ messages in thread
From: Ansuel Smith @ 2020-03-14 13:36 UTC (permalink / raw)
To: agross
Cc: Ansuel Smith, Abhishek Sahu, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Kumar Gala, linux-arm-msm, linux-clk, linux-kernel
Kernel got hanged while reading from /dev/hwrng at the
time of PRNG clock enable
Fixes: 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global
clock controller (GCC)"
Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
drivers/clk/qcom/gcc-ipq806x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
index b0eee0903807..a8456e09c44d 100644
--- a/drivers/clk/qcom/gcc-ipq806x.c
+++ b/drivers/clk/qcom/gcc-ipq806x.c
@@ -1224,6 +1224,8 @@ static struct clk_rcg prng_src = {
.parent_map = gcc_pxo_pll8_map,
},
.clkr = {
+ .enable_reg = 0x2e80,
+ .enable_mask = BIT(11),
.hw.init = &(struct clk_init_data){
.name = "prng_src",
.parent_names = gcc_pxo_pll8,
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG
2020-03-14 13:36 ` [RESEND PATCH] " Ansuel Smith
@ 2020-03-16 18:31 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2020-03-16 18:31 UTC (permalink / raw)
To: Ansuel Smith, agross
Cc: Ansuel Smith, Abhishek Sahu, Bjorn Andersson, Michael Turquette,
Kumar Gala, linux-arm-msm, linux-clk, linux-kernel
Quoting Ansuel Smith (2020-03-14 06:36:00)
> Kernel got hanged while reading from /dev/hwrng at the
> time of PRNG clock enable
Authorship is still wrong. There should be a From: Abhishek Sahu
<absahu@codeaurora.org> line above this line.
>
> Fixes: 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global
> clock controller (GCC)"
>
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
Also, please don't send as a reply to the older versions of this patch.
It makes it harder to keep track of what is new and what isn't new and
buries it deep in a thread for me.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-16 18:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 18:54 [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG Ansuel Smith
2020-03-13 20:30 ` Stephen Boyd
2020-03-13 21:20 ` R: " ansuelsmth
2020-03-14 1:15 ` Stephen Boyd
2020-03-14 13:36 ` [RESEND PATCH] " Ansuel Smith
2020-03-16 18:31 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).