* [PATCH] rtc: snvs: remove redundant error message
@ 2020-03-15 0:47 Anson Huang
2020-03-15 12:27 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Anson Huang @ 2020-03-15 0:47 UTC (permalink / raw)
To: a.zummo, alexandre.belloni, linux-rtc, linux-kernel; +Cc: Linux-imx
The RTC core already has error message for registration failure,
no need to have error message in the driver again.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/rtc/rtc-snvs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
index 319ed1d..36f4961 100644
--- a/drivers/rtc/rtc-snvs.c
+++ b/drivers/rtc/rtc-snvs.c
@@ -354,8 +354,6 @@ static int snvs_rtc_probe(struct platform_device *pdev)
data->rtc->ops = &snvs_rtc_ops;
data->rtc->range_max = U32_MAX;
ret = rtc_register_device(data->rtc);
- if (ret)
- dev_err(&pdev->dev, "failed to register rtc: %d\n", ret);
return ret;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: snvs: remove redundant error message
2020-03-15 0:47 [PATCH] rtc: snvs: remove redundant error message Anson Huang
@ 2020-03-15 12:27 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-03-15 12:27 UTC (permalink / raw)
To: Anson Huang; +Cc: a.zummo, linux-rtc, linux-kernel, Linux-imx
Hi,
On 15/03/2020 08:47:44+0800, Anson Huang wrote:
> The RTC core already has error message for registration failure,
> no need to have error message in the driver again.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/rtc/rtc-snvs.c | 2 --
> 1 file changed, 2 deletions(-)
>
I squashed that one in your previous patch.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-15 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-15 0:47 [PATCH] rtc: snvs: remove redundant error message Anson Huang
2020-03-15 12:27 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).