From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@redhat.com,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, mark.rutland@arm.com, namhyung@kernel.org
Subject: Re: [PATCH] perf dso: Fix dso comparison
Date: Tue, 24 Mar 2020 19:14:53 +0530 [thread overview]
Message-ID: <1585057428.a1bcmu1ynn.naveen@linux.ibm.com> (raw)
In-Reply-To: <20200324042424.68366-1-ravi.bangoria@linux.ibm.com>
Ravi Bangoria wrote:
> Perf gets dso details from two different sources. 1st, from builid
> headers in perf.data and 2nd from MMAP2 samples. Dso from buildid
> header does not have dso_id detail. And dso from MMAP2 samples does
> not have buildid information. If detail of the same dso is present
> at both the places, filename is common.
>
> Previously, __dsos__findnew_link_by_longname_id() used to compare only
> long or short names, but Commit 0e3149f86b99 ("perf dso: Move dso_id
> from 'struct map' to 'struct dso'") also added a dso_id comparison.
> Because of that, now perf is creating two different dso objects of the
> same file, one from buildid header (with dso_id but without buildid)
> and second from MMAP2 sample (with buildid but without dso_id).
>
> This is causing issues with archive, buildid-list etc subcommands. Fix
> this by comparing dso_id only when it's present. And incase dso is
> present in 'dsos' list without dso_id, inject dso_id detail as well.
>
> Before:
>
> $ sudo ./perf buildid-list -H
> 0000000000000000000000000000000000000000 /usr/bin/ls
> 0000000000000000000000000000000000000000 /usr/lib64/ld-2.30.so
> 0000000000000000000000000000000000000000 /usr/lib64/libc-2.30.so
>
> $ ./perf archive
> perf archive: no build-ids found
>
> After:
>
> $ ./perf buildid-list -H
> b6b1291d0cead046ed0fa5734037fa87a579adee /usr/bin/ls
> 641f0c90cfa15779352f12c0ec3c7a2b2b6f41e8 /usr/lib64/ld-2.30.so
> 675ace3ca07a0b863df01f461a7b0984c65c8b37 /usr/lib64/libc-2.30.so
>
> $ ./perf archive
> Now please run:
>
> $ tar xvf perf.data.tar.bz2 -C ~/.debug
>
> wherever you need to run 'perf report' on.
>
> Reported-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> Fixes: 0e3149f86b99 ("perf dso: Move dso_id from 'struct map' to 'struct dso'")
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> ---
> tools/perf/util/dsos.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
Thanks. This fixes the issue I was facing with 'perf archive' not
picking up the right binaries. So:
Tested-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
- Naveen
next prev parent reply other threads:[~2020-03-24 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 4:24 [PATCH] perf dso: Fix dso comparison Ravi Bangoria
2020-03-24 10:48 ` Jiri Olsa
2020-03-24 12:37 ` Ravi Bangoria
2020-03-24 13:22 ` Jiri Olsa
2020-03-24 13:42 ` Arnaldo Carvalho de Melo
2020-03-24 13:42 ` Ravi Bangoria
2020-03-24 13:00 ` Arnaldo Carvalho de Melo
2020-03-24 13:20 ` Jiri Olsa
2020-03-24 13:21 ` Arnaldo Carvalho de Melo
2020-03-24 13:44 ` Naveen N. Rao [this message]
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585057428.a1bcmu1ynn.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).