From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Ionela Voinescu <ionela.voinescu@arm.com>,
Jon Hunter <jonathanh@nvidia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Saravana Kannan <saravanak@google.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [tip: timers/core] Revert "clocksource/drivers/timer-probe: Avoid creating dead devices"
Date: Sat, 28 Mar 2020 10:30:58 -0000 [thread overview]
Message-ID: <158539145844.28353.14324600021087747539.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200324175955.GA16972@arm.com>
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 4479730e9263befbb9ce9563a09563db2acb8f7c
Gitweb: https://git.kernel.org/tip/4479730e9263befbb9ce9563a09563db2acb8f7c
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sat, 28 Mar 2020 11:20:36 +01:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sat, 28 Mar 2020 11:25:44 +01:00
Revert "clocksource/drivers/timer-probe: Avoid creating dead devices"
This reverts commit 4f41fe386a94639cd9a1831298d4f85db5662f1e.
The change breaks systems on which the DT node of a device is used by
multiple drivers. The proposed workaround to clear OF_POPULATED is just a
band aid and this needs to be cleaned up at the root of the problem.
Revert this for now.
Reported-by: Ionela Voinescu <ionela.voinescu@arm.com>
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Requested-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Saravana Kannan <saravanak@google.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20200324175955.GA16972@arm.com
---
drivers/clocksource/timer-probe.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clocksource/timer-probe.c b/drivers/clocksource/timer-probe.c
index a10f28d..ee9574d 100644
--- a/drivers/clocksource/timer-probe.c
+++ b/drivers/clocksource/timer-probe.c
@@ -27,10 +27,8 @@ void __init timer_probe(void)
init_func_ret = match->data;
- of_node_set_flag(np, OF_POPULATED);
ret = init_func_ret(np);
if (ret) {
- of_node_clear_flag(np, OF_POPULATED);
if (ret != -EPROBE_DEFER)
pr_err("Failed to initialize '%pOF': %d\n", np,
ret);
prev parent reply other threads:[~2020-03-28 10:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 5:21 [PATCH v1] clocksource: Avoid creating dead devices Saravana Kannan
2020-02-19 2:20 ` Saravana Kannan
2020-02-27 9:06 ` Daniel Lezcano
2020-02-27 21:22 ` Saravana Kannan
2020-03-04 19:30 ` Saravana Kannan
2020-03-04 19:56 ` Daniel Lezcano
2020-03-08 5:53 ` Saravana Kannan
2020-03-16 14:57 ` Daniel Lezcano
2020-03-16 17:49 ` Saravana Kannan
2020-03-16 18:07 ` Daniel Lezcano
2020-03-16 18:15 ` Saravana Kannan
[not found] ` <5e70b653.1c69fb81.b03d8.d2bbSMTPIN_ADDED_MISSING@mx.google.com>
2020-03-17 18:08 ` Saravana Kannan
2020-03-17 18:18 ` Daniel Lezcano
2020-03-19 8:47 ` [tip: timers/core] clocksource/drivers/timer-probe: " tip-bot2 for Saravana Kannan
2020-03-24 17:59 ` Ionela Voinescu
2020-03-24 18:34 ` Saravana Kannan
2020-03-24 19:56 ` Saravana Kannan
2020-03-25 21:47 ` Thomas Gleixner
2020-03-25 22:56 ` Saravana Kannan
2020-03-25 23:06 ` Saravana Kannan
2020-03-26 10:17 ` Daniel Lezcano
2020-03-26 17:35 ` Saravana Kannan
2020-03-26 10:33 ` Thomas Gleixner
2020-03-26 15:02 ` Rob Herring
2020-03-26 18:08 ` Saravana Kannan
2020-03-28 2:23 ` Rob Herring
2020-03-25 21:29 ` Jon Hunter
2020-03-26 1:21 ` Dmitry Osipenko
2020-03-28 10:30 ` tip-bot2 for Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158539145844.28353.14324600021087747539.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=ionela.voinescu@arm.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).